Today I was on
admin/config/development/configuration/single/export
(the configuration export page).
To get there, I went to:
Manage (top black bar) > Configuration (white menu bar) > Development (find this section, not actually a click) > Configuration management (click link) > Single import / export (click local task tab) > Export (click local action)
But the breadcrumb on the page shows, confusingly:
Home > Administration > Configuration > Development > Synchronize
Here's a screen shot:
This is just wrong:
- Manage is shown as Administration
- Configuration management is completely missing from the trail.
- Instead of showing the local task tab I'm actually underneath (Single import / export), it is showing the default local task (Synchronize).
This is very broken.
Beta phase evaluation
Issue category | Bug because of errors with the display of a breadcrumb. |
---|---|
Issue priority | Major because the Configuration Management breadcrumb for subtasks was broken. |
Prioritized changes | The main goal of this issue is usability. |
Comment | File | Size | Author |
---|---|---|---|
#40 | 2310175-40.patch | 489 bytes | pooja saraah |
| |||
#20 | After_Patch.JPG | 64.96 KB | Truptti |
#20 | Patch_applied.JPG | 25.44 KB | Truptti |
#3 | drupal-config-breadcrumb-confusion-2310175-3-D8.patch | 483 bytes | Scott Weston |
#3 | AfterPatch.png | 126.84 KB | Scott Weston |
Comments
Comment #1
dawehnerIn general the breadcrumb uses the route titles not the menu titles. Does that mean we should update some of the menu links like "configuration" => "configuration managment".
well this is how it is. The default breadcrumb is now path based, which means we no longer care about local tasks like in D7.
Under the current code this is how it is intended to work but I can see why we have to change this behavior or rather let contrib solve it.
Comment #2
jhodgdonI do not think "let contrib solve it" is a good solution. This is broken in Core. Either Core should not put out breadcrumbs (because it cannot figure out how to do it), or Core should put out correct breadcrumbs.
Comment #3
Scott Weston CreditAttribution: Scott Weston commentedThe attached patch and file should address the confusion on the breadcrumbs on this page. After speaking with @crell, @yoroy, and @bojhan, it's agreed that breadcrumbs are working as intended. The patch updates the title of the route admin/config/development/configuration/synchronize to "Configuration management", which will help the breadcrumbs on admin/config/development/configuration/full/import and admin/config/development/configuration/single/import.
Comment #4
rklawson CreditAttribution: rklawson commentedComment #5
Scott Weston CreditAttribution: Scott Weston commentedComment #6
rklawson CreditAttribution: rklawson commentedWorked with @scottweston to triage and DrupalCon LA Sprint. See #3 and issue summary.
Comment #7
jmarkel CreditAttribution: jmarkel as a volunteer commentedFixing this individual case - or, I should say, kinda-sorta fixing it (since the local task navigation is still left as an exercise for the student) is necessary but not sufficient - it was presented as an example of the issue, not as the issue itself.
Breadcrumbs are (or at least were originally intended to be) UX enhancers. If they don't adequately describe a user's path to a page, they serve no useful purpose since they don't really show how to reproduce the way there but only a way to get back - and the back-arrow works at least as well for that.
Comment #8
ohthehugemanatee CreditAttribution: ohthehugemanatee at Forum One commentedBumping this back to "needs review", because according to the issue description and comment #3 - with consultation from @crell, @yoroy, and @bojhan - the issue *is* about this isolated case. Core is working as intended.
@jmarkel If you feel that there's a larger issue with path-based breadcrumbs as the default, that's a much bigger discussion for a separate issue.
Comment #9
ohthehugemanatee CreditAttribution: ohthehugemanatee at Forum One commentedTested working for me. Applied the patch and visited admin/config/development/configuration/ to see the "Configuration Management" breadcrumb. Then visited admin/config/development/configuration/single/export to make sure it was still there.
Comment #10
jmarkel CreditAttribution: jmarkel as a volunteer commentedI strongly disagree with RTBCing this - the issue title says "Very confusing breadcrumbs on deep admin pageS" not "Very confusing breadcrumbs on the Configuration Management page."
Based not only on the summary but from comment #2 the intent of this issue was fairly clearly meant to describe a more general issue with breadcrumbs as implemented in D8.
Comment #11
yoroy CreditAttribution: yoroy at Wunder commentedIt's true that there are more pages and sections in admin where the same type of confusion happens.
Is the way this patch fixes this particular instance the right way? If so, we can:
1. Make inventory of all places where things go wrong and fix it all in one patch. Will be very hard to do
2. Repurpose this issue, make it a meta issue for "Fix all breadcrumbs" and create a new issue for config management section and upload this patch there
3. Edit: Keep this issue as is, and create a new meta for collecting all other instances.
If this way of solving things is not the right way, we need to first define what the correct way to go about it it.
Comment #12
jmarkel CreditAttribution: jmarkel as a volunteer commentedAnother possibility (which I admit not to have investigated yet) is to find a generalized way to make breadcrumbs more reflective of menu titles rather than being route/path based. I understand that this is currently working as intended - but that's not to say that it works in a user-friendly way.
Comment #13
xjm(Saving proposed issue credit for discussion and triage participants at LA.)
Comment #14
jhodgdonSetting to Needs work because this doesn't really solve the whole problem.
Comment #16
jhedstromI'd advocate for fixing small pieces as they are discovered, rather than trying to fix the whole problem this close to a release.
Comment #17
dawehnerWell, then the small bit should be moved to its own issue.
Comment #18
jhedstromI added #2569799: [meta] Fix confusing breadcrumbs on deep admin pages to track further fixes.
Comment #19
dawehnerWell, I think this issue was about the fact that our breadcrumb system is not optimized for our admin usages.
Comment #20
Truptti CreditAttribution: Truptti at Axelerant commentedApplied the patch drupal-config-breadcrumb-confusion-2310175-3-D8.patch and visited 'admin/config/development/configuration/single/import' but the breadcrumb is still the same 'Home> Administration Configuration >Development >Synchronize'
Attached snapshot for reference.
Comment #21
Truptti CreditAttribution: Truptti at Axelerant commentedComment #22
jhodgdonThe problem is that pretty much ***every*** core admin breadcrumb is confusing, if there is any depth to the navigation, and I think that they all have "Administration" instead of "Manage" as the top-level breadcrumb, as reported here, and it is not even fixed in this patch.
Comment #24
dawehnerOne possible bugfix could be to implement a menu tree based breadcrumb for
/admin
paths, but use the routing based ones for all the other URLs.Comment #25
jhodgdonWe have to first decide whether this issue is about just these particular pages or all admin pages. If it's about all admin pages, then we should close the parent issue as a duplicate. If it's about just this page (or just the pages in the Configuration Management section), then the current patch will probably work.
But this is going to be a problem on any set of pages that have local tasks, if the main local task's title is not the same as the group's title.
Comment #31
apadernoComment #39
larowlanTriaging for Bugsmash
Comment #40
pooja saraah CreditAttribution: pooja saraah at Srijan | A Material+ Company for Drupal India Association commentedReroll patch against Drupal 10.1.x
Attached patch against Drupal 10.1.x
Comment #41
pooja saraah CreditAttribution: pooja saraah at Srijan | A Material+ Company for Drupal India Association commentedComment #42
smustgrave CreditAttribution: smustgrave at Mobomo commentedWas tagged for issue summary in #39 which still needs to happen.
Also has 0 test coverage