Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This module adds the Zoho SalesIQ chat widget to your site.
With Zoho SalesIQ you can instantly connect to your customers and deliver instant support.
Documentation
Documentation is provided on the project page and also in the module's README.txt
Git Repository
To clone project:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/zoholivedesk/2237609.git zoho_salesiq
cd zoho_salesiq
Comment | File | Size | Author |
---|---|---|---|
drupal.png | 97.23 KB | Vigneshwaran |
Comments
Comment #1
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxzoholivedesk2237609git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
Vigneshwaran CreditAttribution: Vigneshwaran commentedFixed all issues mentioned in PAReview
Comment #3
GoRoost CreditAttribution: GoRoost commentedPAReview checks out. All clear.
Project page looks good. All other items on standard checklist seem good.
Comment #4
joshi.rohit100Module is looking fine to me except fwe things :-
1. I think, there is no need to use hook_install() in .install file as we can use variable_get('variable_name', 'default_value'). So please remove this.
2. In system settings form, you have mark the "widget code field" required, so there is no need to write the validation handler for this. So please remove this.
thanks.
Comment #5
joshi.rohit100Comment #6
Vigneshwaran CreditAttribution: Vigneshwaran commentedChanges done as mentioned in comment #4
Comment #7
a_thakur CreditAttribution: a_thakur commentedLine # 8 in livedesk.admin.inc, the function livedesk_admin_settings_form() is not a hook, so
is incorrect, rather change it something like below
Also please review other projects to get review bonus, as applications with review bonus would get more priority than normal applications.
Comment #8
Vigneshwaran CreditAttribution: Vigneshwaran commentedFixed the comment as mentioned in #7
Comment #9
EthanTHi @zoholivedesk, I've reviewed your module.
1) I would recommend renaming your project "Livedesk" as opposed to "Zoho Livedesk," as this is the naming convention your code follows.
Save for the above nitpick, your code passes all sniffs I have installed via phpcs --Drupal, as well as an eyeball inspection.
Functionality is perfect - the module installed, I created an acct, and it worked flawlessly.
Comment #10
rayzzz.com CreditAttribution: rayzzz.com commentedInstallation is quite easy, works fine. However there is no license notificatin in your php files headers and README.txt is not composed in the standard template of readme for modules.
Everything else seems to be perfect.
Comment #11
klausiPHP files should not have any licensing headers, drupal.org packaging automatically adds a LICENSE.txt file. The README style is surely not an application blocker, any other problems you found?
Comment #12
rayzzz.com CreditAttribution: rayzzz.com commentedWell, in that case just readme file should be updated. No other problems found.
Comment #13
Vigneshwaran CreditAttribution: Vigneshwaran commentedComment #14
Vigneshwaran CreditAttribution: Vigneshwaran commented@rayzzz.com Updated Readme as per the Drupal template for Readme.
We have now re-named our platform as 'Zoho SalesIQ'. Updated references in the code.
Code passes pareview.sh tests.
Comment #15
Vigneshwaran CreditAttribution: Vigneshwaran commentedPlease approve this if there are no more issues.
Comment #16
Vigneshwaran CreditAttribution: Vigneshwaran commentedIs there anything pending for this plugin to be published?
Comment #17
k_zoltan CreditAttribution: k_zoltan commentedAll user accounts are for individuals. Accounts created for more than one user or those using anonymous mail services will be blocked when discovered (see Get a Drupal.org account).
Please note that organization accounts cannot be approved for git commit access. See https://drupal.org/node/1966218 and https://drupal.org/node/1863498 for details on what is/isn't allowed. Please update your user profile so that we don't have to assume that this is a group account.
Comment #18
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #19
Vigneshwaran CreditAttribution: Vigneshwaran commented@k_zoltan I have updated the profile and using my real username and email address. Please review and approve this plugin. Thanks.
Comment #20
k_zoltan CreditAttribution: k_zoltan commentedIf this was the only issue than you need only to wait for the administrators to review your application.
You can make this process faster if you apply for Review bonus.
More about this here: https://www.drupal.org/node/1975228
Comment #21
babusaheb.vikas CreditAttribution: babusaheb.vikas commentedHi vigneshwaran,
you should add a module configure link in *.info file, so that a user can quickly reach at module configuration page from modules list.
configure = admin/config/system/zohosalesiq
Otherwise module work for me.
Comment #22
GokulakannanG CreditAttribution: GokulakannanG commentedHello Babusaheb,
The module configure link is already in zohosalesiq.info
Comment #23
kattekrab CreditAttribution: kattekrab as a volunteer commentedBumping to critical
Comment #24
mrmysterious2502 CreditAttribution: mrmysterious2502 commentedManual Review
The account is for an individual working for the Zoho company, but they have explicitly made clear their individual identity.
There is an identical module that, admittedly is harder to set up. It works though. here is the link --> LINK. It even has the same short name... :(
This review uses the Project Application Review Template.
Comment #25
apadernoI will update your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks go the dedicated reviewer(s) as well.