Comments

askibinski’s picture

Just posting this for reference: there is a big issue about getting pathauto in core since D7:
https://drupal.org/node/229568 (postponed to D9)

anavarre’s picture

FYI there's a sanbox on Github to try and port the basic Pathauto features to D8. I expect that once enough progress has been made there will be a 8.x branch here.

eelkeblok’s picture

I took a look at the Github sandbox, but am I wrong when I say that it is currently just a copy of the drupal.org repository? The 8.x-1.x branch seems to be at the same commit currently as the 7.x-1.x branch on drupal.org.

anavarre’s picture

@eelkeblok: that's right. Lee (larowlan) had planned to start working on this at Drupalsouth but it seems that he worked on the Token port to D8 first

penyaskito’s picture

As token was a dependency, that have to happen first. @larowlan and @grom358 worked on that in Drupal South, and I've been contributing there too. See https://github.com/larowlan/token. As it is starting to work somehow (still needs lots of love), I' m starting with pathauto at https://github.com/larowlan/pathauto.

We will be referencing this issue in commits, with clear messages, with the hope of being able of merging instead of having a big migration patch posted here.

Berdir’s picture

Someone from our team has been working on porting pathauto in a fork for @larowlan's github repository for a while, you can see the current state here: https://github.com/md-systems/pathauto.

While many tests are working, the settings forms are currently broken and saving of the settings isn't implemented yet. We also did a minimal port to get things working only so far, and are only starting to follow D8 patterns with more object oriented code.

timodwhit’s picture

@berdir, thanks for the updates. Is it possible to get the fork up to d.o, even if sandboxed, so that eyes and issues can be posted. And hopefully help contributing/porting/etc could happen?

Thanks for the help!

miro_dietiker’s picture

@timodwhit We decided to work with github in early phases of ports as it allows better fork / pull request / merge / rebase workflows. Also you can even comment on files / lines.

Usually we switch over to d.o once it is pretty stable and merged into the main project and use right that issue queue for further fixes.

Our "minimum working" goal should be reached within a week (and will switch to other contrib ports we depend on) and that's when a handover starts to make sense.
In case a merge request is not successful for whatever reason, we will consider a sandbox.

timodwhit’s picture

Awesome. That sounds like a good plan. Thanks for the explanation.

miro_dietiker’s picture

Pathauto 8.x is currently functional in our repository.
You will find a TODO.txt file in the repo containing the remaining issues.
Only a few things to cleanup and we feel this is ready to switch to the main repo and continue with this issue queue.

blueminds’s picture

Here a short overview of the current status:

- the basic functionality is there and mainly functional

- most of the tests in PathautoFunctionalTest.php is passing (Pathauto basic tests)

These should be resolved by next Monday:

- transliteration_get() => Drupal::service('transliteration')->transliterate(), remove module exists
Add a test

- PathautoUnitTest tests are totally broken as well.

- Localization seems not to work. Tests are runnable but not passing.

- Make sure customized aliases are not overwritten

- Bulk actions for node and user

blueminds’s picture

For further todos we identified please see TODO.txt

miro_dietiker’s picture

blueminds will update about the status later today.

Davereid is not yet ready to review and release this work in the project scope. Still we want to have the community participate.

For the time being, we will maintain our Drupal 8 port on github. The project is well progressed so that other community members can start playing, review and contribute to it. Please start forking and providing pull requests on github:
https://github.com/md-systems/pathauto

And don't forget you need the token dependency: https://github.com/larowlan/token

blueminds’s picture

Status: Active » Needs review

Here is current status.

The latest code can be found at https://github.com/md-systems/pathauto

The PathautoFunctionalTest and PathautoUnitTest are now looking much better, despite having some fails, we can now use it as a reference of functional parts of pathauto.

The TODO document outlines what needs to be done next and basically all the items in there should become a followups of this issue. That is unfortunately not possible currently as we do not have the 8.x branch, but let's hope it will happen soon.

Until the pathauto maintainer manages to create the appropriate branch and possibly review/push the code, you are encouraged to contribute to the above github repo.

Please stay tuned, contribute, and enjoy! :)

Berdir’s picture

Another update, having been working on pathauto a bit today.

All tests are now passing, I also set up travis so we can run the tests from our github repository, can be removed again as soon as we move it back.

https://travis-ci.org/md-systems/pathauto/jobs/28679171

A lot of cleanup, moving more code into the pathauto manager service, The functional tests was so huge/slow that travis died on it, split it up into 4 tests.

There are still some known issues and tasks we'd like to do, see TODO.txt, but it got a lot shorter since the above post ;)

drasgardian’s picture

Thanks for working on pathauto for Drupal 8.

It was working ok for me in with core alpha 12, but with alpha 13 it started throwing these errors:

Uncaught PHP Exception Drupal\\Core\\Database\\DatabaseExceptionWrapper: "SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupal.user__path' doesn't exist: SELECT t.*\nFROM \n{user__path} t\nWHERE (entity_id IN (:db_condition_placeholder_0)) AND (deleted = :db_condition_placeholder_1) AND (langcode IN (:db_condition_placeholder_2, :db_condition_placeholder_3, :db_condition_placeholder_4)) \nORDER BY delta ASC; Array\n(\n [:db_condition_placeholder_0] => 3\n [:db_condition_placeholder_1] => 0\n [:db_condition_placeholder_2] => en\n [:db_condition_placeholder_3] => und\n [:db_condition_placeholder_4] => zxx\n)\n" at /var/www/drupal-8.x/core/lib/Drupal/Core/Database/Connection.php line 569

Berdir’s picture

Pushed a change that should fix that error, tests are passing again.

ivanjaros’s picture

I've noticed paths in route definitions doesn't start with forward slash as they should. Though the module works just fine.

iantresman’s picture

All sounds promising. Every single one of my 50 Drupal sites uses pathauto, and I wouldn't consider upgrading to Drupal 8 without it. I'm astonished it isn't in core, especially as it is in the top 5 modules.

Berdir’s picture

There are always going to be 5 top modules that are not in core. It's not like people didn't try, but before this can be in core, we first need a token UI and field tokens, otherwise it's not very useful, and that didn't happen, so...

I'm constantly chasing HEAD to keep it working and @kimb0 is working refactoring it piece by piece to a Drupal 8 architecture, we moved all the functions in pathauto.inc to services, the big step will be to make the pattern types plugins.

Dave Reid’s picture

@Berdir: Is there some way I can be in on these conversations with @kimb0 about the architecture in D8? I've had ideas on how to convert it and would like to have at least some ownership over how it's done.

Berdir’s picture

Sure, everything is happening as pull requests on github. so if you follow there, you should see everything that's happening. It's not very noisy, a pull request every few days or so.

We plan to discuss pattern type plugins beginning next week, I'll open an issue to start discussing it when I find the time.

chriscohen’s picture

Tried installing this today, but the install fails on the latest D8 dev build:

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "pathauto.alias_uniquifier" has a dependency on a non-existent service "router.no_access_checks". in Symfony\Component\DependencyInjection\Compiler\CheckExceptionOnInvalidReferenceBehaviorPass->processReferences() (line 59 of /webroot/d8.drupal.dev/core/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php).

Appreciate you might already know about this though!

Berdir’s picture

I don't know what version you are using, but that is definitely *not* the latest dev build. Sounds like you're still on 8.x or so, latest D8 dev is 8.0.x. That does have that service, and while some tests are failing, they're failing on things that come much later.

karolus’s picture

Just downloaded from GitHub, installed into D8 Beta 2, OK. When running drush pm-update, Drush is replying that the module couldn't be found. I will see if I can find out any more.

OK--update:
Modified the info file to pathauto.info.yml, formatted the info. Some minor changes in syntax for yml, then installed. This is what happened:

Fatal error: Call to undefined function variable_set() in /drupal-8-beta/modules/pathauto/pathauto.install on line 15
Drush command terminated abnormally due to an unrecoverable error.   [error]
Error: Call to undefined function variable_set() in
/drupal-8-beta/modules/pathauto/pathauto.install,
line 15

I'll see if I can root through this...

miro_dietiker’s picture

There is no "variable_set" in our current code.
I guess you still have a separate pathauto present in your folders that is a D7 version...
I recommend to use support channels such as IRC to set this up properly.

ebeyrent’s picture

Any plans to make a d8 dev release here?

greggles’s picture

Issue summary: View changes
Dave Reid’s picture

Status: Needs review » Needs work

I officially opened the D8 branch this weekend so we can start marking anything fixed in D7 as to be ported up. If someone wants to submit a patch, or give instructions/commands on how to merge the Github work back to Drupal.org, that would be great. It would be nice if we could see some kind of diff between the current 7.x-1.x and 8.x-1.x code on Github, and also get a current summary from those working on the Github ports with the major changes made.

Dave Reid’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Dave Reid’s picture

miro_dietiker’s picture

Will you maintain pathauto on d.o against Drupal core HEAD or Beta?
So you're merging squashed?

I can ask the team to provide a summary of all the work done. I doubt a diff will be helpful.

After merging we usually spend some hours and generate issues in 8.x to make sure all remaining known tasks are in the tracker. Also we usually do some UI testing and create further issues to discuss how to proceed.

Jaesin’s picture

Here is a patch from the current state of the github repo.

All I did here is create the patch against what's on the 8.x branch.

Jaesin’s picture

FileSize
284.26 KB

Better patch, applies cleanly against commit: ca46f1f

sitordance’s picture

I'd like to volunteer as a tester.

pookmish’s picture

Patterns only work if a user manually removes the url alias field. Is the 'Generate automatic URL alias' checkbox going to return as in D7?

Edit: The checkbox appeared after I created a new content type. the initial types do not have the checkbox upon enabling the module. But even with the checkbox selected, if the pattern contains menu link references, it does not grab the parents. For example if the pattern is [node:menu-link:parents:join-path]/[node:title], and a node is created with a link in the menu under a page, the resulting alias is [node:title]. Then editing the node and selecting to create the auto-alias, it uses the pattern as desired.

hswong3i’s picture

hswong3i’s picture

FileSize
288.89 KB

https://github.com/md-systems/pathauto/pull/29#issuecomment-77157485

Berdir commented 15 hours ago

That doesn't work, you need only access that service if content_translation is enabled, so it needs to be inside those checks. I suggest you create an inner if () and put the service there, or inline it in the if but that gets very long.

https://github.com/md-systems/pathauto/pull/29#issuecomment-77303588

hswong3i commented 2 minutes ago

Patch updated and now call the service inline (seems just a bit longer, but keep the logic as original)

RedactedProfile’s picture

This is the very last thing I need to have in some capacity to release a D8 site I've been tinkering with. +1

I'm honestly surprised Drupal didn't opt for this to be core..

kim.pepper’s picture

I'm honestly surprised Drupal didn't opt for this to be core..

Like all of Drupal development, things only get done if people are motivated and willing to work on them.

RedactedProfile’s picture

Like all of Drupal development, things only get done if people are motivated and willing to work on them.

Sure, I understand that. Just seems a bit silly to me to have a full featured cms released in 2015 that doesn't have some sort of automated slugging of any kind and requires manual input. I mean, especially when the brunt of the work is sitting right here in this very repository you know?

ivanjaros’s picture

Yeah, I agree. Especially if you look at https://www.drupal.org/project/project_module
Disregard the Views and CTools(which are needed for Views) and Token(which is needed for Pathauto) and Pathauto is the #2 most installed module, ever. And it is not even that complicated module. I was personally expecting it to make it into the core too, but as kim said, it's all about the people. Things don't make themselves, people make things :)
(although I still see this a misstep in D8 context).

miro_dietiker’s picture

Please STOP spamming all the (52) followers that are interested in real updates about the Drupal 8 port.
And yes, no answer to my comment needed. I also feel bad for spamming the subscribers with my statement...

kim.pepper’s picture

I will be at the DrupalCon LA extended sprint, and plan on spending some time on this. Anyone else around on the weekend before?

DuaelFr’s picture

Here is a small update.
Everything seems fine with 8.0.0-beta12 (not tested against HEAD) but an issue remains with AliasUniquifier::isRoute() that returns TRUE for an existing alias (the Matcher converts the alias into the entity canonical route). That leads to a changing alias each time the entity is saved.

penyaskito’s picture

@DuaelFr: Are you aware of https://github.com/md-systems/pathauto? Maybe it is already fixed there, or should be in sync with that.

DuaelFr’s picture

Ho... I jumped directly to the last patch and I didn't saw your repo T_T
I'll check if there is something to keep in my patch.
Thanks a lot for the information.

DuaelFr’s picture

Issue summary: View changes
Issue tags: -Needs issue summary update
sitordance’s picture

I'd like to thank everyone for their contribution and would like to help however I can...this is a great module.

I'm beginning to build production sites with Drupal 8 (I know) and played with Pathauto a little with Beta 11 with good success.

However, I recently move to Beta 12 and have not been able to successfully use this module.

After a clean install of Beta 12, I install Token (6.30.15 dev release) and Pathauto from https://github.com/md-systems/pathauto (zip file) and then try to create content. Nothing else is installed other than the default mods installed by the Standard Drupal installation.

After submitting any content, the error below is displayed.

Please let me know if you need any additional info.

Thanks

---
Drupal\Core\Entity\EntityStorageException: Source path node/2 has to start with a slash. in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 930 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).

Drupal\pathauto\AliasStorageHelper->save(Array, NULL, 'insert')
Drupal\pathauto\PathautoManager->createAlias('node', 'insert', 'node/2', Array, 'article', 'en')
Drupal\pathauto\PathautoManager->updateAlias(Object, 'insert')
pathauto_entity_insert(Object)
call_user_func_array('pathauto_entity_insert', Array)
Drupal\Core\Extension\ModuleHandler->invokeAll('entity_insert', Array)
Drupal\Core\Entity\EntityStorageBase->invokeHook('insert', Object)
Drupal\Core\Entity\ContentEntityStorageBase->invokeHook('insert', Object)
Drupal\Core\Entity\EntityStorageBase->save(Object)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object)
Drupal\Core\Entity\Entity->save()
Drupal\node\NodeForm->save(Array, Object)
call_user_func_array(Array, Array)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object)
Drupal\Core\Form\FormBuilder->processForm('node_article_form', Array, Object)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object)
Drupal\Core\Entity\EntityFormBuilder->getForm(Object)
Drupal\node\Controller\NodeController->add(Object)
call_user_func_array(Array, Array)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1)
Drupal\Core\DependencyInjection\Container\prod\Symfony_Component_HttpKernel_HttpKernel_Proxy->handle(Object, 1, 1)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1)
Drupal\Core\DependencyInjection\Container\prod\Drupal_Core_StackMiddleware_Session_Proxy->handle(Object, 1, 1)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1)
Drupal\Core\DependencyInjection\Container\prod\Drupal_Core_StackMiddleware_KernelPreHandle_Proxy->handle(Object, 1, 1)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1)
Stack\StackedHttpKernel->handle(Object, 1, 1)
Drupal\Core\DrupalKernel->handle(Object)

DuaelFr’s picture

There is an open pull request on github for that issue introduced in beta12
https://github.com/md-systems/pathauto/pull/45

hswong3i’s picture

Latest patch created by:

git clone --branch 8.x-1.x http://git.drupal.org/project/pathauto.git
cd pathauto
git remote add md-systems git@github.com:md-systems/pathauto.git
git fetch --all
git diff origin/8.x-1.x md-systems/8.x-1.x > ../pathauto-d8_port-2168193-51.patch
rakesh.gectcr’s picture

Can any one please replace the current 8.x-1.x-dev , With either of this Git PRS ?

sk33lz’s picture

I've rolled a new patch against the latest commit on Github as of 3 days ago to keep us up to date here.

grndlvl’s picture

FileSize
301.51 KB

Patch seemed to be missing a few things. Re-roll.

hswong3i’s picture

FileSize
303.65 KB

Latest patch created by:

git clone --branch 8.x-1.x http://git.drupal.org/project/pathauto.git
cd pathauto
git remote add md-systems git@github.com:md-systems/pathauto.git
git fetch --all
git diff origin/8.x-1.x md-systems/8.x-1.x > ../pathauto-d8_port-2168193-55.patch
grndlvl’s picture

FileSize
300.43 KB

Re-rolling

ed@vtinq.org’s picture

Title: Pathauto for Drupal 8 » D8: Installing Dev of Pathauto: No .yml files
Category: Feature request » Bug report
Issue tags: +pathauto, +Drupal 8, +module, +install

When I try installing Pathauto 8.x-1.x-dev.tar.gz Drupal module installer gives "does not contain any .info.yml files" error.

eelkeblok’s picture

Title: D8: Installing Dev of Pathauto: No .yml files » Pathauto for Drupal 8
Category: Bug report » Feature request
Issue tags: -pathauto, -Drupal 8, -module, -install

You (probably inadvertantly) changed the subject and metadata for the main "Port pathauto to D8" issue. Normally, you would need to post a new issue for your support request. However, I'm not sure what the support policy would be for the D8 port at this time. I would suggest that at this stage, if you can't support yourself, this is not for you yet. If you are able to supply patches, that's an entirely different matter, of course. However, as the last patches posted to this issue actually turns the D7 version into a D8 version, you probably shouldn't be downloading a dev archive file and expect it to work until one of these patches has been applied.

Edit: There actually is an existing issue about this: #2580881: pathauto-8.x-1.x-dev.tar.gz does not contain any .info.yml files. .

sk33lz’s picture

Issue summary: View changes

I've closed #2580881 and #2512816 as a duplicates of this issue to centralize all efforts on this issue.

Apply the patch in #56 to the 8.x-1.x-dev release and you should have a mostly working version of pathauto available for Drupal 8. The patch resolves both of the above linked issues.

koppie’s picture

Status: Needs work » Reviewed & tested by the community

+1 for #56. In a cursory review, it works!

As an added bonus, it looks like the patch takes all the latest changes from github: https://github.com/md-systems/pathauto

If we could commit this patch in the d.org repository, people could download & install a working version of Pathauto for D8. Even if it's still a dev version.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 56: pathauto-d8_port-2168193-56.patch, failed testing.

The last submitted patch, 56: pathauto-d8_port-2168193-56.patch, failed testing.

Andrej Galuf’s picture

Confirming what @koppie said - Drupal 8 dev + patch #56 make Pathauto work on RC2.

Internet’s picture

D8 - Confirming #60 (https://github.com/md-systems/pathauto) worked, and also with token 8.x-1.x-dev.

eloiv’s picture

Mee too, path auto dev verion + #56 patch, it's works for me.

koppie’s picture

I'm glad that so many people (including myself) have confirmed that the module works, but it needs more work. Automated test of #56 patch failed. Ironically, I think it's the module's own auto test script, contained in pathauto/tests/src. The patch is old and I suspect the D8 built in auto testing framework has changed; it's giving a lot of errors.

To do: Fix the test errors.

agoradesign’s picture

By now, I haven't found any serious problem too. I will test it more extensively on a multilingual page this week. Afaik the only problem I've experienced, was the bulk operation on the admin/content page. I'm not 100% sure, but I think it didn't work at all, at least for translations. But I can tell you more about this in the upcoming days...

guntervs’s picture

#60 works (kind of)

Our default pattern for pages is /[node:menu-link:parents:join-path]/[node:title] so our path reflects the menu hierarchy. When creating a top level page, everything works as expected, but when creating a child page, the path only contains the node title. When editing the page, checking automatic url alias and saving again, the path follows the pattern. We'll try to spend resources looking into this issue.

Berdir’s picture

I would recommend that you directly use the Download ZIP button on https://github.com/md-systems/pathauto instead of worrying about patches. The 8.x-1.x branch on drupal.org is completely non-functional and has nothing in common with our work in our repository.

I'd also recommend to check and use the issues/pull requests on github for now. The menu link problem is already being discussed in https://github.com/md-systems/pathauto/issues/76, there are also issues about bugs with translations.

Be aware that we are working on a major refactoring in the https://github.com/md-systems/pathauto/tree/pattern-config-entities branch. It's an early version, we're not sure yet when it will be done but it is one of the last and biggest blocker for getting an official 8.x-1.x release on drupal.org. If you want to work on improving the module, consider doing that work on top of that branch.

imrancluster’s picture

Sorry for interrupt. I am new and learning how to contribute Drupal. :(

I Fork https://github.com/larowlan/pathauto repo and installed in Drupal RC3. When I tried to create an article I got an error for $entity->getSystemPath(). Drupal core entity library provide url() instead getSystemPath(). When I replaced then pathauto module is working fine. I forgot to create an patch. I just requested a pull request https://github.com/imrancluster/pathauto

agoradesign’s picture

You're using the wrong repo -> this one is newer: https://github.com/md-systems/pathauto

imrancluster’s picture

Thank you @agoradesign

hswong3i’s picture

FileSize
300.54 KB

Latest patch created by:

git clone --branch 8.x-1.x http://git.drupal.org/project/pathauto.git
cd pathauto
git remote add md-systems git@github.com:md-systems/pathauto.git
git fetch --all
git diff origin/8.x-1.x md-systems/8.x-1.x > ../pathauto-d8_port-2168193-73.patch
koppie’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 73: pathauto-d8_port-2168193-73.patch, failed testing.

The last submitted patch, 73: pathauto-d8_port-2168193-73.patch, failed testing.

jomarocas’s picture

please release this dev version in a download of drupal

awasson’s picture

Thanks for all of the work that's been done on Pathauto and of course Token. I don't believe there is a single site I've built that doesn't contain them and I've been watching this issue/discussion pretty much since it was created.

The latest Dev patched with the patch on #73 seems to work well for my purposes of generating URL alias patterns for content, taxonomy and User accounts. I've been putting it through its paces on a migrated site with lots of content and I haven't detected any errors in the logs (PHP 5.5.30 / MySQL 5.5.40-36.1-log).

One area that I had to do some troubleshooting was Alias Patterns for User Accounts. It seems that by default the checkbox is not set to TRUE in user accounts to use alias patterns. For the site I've been testing with, of 5 or 6 accounts it's not a huge deal to go in and change the checkbox to TRUE but for sites with hundreds or thousands of User accounts this might pose a problem. Is there any reason it wouldn't be set to TRUE by default?

Thanks,
Andrew

webchick’s picture

Cross-post from #2573683: [pathauto] Pathauto:

My understanding (which is like third-hand information, so ymmv) is that the blocker to getting the changes in the MD Systems Github repo rolled into the official D.o repo is completing the refactoring that Dave Reid asked for as part of the D8 port. This hit-list is located at https://hackpad.com/Pathauto-8.x-Plan-ob3OeHCs5t3.

EclipseGc has been doing work on the "pathauto pattern" architecture change at https://github.com/md-systems/pathauto/pull/91 (now in the pattern-config-entities branch of that repo). Here's a list of the outstanding todo items to get that merged into the master branch over there: https://docs.google.com/document/d/1d2IjCiOHjguJM9_DDUDpLUBScrI6AI5Vr_rT...

obaydmir’s picture

Title: Pathauto for Drupal 8 » Pathauto module is not showing up in the list of modules
Category: Feature request » Bug report

Pathauto module is not showing up in the list of modules.

I put the module in directory project/modules/, but I can't get it in the list of modules, so I can enable it.

Can somebody help me, please?

andypost’s picture

Title: Pathauto module is not showing up in the list of modules » Pathauto for Drupal 8
Category: Bug report » Feature request
Michelle’s picture

obaydmir - I see you are new here so maybe aren't used to how issue queues work. When you have a new problem, you need to create a new ticket for it rather than changing an existing one. In this case, though, the module is still in a very early state and not ready for general use so you are better off holding off on using it until it is farther along if you aren't able to work things like this out for yourself.

glynster’s picture

Applied patch #73 and now have a working version of pathauto!

awasson’s picture

I've got a couple of D8 sites with copies of Pathauto (+ patch #73) with the latest token and it works however I can't get it to recognize a url pattern that calls on a taxonomy term like the following:

/[node:field_taxonomy-vocabulary-name]/[node:title]

I'm not sure whether this is a problem with Token or with Pathauto and I recall it went through a fair bit of tweaking before token/pathauto played well together with D7 so I'm just bring this up for general information in case someone else is experiencing this.

ivanjaros’s picture

I highly doubt that machine name of a field would have dashes instead of underscores.

agoradesign’s picture

I think, awasson just wanted to give a generic example and didn't thought about this. He could also have written "field_foo" or "field_tags",...

awasson’s picture

@agoradesign: Thank you. Yes, that is a generic example, just to illustrate a taxonomy field.

Cheers,
Andrew

Dave Reid’s picture

Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs work » Fixed

I've added Berdir as a provisional maintainer, deleted the existing 8.x-1.x branch, and pushed the Github 8.x-1.x branch back here. Berdir will create an alpha release today or tomorrow.

I will be doing a full review of the port on Friday to look for any major issues that would need to be addressed before a beta release can be made.

I'm going to go ahead and mark this as fixed as the 8.x-1.x branch should be usable now, and we should file issues for anything that remains.

Dave Reid’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
RKopacz’s picture

Quick question: Do we still need to use dev versions of token and ctools for the d.o. alpha version?

Thanks to all for the great work!

Berdir’s picture

No, the latest alpha versions are enough.

RKopacz’s picture

Thanks, Berdir!

Berdir’s picture

Status: Active » Fixed

No idea how this was set back to active.

Michelle’s picture

Version: 8.x-1.0-alpha1 » 8.x-1.x-dev
Category: Bug report » Feature request

@Berdir: The statuses were changed due to an unpublished comment. I don't know if the comment was unpublished because it doesn't belong here or if it was caught by Mollom because the poster was unconfirmed. I fixed the other two changes as well.

@robmccreary: I'm just going to leave that unpublished. Please make a new issue.

drupalfever’s picture

I would like to test this beta module but I have not been able to successfully install it on my test website. I tried first to install the mentioned github module as it was. I then applying the patch mentioned on the comment #76. Every time I tried to apply the patch I got dozens of error messages like the following:

The next patch would create the file .travis-before-script.sh,
which already exists!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored

I tried to press [Enter] to each error prompt and also tried answering yes to each prompt but, either way, the resulting module didn't install correctly.

I tried applying the patch to the following versions of pathauto:
https://github.com/md-systems/pathauto/archive/8.x-1.x.zip
https://ftp.drupal.org/files/projects/pathauto-8.x-1.0-alpha1.zip

I tried to apply the following patch to the above mentioned versions of pathauto:
https://www.drupal.org/node/2168193#comment-10579890

Here is what I did:

  1. I downloaded and decompressed the pathauto module
  2. I downloaded, decompressed, and copied the patch into the pathauto folder
  3. I ran the linux terminal command:
    patch -p1 -i  pathauto-d8_port-2168193-73.patch
    

Could anyone please explain to me what I am doing wrong? I am very much willing to help with the testing of this beta module and the patch.

awasson’s picture

@drupalfever: On post #88, you should see the message that the module is deemed ready for use. So it is available now on the Module page with no patching necessary: https://www.drupal.org/project/pathauto

All you need to do is go to the module page, get/install Pathauto 8.x-1.x-dev

Prerequisite requirements are Token and Chaos Tools. I have been successfully been using:

Chaos Tools: 8.x-3.0-alpha21+5-dev
Token: Token 8.x-1.0-alpha2

Good luck.

Andrew

drupalfever’s picture

Thanks for the help, awasson! Your help is awesome! :) (I couldn't help it!)

I will try it as soon as I get home!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.