Part of #2152519: [meta] Make sure Drupal 8 looks good and works right on browsers (both mobile+desktop).

We already fixed this at least once before, iirc.

White gap on the side.

Remaining tasks

  1. Write a patch for the field ui page to implement the hide column api introduced in #1276908: Administrative tables are too wide for smaller screens
  2. Test on desktop and mobile devices
Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Yes Instructions
CommentFileSizeAuthor
#50 sticky.mov362.7 KBjohn cook
#50 Screen Shot 2017-06-09 at 15.48.29.png146.19 KBjohn cook
#50 Screen Shot 2017-06-09 at 15.45.47.png143 KBjohn cook
#47 interdiff.txt429 bytesMunavijayalakshmi
#47 2152525-wide-content-break-mobile-layout-47.patch425 bytesMunavijayalakshmi
#46 2152525-wide-content-break-mobile-layout.patch424 bytesjmsv23
#42 wide_tables_in_mobile-2152525-42.patch303 bytespazhyn
#39 responsive-table-problem.png78.34 KBpazhyn
#39 overflow-x-auto-proposition.png72.97 KBpazhyn
#34 interdiff-2152525-31-34.txt488 bytesxavip
#34 several_admin_pages-2152525-34.patch4.35 KBxavip
#31 several_admin_pages-2152525-31.patch4.14 KBisholgueras
#26 2152525-admin-table-responsiveness-do-not-test.patch4.83 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 18.09.23.png41.72 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 18.09.05.png35.25 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 18.05.28.png40.04 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 18.02.30.png40.13 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 18.01.31.png55.17 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 17.59.05.png62.07 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 17.58.52.png42.67 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 17.56.28.png48.13 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 17.56.05.png50.69 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 17.54.48.png55.13 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 17.53.23.png59.51 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 17.47.00.png62.37 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 17.39.31.png49.81 KBAnonymous (not verified)
#22 Screen Shot 2014-08-23 at 17.36.45.png63.02 KBAnonymous (not verified)
#21 Screen Shot 2014-08-23 at 17.32.00.png51.7 KBAnonymous (not verified)
#20 Screen Shot 2014-08-23 at 16.04.46.png45.19 KBAnonymous (not verified)
#20 Screen Shot 2014-08-23 at 16.04.38.png48.13 KBAnonymous (not verified)
#20 Screen Shot 2014-08-23 at 13.52.40.png47.67 KBAnonymous (not verified)
#20 2152525-admin-table-responsiveness-20.patch2.58 KBAnonymous (not verified)
#18 iOS Simulator Screen shot 06 Jun 2014 21.49.30.png75.14 KBlauriii
#17 Screen Shot 2014-06-06 at 19.59.53.jpg62.11 KBlewisnyman
#17 Screen Shot 2014-06-06 at 19.58.07.jpg66.9 KBlewisnyman
#15 2152525-admin-table-responsiveness-15.patch1.66 KBec1ipsis
Screen Shot 2013-12-08 at 12.24.27 PM.png130.95 KBwebchick

Comments

webchick’s picture

Title: admin/content has enormous white gap on side on mobile » Several admin pages with tables on them have enormous white gap on side on mobile

Clarifying, since I found this on admin/structure/types, too:

White gap on side of page.

lewisnyman’s picture

This is tricky, we are kind of running out of “non-essential” columns to remove on mobile. At least for the content listing page.

lewisnyman’s picture

Issue tags: +frontend
lauriii’s picture

Could we re-format the table somehow? Let's say; put label and machine name on one row and rest for second row?

nod_’s picture

Not really. Early on we tried the idea of using a <ul><li> styled as tables to replace all responsive tables and we'd be able to make that work. We didn't go with that (don't remember the details, it's in a monter issue somewhere) so I don't know how we can solve this beside messy and slow javascript.

yoroy’s picture

What would the slow & messy javascript approach be? Other options:

- Hide more "essential" columns. I'll assume that there's been discussion about why 'machine name' is essential, but in the end, the label and its operations are the two bare minimum ones, no?
- Revisit the ul/li approach (sounds like no fun) Anybody got a link?

webchick’s picture

In this case, I think machine name is fine to drop. You can get it from the edit page if you need it, and most often it matches the human-readable name, just with underscores or whatever.

However, I seem to remember this happening on many pages, not just this one. It's been awhile since I tested though.

yoroy’s picture

Yeah, in the end, dropping more columns will not be the best approach. I asked Lewis to chime in.

nod_’s picture

lewisnyman’s picture

We don't have another method for resizing tables on smaller screen. For now I think we should just hide more columns. This is not ideal but until we have a better method then it's better than what we have now

I've created: #2280035: Add another responsive tables solution that doesn't hide content

yoroy’s picture

I had a quick chat with webchick about this and we agreed that as long as the first and last column are there we're good enough: the first colum identifies the thing, the last column exposes what you can do with it.

lewisnyman’s picture

Issue summary: View changes

Updated the remaining tasks

ec1ipsis’s picture

Assigned: Unassigned » ec1ipsis

Taking this one on.

ec1ipsis’s picture

Answer determined privately.

ec1ipsis’s picture

Attached patch adds the table responsiveness classes to views mentioned in issue.

ec1ipsis’s picture

Assigned: ec1ipsis » Unassigned
Status: Active » Needs review
lewisnyman’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new66.9 KB
new62.11 KB

Here're two pictures of both pages looking much better on mobile:

lauriii’s picture

Status: Reviewed & tested by the community » Needs work
StatusFileSize
new75.14 KB

Attaching one more picture where I have created some fields with very long labels.

+++ b/core/modules/node/config/install/views.view.content.yml
@@ -557,6 +557,7 @@ label: Content
+uuid: 639bf094-2430-450f-8800-bec5a4e514e1

I don't think this should be in the patch?

lauriii’s picture

Issue summary: View changes
Issue tags: +Novice
Anonymous’s picture

I cannot create a interdiff cause the old patch would have required reverting many commits.

also sorted out same kind of an issue in Comment Type comment type

There is still and issue related in display mode page. display mode display mode

Anonymous’s picture

StatusFileSize
new51.7 KB

After picture for the comment type page : comment after

Anonymous’s picture

thamas’s picture

Status: Needs review » Needs work
Issue tags: -Novice +Amsterdam2014

As I see in the comments, the last patch does not resolve all the problems. Soo it needs work. Also this seems to me confusing enough not to be a novice issue (so removed that tag too).

Anonymous’s picture

This needs quite few decisions on which of the table elements we hide on mobile or if none and find an alternate solution.

also the summary needs update on remaining tasks.

lewisnyman’s picture

I think for this issue we should just go with a gut feel and hide the ones we think are not required. It's easier to see in code rather than discuss it.

If there are any tables where it's impossible to hide enough columns to fix on the screen. We postpone them to a separate issue.

Anonymous’s picture

Pages that need a closer look :

Block layout(/admin/structure/block)
Permissions(/admin/people/permissions)
Extend (/admin/modules/uninstall) this could be made similar like the modules enable page.

Proposed hide columns :

Content (/admin/people/permissions) => hide status.

Hidden columns :

Contact (/admin/structure/contact) => hidden recipients and selected
Views (/admin/structure/views) => hidden Description, tag and path

Right, the config pages were a bit too hard for me to solve, heres what i've done so some one else can pick up

marthinal’s picture

Status: Needs work » Needs review
Anonymous’s picture

Status: Needs review » Needs work

This isnt in a needs review state..

DimitriV’s picture

Issue tags: +Barcelona2015

Evaluating during Friday sprint in Barcelona

DimitriV’s picture

Issue tags: +Needs reroll

The patch in #26 needs reroll against dev. The screens still have the same problem.

isholgueras’s picture

Status: Needs work » Needs review
StatusFileSize
new4.14 KB

I did a 'special' reroll.

The file FieldOverview.php doesn't exist anymore, and the scope of the change cannot apply. This change, changes some code in buildForm. Now is done in buildHeader, and in all buildHeader function in fiuld_ui module is changed.

So, for this reason, I didn't add this change in the patch:

-        $this->t('Field type'),
+        array(
+          'data' => $this->t('Field type'),
+          'class' => array(RESPONSIVE_PRIORITY_MEDIUM),
+        ),

Status: Needs review » Needs work

The last submitted patch, 31: several_admin_pages-2152525-31.patch, failed testing.

The last submitted patch, 31: several_admin_pages-2152525-31.patch, failed testing.

xavip’s picture

StatusFileSize
new4.35 KB
new488 bytes

Corrected patch #31 to pass tests.

xavip’s picture

Status: Needs work » Needs review
xavip’s picture

Status: Needs review » Needs work

The patch #34 passes, but there are some work to do:

Already corrected tables:

  • admin/structure/comment -> corrected
  • admin/structure/contact -> corrected
  • admin/structure/views -> corrected

Still needs correction tables:

  • admin/content
  • admin/structure/types/manage/[content_type]/fields
  • admin/config/content/formats
  • admin/config/search/pages
  • admin/config/search/path
  • admin/config/regional/date-time
  • admin/people
  • admin/people/permissions
  • admin/reports/status
  • admin/reports/views-plugins
xavip’s picture

Issue tags: -Needs reroll
andypost’s picture

pazhyn’s picture

StatusFileSize
new72.97 KB
new78.34 KB

As we can see tables are not responsive. As an alternative or additional solution for the problem could be adding overflow-x: auto for .page-content to make it scroll if it not fits the screen. In this case only content will have horizontal scroll, but not the whole page. And it looks better and more usable. See screenshots attached.
We can continue to hide low priority columns, but other tables could also appear with important columns and we will still have a problem. So my proposition could be additional to hiding columns for known tables.

How do you like the idea?

andypost’s picture

Version: 8.0.x-dev » 8.1.x-dev

I think we need to add responsive classes for all core's tables and use #39 suggestion for tables that wide

andypost’s picture

Issue tags: +SprintWeekend2016
pazhyn’s picture

Status: Needs work » Needs review
StatusFileSize
new303 bytes

Review intermediate fix and continue hiding columns for default tables.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jmsv23’s picture

Issue tags: +MidCamp2017
StatusFileSize
new424 bytes

this is a proposed solution to avoid break the mobile layout without add new js, just allow the browser to add a horizontal scroll if the content it's to wide.

Munavijayalakshmi’s picture

StatusFileSize
new425 bytes
new429 bytes
+++ b/core/themes/seven/css/layout/layout.css
@@ -4,3 +4,10 @@
+ * Avoid break mobile layout adding horizontal scroll for wider content (tables)

Comments should (noramlly) begin with a capital letter and end with a full stop / period .

Fixed and attached new patch.

andrewhd’s picture

Issue tags: +Baltimore2017, +Needs issue summary update, +Triaged for D8 major current state

Currently in 8.4-dev the white space is not immediately visible upon page load in mobile, but still seen when scrolling to the right of long tables like admin/content. It's not clear from discussion whether this accomplishes the parent issue's goal of "look[ing] good in all browsers".

The patch in #47 applies but does not seem to change behavior from the base 8.4-dev install.

cilefen’s picture

I am updating credit for the triage work. Going forward, you should know that we like to see documented triage steps (even if brief). It is the only way to know if the triage has actually been completed. Here are some made-up examples of documented triage steps:

  • I tested the steps to reproduce and they did (or did not) work (so I am tagging it "Needs issue summary update").
  • I searched for duplicate issues but could not find any.
  • I checked the issue summary and it is accurate and up-to-date.
  • Etc...

Thank you!

john cook’s picture

Status: Needs review » Needs work
StatusFileSize
new143 KB
new146.19 KB
new362.7 KB

I've tested the patch in a minimised chrome window.

The patch fixes the problem by allowing to table to scroll horizontally.

Before:

After:

Unfortunately, the sticky headings don't scroll with the rest of the table. See video sticky.mov

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

larowlan’s picture

Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +Needs manual testing, +Bug Smash Initiative

Is this still an issue?

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

xjm’s picture

Issue tags: -Triaged for D8 major current state

 

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

Status: Postponed (maintainer needs more info) » Closed (outdated)

I used simplytestme to test this with Drupal 10.0.3. I enabled language and translations and installed Italian. I then browsed through the configuration pages including admin/structure/types as in #1 and the translation pages. I was not able to produce the problem of a 'white gap' of any size.

Therefore I closing this as outdated.