Background #

This issue provides a guide on how to analyze and update (in other words, triage) major priority issues in order to make Drupal 8 more stable and plan the next phases of Drupal core development.

Definition of major priority issues: https://www.drupal.org/core/issue-priority#major-bug

Past major triage sprints:

Upcoming major triage sprint:

Goals #

At the end of major triage we should have:

  • A lot of issues that are marked duplicate/cannot reproduce problem (See Current State steps #3 & #4).
  • A lot of issues tagged as Triaged for D8 major current state.
  • Some issues that are bumped to critical.
  • Some that are postponed to 9.x.

Understand the current state of the issue #

Note that these instructions are specific to bugs. Tasks and feature requests should be handled differently.

We recommend that you keep a separate file of your notes, and the issue metadata (tags, status, etc) you are planning to change. Make an initial comment saying that you and the person you will be working with are at the Florida Drupal Camp sprint looking at this issue. Try to make the rest of the metadata changes to the issue in one issue update (if possible) rather than making a number of smaller updates (to cut down on the number of notifications).

Even if you only do some of the steps, something is better than nothing. The goal is to make forward progress, not solve the issue in a single comment.

  1. Work with a partner. Select an issue from your component's queue (below). Pick a component you are familiar with, it will make things easier.
  2. Read the whole issue, or at least the last few comments to understand the issue. Do so in less than 15 minutes.
    • If you partly understand the issue, or if you have some questions about it, ask someone! You can ask one of the recommended contacts for the component, contributors who have worked on the issue, the sprint leads, or other contributors at the sprint or in IRC.
    • If you do not understand the issue in less than 15 minutes of reading it, choose a different issue.
    • Make note of:
      • Who filed it (Do they have more than 20 commit mentions in Drupal 8? More than 100? Are they a maintainer for the subsystem, an initiative coordinator, or a core committer? See list of maintainers.) Their experience with Drupal 8 lends credibility and validity to the issue.
      • When it was first created. If the issue is really old, then it has a higher chance of being not applicable.
      • When it was last updated. The longer the issue hasn’t been touched, the higher the chance that the issue is not applicable.
  3. Tag the issue with the tag for the sprint (e.g. "FLDC17") and comment that you are working on triaging it.
  4. Try to reproduce the issue in the 8.4.x (or latest) HEAD, either on simplytest.me or locally. (If you test locally, start clean and be sure you pull the latest changes from git. `git log` should show commits within the last day or so.)
    • If you can reproduce the issue, leave a comment indicating that you have confirmed that the bug is still present. Document the steps to reproduce in the issue summary if they are not listed there already, and then go on to the next step.
    • If you cannot reproduce the issue:
      1. Try to reproduce the issue using the version of Drupal from when the issue was filed. You may need to check a specific commit from a long time ago or even Drupal 7.x. (Use `git log --before=date` to find commits before a certain date.) Be sure to start clean.
      2. If you can reproduce the issue using an older version of Drupal 8.x, try to figure out when and how the issue was fixed, and document what you find on the issue. Techniques you can use:
        • Search for "Fixed" and "Closed (fixed)" issues related to the issue.
        • Use `git log -S` or `git log --grep` to search for related commits.
        • Use `git bisect` to find the first commit where the issue is resolved.
      3. If you find a specific issue that fixed it, mark the issue as a duplicate of the issue that fixed it, and move on to the next issue.
      4. If you can reproduce the issue in the latest version of Drupal 7 but not Drupal 8, post a comment indicating that the issue has been resolved in Drupal 8. Set the version to "7.x-dev" and remove the "needs backport to D7" tag if it is there. Move on to the next issue.
      5. If you still can't reproduce the issue, leave a comment indicating that you were unable to reproduce the issue in either the current version or the original version, and tag the issue with "Needs steps to reproduce". Move onto the next issue.
  5. For issues that are still relevant (i.e. you were able to reproduce the bug), identify any duplicate issues. If you close issues as a duplicate, go on to the next steps for the open major issue. (You can disregard the closed one(s) from now on.) Do a best effort to find duplicates. Timebox to less than 30 minutes.
  6. Determine if the issue summary is up to date. If it is not, tag the issue with "Needs issue summary update". You can also update the summary with what you know.
  7. If the issue has a patch, determine whether the latest patch is still relevant. Try applying the patch on a local git checkout. If the patch does not apply, tag it "Needs reroll". Only if the patch applies locally should you send it for re-testing.
  8. Tag the issue with the Triaged for D8 major current state issue tag.

Flowchart of the triage process

(PDF version)

Major triage queues

For the first few sprinters, here are a few issues tagged Needs triage for D8 major current state that the committers determined could use verification. So the first sprinters can look at those and potentially assess them.

Then, after that, sprinters should team up with others, pick one component, and search for that component within this queue:
Drupal 8 major bugs that have not already been triaged.

Updated: 2017-02-04
Component Issue count Bug queue
entity system 30 entity system bugs
views.module 21 views.module bugs
configuration system 20 configuration system bugs
forms system 17 forms system bugs
base system 15 base system bugs
file system 15 file system bugs
language system 14 language system bugs
comment.module 13 comment.module bugs
cache system 12 cache system bugs
routing system 11 routing system bugs
user.module 11 user.module bugs
migration system 11 migration system bugs
install system 10 install system bugs
field system 10 field system bugs
rest.module 9 rest.module bugs
simpletest.module 9 simpletest.module bugs
ajax system 8 ajax system bugs
system.module 8 system.module bugs
database system 7 database system bugs
menu system 7 menu system bugs
file.module 7 file.module bugs
request processing system 7 request processing system bugs
content_translation.module 7 content_translation.module bugs
update.module 7 update.module bugs
extension system 7 extension system bugs
asset library system 6 asset library system bugs
taxonomy.module 6 taxonomy.module bugs
node system 6 node system bugs
image system 6 image system bugs
filter.module 6 filter.module bugs
locale.module 6 locale.module bugs
documentation 5 documentation bugs
content_moderation.module 5 content_moderation.module bugs
text.module 5 text.module bugs
plugin system 5 plugin system bugs
image.module 5 image.module bugs
config_translation.module 5 config_translation.module bugs
javascript 4 javascript bugs
user system 4 user system bugs
language.module 4 language.module bugs
search.module 4 search.module bugs
quickedit.module 4 quickedit.module bugs
postgresql db driver 4 postgresql db driver bugs
theme system 4 theme system bugs
mail system 4 mail system bugs
mysql db driver 3 mysql db driver bugs
database update system 3 database update system bugs
sqlite db driver 3 sqlite db driver bugs
block_content.module 3 block_content.module bugs
Bartik theme 3 Bartik theme bugs
block.module 3 block.module bugs
datetime.module 3 datetime.module bugs
forum.module 3 forum.module bugs
path.module 3 path.module bugs
views_ui.module 3 views_ui.module bugs
rdf.module 2 rdf.module bugs
book.module 2 book.module bugs
editor.module 2 editor.module bugs
config.module 2 config.module bugs
link.module 2 link.module bugs
configuration entity system 2 configuration entity system bugs
serialization.module 2 serialization.module bugs
contextual.module 2 contextual.module bugs
toolbar.module 2 toolbar.module bugs
render system 2 render system bugs
phpunit 2 phpunit bugs
page_cache.module 2 page_cache.module bugs
field_ui.module 2 field_ui.module bugs
token system 2 token system bugs
bootstrap system 2 bootstrap system bugs
inline_form_errors.module 2 inline_form_errors.module bugs
number.module 1 number.module bugs
statistics.module 1 statistics.module bugs
contact.module 1 contact.module bugs
tour.module 1 tour.module bugs
dblog.module 1 dblog.module bugs
hal.module 1 hal.module bugs
menu_link_content.module 1 menu_link_content.module bugs
basic_auth.module 1 basic_auth.module bugs
batch system 1 batch system bugs
markup 1 markup bugs
ckeditor.module 1 ckeditor.module bugs
color.module 1 color.module bugs
lock system 1 lock system bugs
edit.module 1 edit.module bugs
tracker.module 1 tracker.module bugs
watchdog.module 1 watchdog.module bugs
responsive_image.module 1 responsive_image.module bugs
big_pipe.module 1 big_pipe.module bugs
outside_in.module 1 outside_in.module bugs
other 1 other bugs
entity_reference.module 1 entity_reference.module bugs
menu.module 1 menu.module bugs

Comments

xjm’s picture

Issue summary: View changes
heddn’s picture

Issue summary: View changes
cilefen’s picture

Issue summary: View changes
cilefen’s picture

Issue summary: View changes
cilefen’s picture

Issue summary: View changes
cilefen’s picture

Issue summary: View changes
FileSize
461.16 KB
xjm’s picture

Status: Postponed » Active

Welcome to the major issue triage sprint at DrupalCon Los Angeles!

mrf’s picture

mrf, metzlerd, phillamb168, bisong table to right of MAJOR TRIAGE sign looking at Views majors.

https://www.drupal.org/project/issues/search/drupal?project_issue_follow...

xjm’s picture

Issue summary: View changes
johnshortess’s picture

rklawson’s picture

I'm working with a team of three on https://www.drupal.org/node/2310175 for the menu system component.

Notes:
At /admin/config/development/configuration, the page title should be “Configuration Management” and the path should be /admin/config/development/configuration/synchronize, to make the path consistent with the other tasks/subtasks.

We have a patch to solve this by changing the name of the path from “Synchronize” to “Configuration Management.” We tested this, and it appears to be working correctly.

We also evaluated other areas of the site to ensure that “deep linking” was not broken (Configuration Settings > Account Settings and its tasks/subtasks).

Given that the default task requires the “sychronize configuration” permission, there may need to be more work to ensure that users can access the appropriate subtasks (some use “export configuration” and “import configuraiton.”

cilefen’s picture

Removed references to the "rc target" tag. We are not using that tag today.

bburg’s picture

metzlerd’s picture

jibran’s picture

I think taxonomy.module doesn't need triage only 5 issue all valid.

gapple’s picture

Issue summary: View changes

Updated summary with link to tagged issues

xjm’s picture

Issue summary: View changes
DuaelFr’s picture

Issue summary: View changes

Updated "start clean" links (404)

heddn’s picture

Issue summary: View changes
heddn’s picture

Issue summary: View changes
heddn’s picture

Issue summary: View changes
akalata’s picture

Issue summary: View changes
heddn’s picture

YesCT’s picture

How do we want to tag issues, so we know which still have to be triaged?

Triaged d8 major?

it parallels the critical tag
Triaged D8 critical https://www.drupal.org/project/issues/search/drupal?project_issue_follow...

there were some tagged with a drupalcon name:
Triaged at DrupalCon Los Angeles 2015 https://www.drupal.org/project/issues/search/drupal?project_issue_follow...

those should get whatever generic tag we come up with....

Or... we could "rename" that tag to "Triaged d8 major" some people on d.o have the ability to rename tag taxonomy terms.

cilefen’s picture

"Triaged d8 major" works for me.

heddn’s picture

Triaged D8 Major is acceptable. But we spent a good deal of time splitting this into two parts for triage. So I'd champion for two tags.
1) Triaged D8 Major Current State
2) Triaged D8 Major Acceptance Criteria

xjm’s picture

@heddn, what would the two tags mean?

1) Triaged D8 Major Current State
2) Triaged D8 Major Acceptance Criteria

heddn’s picture

re: #29: It would align with completion of these two phases.

  1. Current state
  2. Acceptance Criteria
xjm’s picture

Thanks @heddn, I see. So the first tag is about ensuring the issue's relevance, and the second is about ensuring the issue's actual eligibility to be committed to whatever branch it is filed against (8.0.x or 8.1.x). That way, all contributors can help "narrow the funnel" into a queue for experienced contributors to assess the issue in terms of the Allowed changes policy.

One option is that we could use simply "Triaged D8 major" for the second category (meeting the acceptance criteria), since it most closely corresponds to "Triaged D8 critical". The main difference is that only committers could tag issues as "Triaged D8 critical", but that was due largely to the fact that it so directly determined the release date. For major issues, I think we can encourage others to use this tag as well. The "Needs release manager review" tag can always be added if there is some doubt.

Based on that, I'd suggest the first tag be instead "Needs D8 major triage". That way, we would crowdsource creating a queue of issues that are still relevant, but need to be assessed for whether they can go into 8.0.x / 8.1.x / etc.

xjm’s picture

Issue summary: View changes

Removing the beta eval item from the steps since we're not in Kansas anymore. :D Also reduced the RC bullet to link to the allowed changes doc and tags now that we have those.

xjm’s picture

Issue summary: View changes

And also linking that in the step about assessing the issue for patch/minor/major version inclusion.

xjm’s picture

Issue summary: View changes

And fixing the list formatting a smidge.

xjm’s picture

Issue summary: View changes

And updating the background information for RC as well.

xjm’s picture

Issue summary: View changes
xjm’s picture

Issue summary: View changes

Add links for commit mentions and maintainers.

xjm’s picture

Issue summary: View changes
xjm’s picture

Issue summary: View changes
xjm’s picture

Issue summary: View changes
xjm’s picture

Issue summary: View changes
xjm’s picture

Issue tags: +drupalconasia2016

Updated to remove acceptance criteria steps for now -- I will create a separate meta for that.

Welcome to DrupalCon Asia 2016 major issue triage!

xjm’s picture

Issue summary: View changes
xjm’s picture

Issue summary: View changes

The flowchart is not up to date, so commenting it out for now.

xjm’s picture

Issue summary: View changes

For DrupalCon Asia, we'll start from the oldest issues in the major bug queue. Here is a link:

https://www.drupal.org/project/issues/search/drupal?project_issue_follow...

(Edit: Added a tag for issues to skip)

xjm’s picture

Issue summary: View changes
xjm’s picture

Issue summary: View changes
xjm’s picture

prasad_gogate’s picture

swarad07’s picture

Testing this issue, #2621422: Wrong default path for page.html.twig given. Patch works, waiting for tests to finish.

prasad_gogate’s picture

saitanay’s picture

nagwani’s picture

hitesh-jain’s picture

swarad07’s picture

Tested patch here, #2644838: Add test coverage for the editor's max dimension setting, and fix its message when one dimension is unrestricted. The patch works, but the code is missing comments in some places. Marked as Needs work.

nagwani’s picture

prasad_gogate’s picture

aditya.ghan’s picture

xjm’s picture

Category: Task » Plan

Thanks to everyone who participated in the DrupalCon Asia major triage sprint! I've updated the relevant major issues to add proposed issue credit for triagers where appropriate. We clarified the status of some of the oldest major bugs in the queue.

xjm’s picture

Issue summary: View changes
xjm’s picture

Issue summary: View changes
Issue tags: -drupalconasia2016
xjm’s picture

So the flow charts attached above are actually flipped around; the one labeled "Drupal 8 Triage Major Issues Acceptance Criteria Flowchart" is actually the current state flowchart and vice versa. Oops! :)

In the mentoring meeting we discussed updating the flowchart in preparation for DrupalCon NOLA. The acceptance criteria workflow (in the attachment labeled "current state") was pre-release and so is not applicable anymore. However, we are improving the process now so that core committers and subsystem maintainers collaborate to assess those criteria, so we don't need to worry about updating that flowchart.

Starting with DrupalCon Asia, we are focusing on triaging for current state at sprints. The current state flowchart (the one labeled "acceptance criteria") is very close to accurate still and just needs a couple updates:

1. The step that says "Can reproduce in 8.0.x?" should be changed to "Can reproduce in 8.2.x?".
2. The step that says "Tag 'Current State Triage Barcelona2015'" should be changed to "Tag 'Triaged for D8 major current state' and with sprint tag".

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

xjm’s picture

Alright, here is the updated flowchart.

xjm’s picture

I realized also that the endpoints for non-reproducible issues were actually not marked as such and instead pointing to the bubble to tag the issue as triaged. Attached fixes that, plus also adds in the steps to check whether the patch applies.

xjm’s picture

Fiddling the arrows to make them less confusing.
Flowchart of the triage process

mikeryan’s picture

Issue tags: +drupalconn

I'd like to start tagging some migration issues for NOLA sprinting - I don't see a specific tag in use yet, I'm thinking (a la "drupalconasia2016") "drupalconnola2016" - sound good? Or does it scan like a horrible misspelling (Drupal Canola - Oil of Champions)?

mikeryan’s picture

Issue tags: -drupalconn

(removing bad tag from failed search for existing "drupalconnola2016")

xjm’s picture

Issue summary: View changes
xjm’s picture

Issue tags: +neworleans2016

@mikeryan, @alimac proposed neworleans2016. Using that for now. :) (But yum, canola.)

xjm’s picture

Issue summary: View changes
xjm’s picture

Issue summary: View changes
xjm’s picture

Issue summary: View changes

And welcome to the New Orleans major triage sprint!

For the first few sprinters, here are a few issues tagged Needs triage for D8 major current state that the committers determined could use verification. So the first sprinters can look at those and potentially assess them.

Then, after that, sprinters should team up with others, pick one component, and search for that component within this queue:
Drupal 8 major bugs that have not already been triaged.

xjm’s picture

Issue summary: View changes

Thanks everyone for helping triage major issues at New Orleans! I've found the following usernames of major triage sprint participants for the NOLA sprint:

  1. cilefen
  2. valthebald
  3. catapipper
  4. dbyers55
  5. oadaeh
  6. Stephanie_42
  7. AndrewHD
  8. jdelvillar01
  9. gabesullice
  10. ecrown

I think that is missing several sprinters; let me know via my contact form if so. Also be sure to comment on any issue you helped triage so I can make sure you are credited.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

xjm’s picture

Issue summary: View changes

Adding a current table to the summary.

xjm’s picture

Issue summary: View changes
xjm’s picture

Issue summary: View changes

We are sprinting on major triage in a week at DrupalCamp New Jersey.

xjm’s picture

Issue summary: View changes
pwolanin’s picture

Issue summary: View changes
pwolanin’s picture

Do we want to suggest people may downgrade issues?

Need links to the definitions of different priority levels?

cilefen’s picture

Updated the flowchart with 8.4.x.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

xjm’s picture

Issue summary: View changes

@pwolanin So sprinters should not actually be downgrading the issues in most cases if they are still relevant. The process is to tag them once they're confirmed to be relevant and then the maintainers confirm the priority (or not) since that can take a lot more time to understand. See flowchart.

That said the priority definitions are obviously helpful! Somehow that is not linked in the summary already. I will add it: https://www.drupal.org/core/issue-priority#major-bug

xjm’s picture

Issue summary: View changes

Recent data.

xjm’s picture

Issue summary: View changes
xjm’s picture

xjm’s picture

Issue tags: +DrupalCampNJ2017

For DrupalCamp NJ there are just a few of us so we are coordinating which issues we are triaging in a spreadsheet:
https://docs.google.com/spreadsheets/d/1HIiqu9WPmjRuZc5qG_sn0pwbfYLtoFg5...

Great work so far!

YesCT’s picture

Issue summary: View changes
Issue tags: +FLDC17

updating for florida instructions

JCL324’s picture

Issue summary: View changes
capysara’s picture

Issue summary: View changes
capysara’s picture

Issue summary: View changes