Installer ui text cleanup

This is good work. A good idea.
Made me think about the whole 'welcoming proces' - but it is out of scope for this issue - might be an interesting snowman discussion

I have only a few comments in the attached files.

This is actually my first issue queue contribution - so please advice if some of it is out of scope and if there are ways I might work on with it, thanks :).

/K

reroll

Should we still take this up at before RC1 so that also the translations will be better?

If so, then it should be tagged with Barcelona2015

Please review the attached patch.

Please ignore the last patch.

re-uploading for the bot.

Patch #8 rerolled

Hi @pguillard,

I tested your patch and it works successfully. Here i have attached some screenshots.

Thanks @chetan2111 for your screenshots.

Patch from #13 re-rolled or 8.6.x.

Unfortunately, an interdiff could not created.

@cbeier It is impossible to interdiff a reroll.

This is a good start, but not all the changes request in #1 are fixed. Should we start by committing this and create a new issue for other improvements?

Needs reroll

error: patch failed: core/lib/Drupal/Core/Installer/Form/SiteConfigureForm.php:198
error: core/lib/Drupal/Core/Installer/Form/SiteConfigureForm.php: patch does not apply

Patch rerolled

Thanks pguillard,

Most points are addressed, just two small points:

1. Regional settings: the description text under the Default country widget can be removed (as in yoroy's screenshot) because it doesn't add any additional information
2. Update notifications: It's a bit unclear what the sending of anonymous information refers to. We could say In the process of checking for updates, anonymous information about your site is sent to Drupal.org.

Update with @ifrik suggestions.
I also changed the link to http“s”://drupal.org, recommanded nowadays.
(If there is another need, I'm sitting behind you at ddd.)

Here is the patch and interdiff as per the comment @ifrik

Thanks pguillard,
All issues addressed in issue summary are addressed. As already pointed out in the issue description, the description text for the site email address cannot be shortened since it only contains relevant information. Additionally, the link to drupal.org has been changed to https://

Screenshots

Just for clarification: I RTBCed installer_ui_text_cleanup-2098047-31.patch

The other patch in #32 came in while I was doing the review, so I didn't look at that further.

"in this site" is not valid English AFAIK, not sure how that sentence ended in the code to begin with. "Also we know that the settings are about this site, we don't say that anywhere else, so that is superfluous. "Dates will be displayed in the chosen timezone" sounds better, so its clear what the timezone is for.

As for the new text of "In the process of checking for updates" we can simply say "When checking for updates" IMHO. "In the process of" makes it sounds like some elaborate thing, which it is, but it is not really relevant :)

Here is the updated patch and interdiff as per comment #35

I just double-checked about the help text on the timezone, and it's actually not correct. Depending on the configuration, users can set their own timezones - in which case the date will be displayed to them in their chosen timezone.
Also there is some timezone weirdness, that means the timezone set in the installation is used for the system to convert time into UTC - not necessarily displaying it in that timezone. So I'm told by ekes working on the timezone issue that the current help text is wrong anyway.

Having said that: the help text doesn't add anything that isn't already obvious from the field label, including by saying "default" it already gives an indication that it can be overridden.

So I would propose removing the description altogether.

And a note about naming patches:
Dinesh18: you should always keep the original patch name and only change the number because otherwise reviewers don't know whether something is a new patch starting from scratch or work based on an existing patch. Especially in a case like this, where a second patch was posted on an issue that was already set to be reviewed. Also the interdiff should include the old and new number.
In this case I needed to go back and check manually on which patch you had based your further work. In this case, I knew what to look for, but in other cases that can be much more work.

Here is the updated patch and interdiff as per the comment mentioned in #37.
@ifrik, I have followed the proper steps for creating the patch and interdiff this time.
Sorry for the patch which I have created earlier with wrong naming convention.

Thanks Dinesh18, and thanks for changing the patch name back again.

The description on the Default time zone widget is now removed, so I think this is ready.

Committed f6e473e and pushed to 8.7.x. Thanks!