Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When searching the issue queue:
https://git7site.devdrupal.org/project/issues/search
The Issue tags have form elements and the label tags just don't match up for edit-vocabulary-9-op:
<div id="edit-vocabulary-9-wrapper" class="views-exposed-widget views-widget-filter-vocabulary_9">
<label for="edit-vocabulary-9"> Issue tags </label>
<div class="views-operator">
<div class="form-item form-type-select form-item-vocabulary-9-op">
<select id="edit-vocabulary-9-op" class="form-select" name="vocabulary_9_op">events=Object { change=[1], click=[1], blur=[1], more...}handle=function()
</div>
</div>
<div class="views-widget">
<div class="form-item form-type-textfield form-item-vocabulary-9" role="application">
<input id="edit-vocabulary-9" class="form-text form-autocomplete" type="text" maxlength="128" size="32" value="" name="vocabulary_9" autocomplete="OFF" aria-autocomplete="list">events=Object { change=[1], click=[1], blur=[2], more...}handle=function()
<input id="edit-vocabulary-9-autocomplete" class="autocomplete autocomplete-processed" type="hidden" disabled="disabled" value="https://git7site.devdrupal.org/admin/views/ajax/autocomplete/taxonomy/9">events=Object { change=[1], click=[1], blur=[1], more...}handle=function()
<span id="edit-vocabulary-9-autocomplete-aria-live" class="element-invisible" aria-live="assertive"></span>
</div>
</div>
Comment | File | Size | Author |
---|---|---|---|
#35 | Screenshot 2021-05-03 at 1.19.26 PM.png | 44.66 KB | BhumikaVarshney |
#34 | 2096013-34.patch | 2.5 KB | vsujeetkumar |
#22 | vdc-2096013-22.patch | 2.64 KB | mgifford |
#20 | vdc-2096013-20.patch | 2.66 KB | mgifford |
#17 | vdc-2096013-17.patch | 2.71 KB | dawehner |
Comments
Comment #1
MustangGB CreditAttribution: MustangGB commentedConfirmed, but perhaps you could tell us what is should be, which would make it an easier job to fix.
Comment #2
jthorson CreditAttribution: jthorson commentedI believe
<label for="edit-vocabulary-9"> Issue tags </label>
needs to show up immediately before the<input id="edit-vocabulary-9" ...
tag, instead of outside of the container divs.Comment #3
tvn CreditAttribution: tvn commentedComment #4
mgiffordThere are 3 form elements:
edit-vocabulary-9-op
edit-vocabulary-9
edit-vocabulary-9-autocomplete
Only one label
<label for="edit-vocabulary-9">
Every input elements needs to be associated with a label.
Hope this helps.
Comment #5
drummIssue queues use the usual Views exposed filters.
Comment #6
kalman.hosszu CreditAttribution: kalman.hosszu commentedI will check it
Comment #7
kalman.hosszu CreditAttribution: kalman.hosszu commentedI attached the first version of the patch. It creates a new form item in operations for label and shows the exposed filters' #title attribute. I also attached a screenshot about the admin interface change.
Please review and tell me if something needs to be modified.
Comment #8
drumm'#title_display' => 'invisible'
can be used to have the title be available for screen readers, and keep the visual UI the same.Comment #10
dawehnerI committed the patch, because it looked kinda nice, but haven't updated the browser in the meantime.
Let's work on a patch to hide the title as well.
Comment #11
kalman.hosszu CreditAttribution: kalman.hosszu commentedI created a small patch to hide the title.
Comment #12
dawehnerThere we go.
Comment #13
dawehner.
Comment #14
drummThanks!
We already have a Views -dev upgrade coming up for #2128849: Module downloads listed as "gz" instead of "tar.gz" and #2138855: Module project index page - exposed fields don't work too. That should happen next week, when things are more quiet.
Comment #15
drummNow deployed on Drupal.org.
Comment #16
mgifford@dawehner should this still be listed as "Patch (to be ported)"?
Seems like it's been a bit all over the place.
Not sure where in D8 the views_handler_filter() function currently is sitting.
Comment #17
dawehnerJust started a port.
Comment #19
mgiffordComment #20
mgiffordFile moved...
Comment #22
mgiffordreroll
Comment #24
mgiffordComment #33
larowlanThis is invalid YAML, there can't be two `operator:` keys
Triaged this as part of bug-smash, I think this belongs in the Views queue.
Comment #34
vsujeetkumar CreditAttribution: vsujeetkumar at Srijan | A Material+ Company for Drupal India Association commentedRe-roll patch given for 8.9.x and worked on #33, Updated 'operator' to 'operator_label'.
@larowlan Please have a look and advise.
Comment #35
BhumikaVarshney CreditAttribution: BhumikaVarshney as a volunteer and at OpenSense Labs commentedHi @vsujeetkumar,
Thanks for the patch.
It works good for me and applies cleanly.
Comment #36
drummRe-titling to be more-straightforward for what the core issue is.
Comment #37
dwwI wonder if this is still even needed now that #2625136: Fix label visibility and add wrapper container for exposed numeric/date filters with multiple form elements is fixed.
Comment #42
smustgrave CreditAttribution: smustgrave at Mobomo commentedThis was previously tagged for tests in #24 which still need to happen.
Did not test for issue.