EntityTranslationController::entityFormAlter will produce following warning when translations was enabled after entity creation:

Warning: Invalid argument supplied for foreach() in Drupal\translation_entity\EntityTranslationController->entityFormAlter() (line 244 of /var/www/drupal8/core/modules/translation_entity/lib/Drupal/translation_entity/EntityTranslationController.php).

Attached patch adds extra check for the $entity->translation array.

CommentFileSizeAuthor
#9 invalid_argument-2010194-9.patch4.18 KBrosinegrean
#6 invalid_argument-2010194-6.patch4.13 KBalansaviolobo
#5 Avoid-warning-when-translating-node-created-before-enabling-content-translations-2010194-5.patch4.28 KBjsbalsera
#3 Avoid-warning-when-translating-node-created-before-enabling-content-translations-2010194-3.patch1.13 KBjsbalsera
translation_entity-fix_warning.patch1.11 KBinternetdevels

Comments

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

This should be covered by tests before commit

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Component: translation_entity.module » content_translation.module
jsbalsera’s picture

jsbalsera
he/his
Primary language Spanish
Location Córdoba, Spain
commented
Status: Needs work » Needs review
StatusFileSize
new Avoid-warning-when-translating-node-created-before-enabling-content-translations-2010194-3.patch1.13 KB

Re-rolled the patch and add Tests

jsbalsera’s picture

jsbalsera
he/his
Primary language Spanish
Location Córdoba, Spain
commented
Status: Needs review » Needs work

Sorry, forgot to add the Test.

jsbalsera’s picture

jsbalsera
he/his
Primary language Spanish
Location Córdoba, Spain
commented
Status: Needs work » Needs review
StatusFileSize
new Avoid-warning-when-translating-node-created-before-enabling-content-translations-2010194-5.patch4.28 KB

Now the complete patch.

alansaviolobo’s picture

alansaviolobo commented
Issue summary: View changes
StatusFileSize
new invalid_argument-2010194-6.patch4.13 KB

reroll

mgifford queued 6: invalid_argument-2010194-6.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 6: invalid_argument-2010194-6.patch, failed testing.

rosinegrean’s picture

rosinegrean commented
Status: Needs work » Needs review
StatusFileSize
new invalid_argument-2010194-9.patch4.18 KB

rerolled

Status: Needs review » Needs work

The last submitted patch, 9: invalid_argument-2010194-9.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Needs work » Closed (outdated)
Issue tags: +Bug Smash Initiative

@InternetDevels, thank you for reporting this problem. We rely on issue reports like this to improve Drupal core.

I tested this on Drupal 9.5.x and did not get a warning when translations was enabled after entity creation.

Therefore, closing as outdated. If this is incorrect reopen the issue, by setting the status to 'Active', and add a comment explaining what still needs to be done.

Thanks!