Drupal Association members fund grants that make connections all over the world.
Follow up for
Moves comment to a field api field. We would love to get the threading and pager settings into the formatter, instead of the field settings, this would allow this to be used in views etc ie anywhere else display settings can be configured
Also the UX around field settings is poor.
Also there is lots of juggling code around view modes in the comment formatter.
Lets clean it up
Move threading and pager settings into formatter settings (from field settings).
Move comment_new_page_count and comment_num_new to the CommentManager service
Change arguments to comment_new_page_count to include passing the number-per-page and the threading mode as arguments instead of fetching them from the field.
Update formatter-output to include data-comment-per-page and data-comment-mode attributes. Send these attributes to CommentController::renderNewCommentsNodeLinks() allowing it call the comment_new_page_count function with the new arguments (note it is the only place this function is called).
- Write the patch.
- Take screenshots (show the current UI and annotate showing what will change).
User interface changes
Settings will be moved from field settings to formatter settings.
comment_new_page_count moved to manager service and new arguments.
Note CommentController::renderNewCommentsNodeLinks is the only place this function is called.
This will move settings from comment-field instance settings to one of comment-formatter or comment-type config-entity - so config schema changes
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] 94,114 pass(es), 660 fail(s), and 295 exception(s). View
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] 92,611 pass(es), 2,125 fail(s), and 569 exception(s). View