From #1850418: Provide D7 -> D8 Views upgrade path in contrib, not core. The Views D7 -> D8 upgrade path will be provided by http://drupal.org/project/views_d8_upgrade, which will migrate the user's data and uninstall the D7 version of Views so that the D8 core version of Views can be installed cleanly. So, we should prevent the user from running update.php if a pre-D8 version of Views is installed.

Attached is not testable until #1848998: Problems with update_module_enable() is resolved.

Files: 
CommentFileSizeAuthor
#21 vdc-1851386-21.patch1.5 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 55,611 pass(es), 32 fail(s), and 32 exception(s).
[ View ]
#21 interdiff.txt1.3 KBdawehner
#15 drupal-views-requirements-1851386-15.patch3.27 KBkmoll
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]
#10 1851386-views-requirements.patch3.27 KBkmoll
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]
views-requirements.patch1.54 KBxjm
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-requirements.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

xjm’s picture

Title:Add a hook_requirements() to Views disallowing upgrade from D7 views» Add a hook_requirements() to Views disallowing unsupported upgrade from D7 views
dawehner’s picture

Issue tags:+VDC

Add tag. On one hand this would be super-usefull for the users, though i ask myself, whether we can link to contrib projects out of core?

xjm’s picture

In general I'd say no, but in this case I think we should. This one hook implementation would be the only reference to contrib Views we'd have, and doing it this way guarantees it's the only one we'll need or that users will expect.

xjm’s picture

Title:Add a hook_requirements() to Views disallowing unsupported upgrade from D7 views» Add a hook_requirements() to Views disallowing unsupported upgrade from D7 Views
dawehner’s picture

views-requirements.patch queued for re-testing.

dawehner’s picture

This would be indeed a nice patch!

Status:Needs review» Needs work

The last submitted patch, views-requirements.patch, failed testing.

dawehner’s picture

Issue tags:+Novice, +Needs reroll

.

kmoll’s picture

Assigned:Unassigned» kmoll
Issue tags:-Novice, -Needs reroll

working on re-roll

kmoll’s picture

StatusFileSize
new3.27 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]

When re-rolling the patch i got conflicts with functions that don't seem to be in the latest version, so I removed them and recreated the patch. Those functions were views_update_last_removed(), views_update_8000, views_update_8001(), views_update_8002

kmoll’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:-VDC

The last submitted patch, 1851386-views-requirements.patch, failed testing.

kmoll’s picture

Status:Needs work» Needs review

#10: 1851386-views-requirements.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+VDC

The last submitted patch, 1851386-views-requirements.patch, failed testing.

kmoll’s picture

StatusFileSize
new3.27 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]

fixed and recreated patch

kmoll’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:-VDC

The last submitted patch, drupal-views-requirements-1851386-15.patch, failed testing.

kmoll’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:+VDC

The last submitted patch, drupal-views-requirements-1851386-15.patch, failed testing.

kmoll’s picture

Assigned:kmoll» Unassigned
dawehner’s picture

Status:Needs work» Needs review
StatusFileSize
new1.3 KB
new1.5 KB
FAILED: [[SimpleTest]]: [MySQL] 55,611 pass(es), 32 fail(s), and 32 exception(s).
[ View ]

get_t() is already replace by the translator service.

The last submitted patch, vdc-1851386-21.patch, failed testing.