From #1850418: Provide D7 -> D8 Views upgrade path in contrib, not core. The Views D7 -> D8 upgrade path will be provided by http://drupal.org/project/views_d8_upgrade, which will migrate the user's data and uninstall the D7 version of Views so that the D8 core version of Views can be installed cleanly. So, we should prevent the user from running update.php if a pre-D8 version of Views is installed.

Attached is not testable until #1848998: Problems with update_module_enable() is resolved.

CommentFileSizeAuthor
#21 vdc-1851386-21.patch1.5 KBdawehner
#21 interdiff.txt1.3 KBdawehner
#15 drupal-views-requirements-1851386-15.patch3.27 KBkmoll
#10 1851386-views-requirements.patch3.27 KBkmoll
views-requirements.patch1.54 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Add a hook_requirements() to Views disallowing upgrade from D7 views » Add a hook_requirements() to Views disallowing unsupported upgrade from D7 views
dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +VDC

Add tag. On one hand this would be super-usefull for the users, though i ask myself, whether we can link to contrib projects out of core?

xjm’s picture

xjm
she/her
Primary language English
commented

In general I'd say no, but in this case I think we should. This one hook implementation would be the only reference to contrib Views we'd have, and doing it this way guarantees it's the only one we'll need or that users will expect.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Add a hook_requirements() to Views disallowing unsupported upgrade from D7 views » Add a hook_requirements() to Views disallowing unsupported upgrade from D7 Views
dawehner’s picture

dawehner
Primary language German
commented

views-requirements.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented

This would be indeed a nice patch!

Status: Needs review » Needs work

The last submitted patch, views-requirements.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Novice, +Needs reroll

.

kmoll’s picture

kmoll commented
Assigned: Unassigned » kmoll
Issue tags: -Novice, -Needs reroll

working on re-roll

kmoll’s picture

kmoll commented
StatusFileSize
new 1851386-views-requirements.patch3.27 KB

When re-rolling the patch i got conflicts with functions that don't seem to be in the latest version, so I removed them and recreated the patch. Those functions were views_update_last_removed(), views_update_8000, views_update_8001(), views_update_8002

kmoll’s picture

kmoll commented
Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, 1851386-views-requirements.patch, failed testing.

kmoll’s picture

kmoll commented
Status: Needs work » Needs review

#10: 1851386-views-requirements.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, 1851386-views-requirements.patch, failed testing.

kmoll’s picture

kmoll commented
StatusFileSize
new drupal-views-requirements-1851386-15.patch3.27 KB

fixed and recreated patch

kmoll’s picture

kmoll commented
Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, drupal-views-requirements-1851386-15.patch, failed testing.

kmoll’s picture

kmoll commented
Status: Needs work » Needs review

#15: drupal-views-requirements-1851386-15.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, drupal-views-requirements-1851386-15.patch, failed testing.

kmoll’s picture

kmoll commented
Assigned: kmoll » Unassigned
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.3 KB
new vdc-1851386-21.patch1.5 KB

get_t() is already replace by the translator service.

The last submitted patch, vdc-1851386-21.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Closed (won't fix)

No need for this.

Thanks for everyone who contributed!