Starting a discussion about a Drupal 7 version.

Are any blockers here? The last commit on this project was over a year ago so I assume it's just low priority for the maintainers.

CommentFileSizeAuthor
#63 d7_port-1011890-63.patch40.44 KBDeciphered
#61 d7_port-1011890-60.patch39.55 KBDeciphered
#51 securesite_fix_http_header-1011890-51.patch534 bytesdtarc
#47 fix_http_header_1011890.patch610 bytesjonathan_hunt
#10 secure-site-d7-first-pass.patch36.14 KBsime
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rhache’s picture

rhache CreditAttribution: rhache commented

I'd love to see this for D7. Super useful.

Thanks

Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented

This has been a low priority for me because I haven’t been able to use it on any of my projects. However, I am interested in turning this into an alternative to using cookies for authentication.

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented

Would you accept a straight D7 patch first?

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented

Commit access also welcome, with the understanding I'd just be working on the D7 branch for a week or so.

Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented

A Drupal 7 patch would be welcome. I was just talking about what I was interested in working on. For some reason I thought you already had commit access. I’ll be happy to give it to you.

Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented

sime is now a maintainer.

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented

Thanks Darren!

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented
Title: Drupal 7 version? » Drupal 7 upgrade progress...
Assigned: Unassigned » sime

DRUPAL-7--2 branch created.

Coding standards, spaces around concatenation
http://drupal.org/cvs?commit=477542
http://drupal.org/cvs?commit=477544

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented

Coding standards, spaces around concatenation
http://drupal.org/cvs?commit=477554

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented
FileSize
secure-site-d7-first-pass.patch36.14 KB

Here's the first pass at it. It's not stable, just posting my current changes here because I might not get a chance for a couple of days. I decided not to commit what I'd done straight away as it isn't in a usable state.

Note, the patch doesn't include the rename of securesite-user-login.tpl.php to securesite-user-login-form.tpl.php due to a namespace collision at the form level (hook_user_login conflicts).

Anyway, last thing I was working on was the login form.

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented

I've made a dev release for drush/etc convenience.

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented

Oh damn CVS. Commit without a message after I didn't abort properly :(
http://drupal.org/cvs?commit=478242

Here's what the message was *supposed* to be...

Made the first pass of changes to securesite. The outcome was to get the tests running (387 passes, 134 fails).

* Updated .info file for D7
* Updated queries for DTNG
* Updated calls to drupal_set_header to drupal_add_http_header
* Split hook_user into hook_user_HOOKs
* New function _securesite_user_digest_cleanup() to support hook_user_insert hook_user_update user_insert_load
* Changed links to logout to user/logout
* Initial modification to _securesite_digest_validate() to return a name => value array for compatibility with drupal_add_http_header()
* Move hook_perm to hook_permissions()
* Move 'admin/settings/securesite' to 'admin/config/securesite'
* Add module_load_include() to securesite.test before every _securesite_parse_directives() as it isn't being included for whatever reason.
* Move form_clean_id() to drupal_clean_css_identifier()
* Use user_role_grant_permissions() and user_role_revoke_permissions() instead of hitting perm tables directly in securesite.test
* Fix path 'admin/settings/error-reporting' to 'admin/config/development/logging'
* Call user_cancel() instead of user_delete in securesite.test
cwrstl’s picture

cwrstl CreditAttribution: cwrstl commented

sime - Thanks for getting this ball rolling. Is the current dev in CVS usable yet, or does it still need work?

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented
Assigned: sime » Unassigned

hi @cwrstl - it installs but doesn't work properly. The job is half finished basically.

Eg. I get a popup password window in Firefox but not in Safari. And the theming code of the login form isn't quite right. A lot of things are identified in the test results.

I've been sick the last week and this threw out my schedule, so I don't know when I will be able to get back to this. But it's definitely closer to being finished.

Rosamunda’s picture

Rosamunda CreditAttribution: Rosamunda commented

I get nothing. Not in Firefox, not even in Chrome.
I get a white screen with a grey rectangle with rounded corners.

ogi’s picture

ogi CreditAttribution: ogi commented

subscribe

brainiac’s picture

brainiac CreditAttribution: brainiac commented

subscribe

tronathan’s picture

tronathan CreditAttribution: tronathan commented

subscribarino

MGParisi’s picture

MGParisi CreditAttribution: MGParisi commented

subscribe

socialtalker’s picture

socialtalker CreditAttribution: socialtalker commented

subscribe

anthonyR’s picture

anthonyR CreditAttribution: anthonyR commented

subscribe

rovo’s picture

rovo
Location Delaware
CreditAttribution: rovo commented

subscribe

boombatower’s picture

boombatower CreditAttribution: boombatower commented

so much fun, subscribe

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
CreditAttribution: anavarre commented

Subscribe

basicmagic.net’s picture

basicmagic.net CreditAttribution: basicmagic.net commented

subscribe

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

subscribing

BenK’s picture

BenK CreditAttribution: BenK commented

SUbscribing

rovo’s picture

rovo
Location Delaware
CreditAttribution: rovo commented

It's pretty laughable that there was never a function made that allows us to just subscribe to a post, rather than having to fill it with 'subscribe' tags...

boombatower’s picture

boombatower CreditAttribution: boombatower commented

#28: note the ChipIn http://drupal.org/project/project.

Seph’s picture

Seph CreditAttribution: Seph commented

subscribe

vegardjo’s picture

vegardjo CreditAttribution: vegardjo commented

sub..

Slovak’s picture

Slovak CreditAttribution: Slovak commented

Subscribe

dddave’s picture

dddave CreditAttribution: dddave commented

sub

dwalker51’s picture

dwalker51 CreditAttribution: dwalker51 commented

+1

Branjawn’s picture

Branjawn CreditAttribution: Branjawn commented

sub

Donaldd’s picture

Donaldd CreditAttribution: Donaldd commented

subscribing

netsensei’s picture

netsensei CreditAttribution: netsensei commented

Okay. Subscribing.

This has been open for the last 6 months. Any idea if there is time in the near future to put a 7.x-dev git branch up? At least, if someone is interested in contributing patches to speed things up, it would make things a lot easier.

tronathan’s picture

tronathan CreditAttribution: tronathan commented

subscribing

8thom’s picture

8thom CreditAttribution: 8thom commented

sub

chriz001’s picture

chriz001 CreditAttribution: chriz001 commented

Subscribe

tars16’s picture

tars16 CreditAttribution: tars16 commented

Subscribe

chriscalip’s picture

chriscalip CreditAttribution: chriscalip commented

subscribe to chip-in reply :)

Note to self : secure site d7.

j0nathan’s picture

j0nathan CreditAttribution: j0nathan commented

Subscribing.

cwrstl’s picture

cwrstl CreditAttribution: cwrstl commented

subscribing

Macronomicus’s picture

Macronomicus CreditAttribution: Macronomicus commented
Version: master » 7.x-2.x-dev

There is a 7.x branch in there (Last update Feb 25, 2011) http://drupal.org/node/21470/release
I tested and it seemed to be quite buggy and crashed my site.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

Did you report any of the errors? Could you run it through Coder?

jonathan_hunt’s picture

jonathan_hunt CreditAttribution: jonathan_hunt commented
FileSize
fix_http_header_1011890.patch610 bytes

Adding HTTP headers has changed in D7 (see http://api.drupal.org/api/drupal/includes--bootstrap.inc/function/drupal...). Attached is a patch that correctly triggers browser HTTP Auth dialog in Safari, Chrome and Firefox (other browsers not tested).

boombatower’s picture

boombatower CreditAttribution: boombatower commented

For those looking for something in D7 there is also http://drupal.org/project/shield as of a few days ago that seems is much simpler, but does not use user credentials.

CryptKeeper-1’s picture

CryptKeeper-1 CreditAttribution: CryptKeeper-1 commented

Newbie here...is this module usable with the patches installed?

just tried it without and it seemed like a successful install from the admin menu, changed various settings, etc. then logged out and got a grey rounded rectangle on a mac and PC in Safari and Chrome. switched to IE on the PC and was able to get a username/password prompt, but user1 credentials were not accepted into the popup.

had to manually delete the mod using ftp to get back into the site.

kclarkson’s picture

kclarkson CreditAttribution: kclarkson commented

Does this last patch need to be added to make a 7 development release?

This is a great module and the best solution for making sites private during the staging phase. Based on the amount of downloads I am surprised this isn't done for 7 yet.

@boombatower

Thanks for the Shield suggestion. I will use it for now but would prefer Secure Site as it provides a few more features.

dtarc’s picture

dtarc CreditAttribution: dtarc commented
FileSize
securesite_fix_http_header-1011890-51.patch534 bytes

The patch is #47 was made from a couple directories up. Rerolling...

dtarc’s picture

dtarc CreditAttribution: dtarc commented

With the patch in #51, the module doesn't seem to work in Chrome for Mac. It blocks the site with a user/pass popup but does not provide access once the creds are correctly entered.

dtarc’s picture

dtarc CreditAttribution: dtarc commented

I think the issue is that user_authenticate_finalize() is being called but it's D6 only (not in D7).

http://api.drupal.org/api/drupal/modules--user--user.module/function/use...

deville’s picture

deville CreditAttribution: deville commented

Check out: http://drupal.org/project/shield

cossimo’s picture

cossimo CreditAttribution: cossimo commented

Subscribe, yo...

sdoyle’s picture

sdoyle CreditAttribution: sdoyle commented

All i get is the gray box with HTML login form and for HTML Basic it never recognizes valid user credentials. This is for Drupal 7. I've attempted to apply the patch manually by vi the file, but it seems to break it. Can someone provide better instructions on editing that file? There must be a solution for Drupal 7 that provides a login form of some sort before granting access to the site (like with http basic auth). Without this, anonymous users have too much access, including views of menu links with many themes. Shield does not work for this issue. Does anyone have a working example, including a securesite.inc they can post?

quantos’s picture

quantos CreditAttribution: quantos commented

Following. Would love to use this through beta-testing of new sites, screening out the public while my registered clients/contacts test the site. I'll check out project/shield meantime but any feedback to help with this specific closed beta-testing scenario would be appreciated. Thanks.

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented
Title: Drupal 7 upgrade progress... » D7 upgrade STALLED

I don't see anyone working on the D7 branch for 18 months (since my initial port). So I'm going to give it a friendly title.

portulaca’s picture

portulaca
she/her
CreditAttribution: portulaca commented

+1

Deciphered’s picture

Deciphered CreditAttribution: Deciphered commented
Title: D7 upgrade STALLED » D7 Upgrade
Status: Active » Needs review

I had to really try to hold back from doing a complete re-write, but I just don't have the time to do that anyway.... probably... but either way, here's an updated patch that fixes a ll the issues that I found and that where causing the module to be unusable for me.

Let's make a push to get a stable released ASAP!

Deciphered’s picture

Deciphered CreditAttribution: Deciphered commented
FileSize
d7_port-1011890-60.patch39.55 KB

Forgot to attach the patch :/

Makefile snippet to use this patched version:

projects[securesite][type] = module
projects[securesite][download][type] = git
projects[securesite][download][url] = http://git.drupal.org/project/securesite.git
projects[securesite][download][revision] = 182cb51937d8c36d53f7e8adb62ad047e73f65df
projects[securesite][subdir] = contrib
; Additional fixes for D7 port - http://drupal.org/node/1011890#comment-6541786
projects[securesite][patch][] = http://drupal.org/files/d7_port-1011890-60.patch
Deciphered’s picture

Deciphered CreditAttribution: Deciphered commented
Status: Needs review » Needs work

Last minute typo got in, re-roll of the patch coming very shortly.

Deciphered’s picture

Deciphered CreditAttribution: Deciphered commented
Status: Needs work » Needs review
FileSize
d7_port-1011890-63.patch40.44 KB

Fixed patch, also incorporates patches from, so credit to the authors there.
- http://drupal.org/node/1339938
- http://drupal.org/node/1423620
- http://drupal.org/node/1528012

Makefile snippet:

projects[securesite][type] = module
projects[securesite][download][type] = git
projects[securesite][download][url] = http://git.drupal.org/project/securesite.git
projects[securesite][download][revision] = 182cb51937d8c36d53f7e8adb62ad047e73f65df
projects[securesite][subdir] = contrib
; Additional fixes for D7 port - http://drupal.org/node/1011890#comment-6541822
projects[securesite][patch][] = http://drupal.org/files/d7_port-1011890-63.patch
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

Just looked at the version control info here - http://drupal.org/project/securesite/git-instructions

Which should this patch be applied to?

Deciphered’s picture

Deciphered CreditAttribution: Deciphered commented

This should be applied to 7.x-2.x, however I now have commit access and I will start committing some code shortly so that we can really make a push to get a stable release out ASAP.

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented

Hey Deciphered, was going to look at the patch, but I only got as far as fixing my localhost after an osx upgrade last night. But if you have commit access then I guess problem solved in the short term :)

Deciphered’s picture

Deciphered CreditAttribution: Deciphered commented
Status: Needs review » Fixed

A bunch of commits have been made, going to mark this issue as Fixed so that we can focus on individual issues that pop up instead of having one big issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Marc Angles’s picture

Marc Angles CreditAttribution: Marc Angles commented

Hi, Just installed this module and I have this problem. Redering the usage of this module unusable...

Did I missed something or the patch was not committed ?

Fatal error: Call to undefined function i18n_selection_mode() in [...]/modules/securesite/securesite.inc on line 313

Marc Angles’s picture

Marc Angles CreditAttribution: Marc Angles commented
Status: Closed (fixed) » Active

I reopen the issue. sorry.oops

Marc Angles’s picture

Marc Angles CreditAttribution: Marc Angles commented
Status: Active » Closed (fixed)

  • Commit 556ffa8 on 7.x-2.x, 8.x-1.x authored by jonathan_hunt, committed by Deciphered: 
    #1011890: Fixed issue with http header.
  • Commit bd345a3 on 7.x-2.x, 8.x-1.x by Deciphered:
    #1528012 by Patrizio: Fixed issue with i18n integration.
#1414678 by...
  • Commit dc8ded0 on 7.x-2.x, 8.x-1.x by sime:
    #1011890 Coding standards for the use of concatenation operator.
  • Commit fe7a13b on 7.x-2.x, 8.x-1.x by sime:
    #1011890 Coding standards for the use of concatenation operator.