Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
D10.2 has a new deprecation which has thankfully noticed that we have an extra assertExpectedAjaxRequest() we don't need in ZoneTerritoryElementTest:
Remaining self deprecation notices (1)
1x: Drupal\FunctionalJavascriptTests\JSWebAssert::assertExpectedAjaxRequest called unnecessarily in a test is deprecated in drupal:10.2.0 and will throw an exception in drupal:11.0.0. See https://www.drupal.org/node/3401201
1x in ZoneTerritoryElementTest::testZoneTerritory from Drupal\Tests\address\FunctionalJavascript
Steps to reproduce
See https://www.drupal.org/pift-ci-job/2850990
Run
Proposed resolution
Identify and remove it.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3419633-2.patch | 1.23 KB | dww |
Comments
Comment #2
dwwSince we currently see the deprecations on DrupalCI not GitLabCI, here's a patch.
Comment #6
dwwBot is happy, so am I. 😉
Comment #7
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedWith these two deprecations fixed, what is your plan for the next release? 2.0.0 is quite new, 27 Dec 2023. But are you thinking of a 2.0.1 release? I know in the past that making a release is a "big thing" but there now seems to be a move towards "release small, release often" or whatever the phrase is.
3rd-party modules that use Address in testing would benefit from the new release. I am wary about using a -dev release in testing, as that can be more volatile. Just asking ... no hurry ...
Comment #8
dwwFrom triaging the queue, I'd say #3412241: Mismatched field definitions after address upgrade is probably a blocker for a 2.0.1 release. Maybe we should open a dedicated issue to plan it to make sure @bojanz is okay with it.
Comment #9
bojanz CreditAttribution: bojanz for Bluespark commentedI am fine with proceeding with 2.0.1 without #3412241: Mismatched field definitions after address upgrade. It only affects a portion of the users, and I personally have no time to work on it, so I don't want to hold off other fixes because of it.
Comment #10
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedA quick auto-generated release notes show that 12 issues were fixed. That sounds like a good enough improvement to warrant a 2.0.1 release
Contributors (6)
Nikolay Shapovalov, Project Update Bot, Upchuk, bluegeek9, bojanz, dww
Changelog
Issues: 12 issues resolved.
Changes since 2.0.0:
Bug
Feature
Task
Comment #11
bojanz CreditAttribution: bojanz for Bluespark commentedWent ahead and tagged 2.0.1: https://www.drupal.org/project/address/releases/2.0.1