Hi,

This is my first full Drupal module release, so I hope I've got everything in place.

This module provides very basic integration with Help Scout's Beacon (https://www.helpscout.net) - A helpdesk tool. Allowing people to submit a support ticket from the admin section of your Drupal 7 site.

Project page: https://www.drupal.org/project/help_scout_beacon

git clone --branch 7.x-1.x https://git.drupal.org/project/help_scout_beacon.git

Thanks,
Chris

Comments

c_archer created an issue. See original summary.

c_archer’s picture

c_archer commented
Title: [] Help Scout's Beacon » [D7] Help Scout's Beacon
PA robot’s picture

PA robot commented
Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

k3vin_nl’s picture

k3vin_nl commented
Status: Needs review » Needs work

I'll structure the review according to the checklist.

1.1 ✔️
2.1 ✔️
3.1 ✔️ I didn't spot any issues.
4.1 X A LICENSE.TXT is present
4.2 ✔️
5.1 ✔️
5.2 ✔️
5.3 ✔️
6.1 X Parereview.sh gives one warning: All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Also ESLint shows some code style issues in beacon.js
7.1 ✔️ / X beacon.js could probably be rewritten in a more Drupal way, but as stated in the file itself, the code is mostly from Helpscout.

c_archer’s picture

c_archer commented

Thanks @K3vin_nl, I have now updated the code, I will at some point probably re-write the JS file.

c_archer’s picture

c_archer commented
c_archer’s picture

c_archer commented
Status: Needs work » Needs review
c_archer’s picture

c_archer commented
Status: Needs review » Active
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review

Please don't change the status to Active, or reviewers will not check the project code.

sleitner’s picture

sleitner commented
Status: Needs review » Needs work

Automated Review

Review of the 7.x-1.x branch (commit dc5a265):

This automated report was generated with PAReview.sh, your friendly project application review script.

/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 4, col 1, Error - Expected an assignment or function call and instead saw an expression. (no-unused-expressions)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 4, col 2, Error - Use the function form of 'use strict'. (strict)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 7, col 55, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 13, col 7, Error - Expected an assignment or function call and instead saw an expression. (no-unused-expressions)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 13, col 22, Error - Unexpected use of comma operator. (no-sequences)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 15, col 7, Error - Expected an assignment or function call and instead saw an expression. (no-unused-expressions)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 15, col 24, Error - Unexpected use of comma operator. (no-sequences)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 15, col 64, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 16, col 28, Error - Missing semicolon. (semi)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 17, col 28, Error - Missing space before function parentheses. (space-before-function-paren)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 18, col 32, Error - Missing semicolon. (semi)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 22, col 20, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 29, col 7, Error - Split 'var' declarations into multiple statements. (one-var)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 29, col 38, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 30, col 29, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 31, col 7, Error - Expected an assignment or function call and instead saw an expression. (no-unused-expressions)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 31, col 16, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 31, col 33, Error - Unexpected use of comma operator. (no-sequences)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 31, col 57, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 31, col 129, Error - Missing semicolon. (semi)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/beacon.js: line 33, col 4, Error - Missing semicolon. (semi)

21 problems

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not follow the guidelines for in-project documentation and/or the README Template. See pareview
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
  1. (*) The help_scout_beacon.module does not implement hook_help()
  2. (*) JavaScript coding standards, see pareview

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

If you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.