[D7] Advanced Poll Media

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxtsotsos2443759git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,
Review:
1)Please add parameter description for functions. Ex:advpoll_media_add.
2)A function without body.

/**
 * Preprocess function for advpoll-results.tpl.php.
 */
function advpoll_media_preprocess_advpoll_results(&$vars) {
}

Thanks

Hi @tsotsos

Manual Review:

Individual user account
Yes: Follows the guidelines for individual user accounts.

No duplication
Yes: Does not cause module duplication and/or fragmentation.

Master Branch
Yes: Follows the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.

Secure code
Yes: Meets the security requirements.

Coding style & Drupal API usage
As suggested by @saurabh.tripathi.cs remove function because it does not have any definition:

/**
 * Preprocess function for advpoll-results.tpl.php.
 */
function advpoll_media_preprocess_advpoll_results(&$vars) {
}

Hello tsotsos!

Manual Review:

Individual user account
Yes, follows the guidelines for individual user accounts.

No duplication
Yes, doesn't cause module duplication and/or fragmentation.

Master Branch
Yes, follows the guidelines for master branch.

Licensing
Yes, follows the licensing requirements.

3rd party assets/code
Yes, follows the guidelines for 3rd party assets/code.

README.txt/README.md
Yes, follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review
Yes, follows the guidelines for project length and complexity.

Coding style & Drupal API usage
This module matches Coding style & Drupal API usage best practices.

Just a recommendation.
Use @param tag for comments to the following functions
advpoll_media_choices_save()
theme_advpoll_media()
advpoll_media_get_choices_lang()
advpoll_media_choice_fid
advpoll_media_choice_text
advpoll_media_load_multiple
advpoll_media_delete
advpoll_media_add

Use @return tag for comments to the following functions
theme_advpoll_media()
advpoll_media_get_choices_lang()
advpoll_media_choice_fid
advpoll_media_choice_text
advpoll_media_load_multiple

Add "Implements hook_load()." for this
function advpoll_media_load($choice_id)

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

@tsotsos, did you get it figured out? I'm guessing that since you marked the issues as Fixed, everything is okay?

The issue status doesn't do anything for your ability to promote projects. It's a manual thing.

I double-checked your account, and you're a vetted Git user on Drupal.org, so now you should just be able to go to https://www.drupal.org/node/2443759/edit/promote to promote your project.

Please let me know if you have any further troubles.

You created this project as "drupal.org project", but you should create it as "module" project. Please create a new sandbox as "module" and push your code there. Then delete the old sandbox to avoid confusion.