[meta] Tasks to deprecate Toolbar module

Explicitly postponing this on navigation being stable, but that is close per #3421969: [PLAN] New Navigation and Top Bar to replace Toolbar Roadmap: Path to Stable.

We will need to enable navigation in the standard profile and umami in order to actually deprecate toolbar, but there might be some other things that could happen in the meantime like making sure that no tests have explicit dependencies on it.

#3421969-81: [PLAN] New Navigation and Top Bar to replace Toolbar Roadmap: Path to Stable onwards discusses that Settings Tray also has a hard dependency on Toolbar, however Settings Tray has such low usage that decoupling them may not be effort well spent. Should their move to contrib be handled together then?

Looks like we could tackle the things in #9 and #10 before navigation is in standard, that would mean less work to do later.

Not much we can do with #9 yet I'm afraid.

These need #3465299: Integrate Announcements module into Navigation's drawer/submenu:

core/modules/announcements_feed/tests/src/Functional/AnnouncementsCacheTest.php
core/modules/announcements_feed/tests/src/FunctionalJavascript/AccessAnnouncementTest.php
core/modules/announcements_feed/tests/src/FunctionalJavascript/AlertsJsonFeedTest.php
core/modules/announcements_feed/tests/src/Kernel/AnnounceFetcherUserTest.php

These uses can likely be removed:

core/modules/config_translation/tests/src/Functional/ConfigTranslationListUiTest.php
core/modules/contact/tests/src/Functional/ConfigTranslationListUiTest.php
core/modules/responsive_image/tests/src/Unit/ResponsiveImageStyleConfigEntityUnitTest.php
core/modules/system/tests/src/Functional/Menu/MenuAccessTest.php
core/modules/views_ui/tests/src/Functional/DisplayPathTest.php

Some parts of these test integration with contextual.module, so probably needs to be moved into toolbar.module?

core/modules/contextual/tests/src/FunctionalJavascript/ContextualLinksTest.php
core/modules/contextual/tests/src/FunctionalJavascript/EditModeTest.php

These are false positives:

core/modules/editor/tests/src/Functional/Rest/EditorResourceTestBase.php
core/modules/editor/tests/src/Kernel/EditorValidationTest.php
core/modules/jsonapi/tests/src/Functional/EditorTest.php

These need to move into toolbar.module:

core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderToolbarTest.php
core/modules/system/tests/src/Functional/Theme/ToolbarClaroOverridesTest.php

These only uninstall toolbar from standard or Umami:

core/modules/navigation/tests/src/FunctionalJavascript/PerformanceTest.php
core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryAuthenticatedPerformanceTest.php

Some parts of these test integration with shortcut.module, but that is also moving to contrib:

core/modules/shortcut/tests/src/Functional/ShortcutCacheTagsTest.php
core/modules/shortcut/tests/src/Functional/ShortcutTestBase.php
core/modules/shortcut/tests/src/Functional/ShortcutTranslationUITest.php
core/modules/shortcut/tests/src/Kernel/ShortcutCacheTagsTest.php

This needs to stay until we update the database dump:

core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php

This probably needs #3511374: Core Navigation + Workspace + Workspace UI modules crashes Drupal Installation and then the toolbar tests moving to toolbar.module:

core/modules/workspaces/tests/src/Functional/WorkspaceSwitcherTest.php
core/modules/workspaces/tests/src/Functional/WorkspaceTest.php
core/modules/workspaces_ui/tests/src/FunctionalJavascript/WorkspaceToolbarIntegrationTest.php

The toolbar hook implementations I think we could move all of those into the toolbar module with a moduleExists() check.

This can't be completed until #3560117: [meta] Add Navigation to the Standard profile and recipes lands, which in turn is waiting for accessibility issues in Navigation to be fixed.

It feels unlikely at this point that Toolbar will be removed from Drupal 12.

Also related to toolbar: _system_is_claro_admin_and_not_active() and the 3 hooks in system module that use it, I don't know why that stuff is in system and not in toolbar, should be easy enough to move, I guess including claro_system_module_invoked_library_info_alter() in claro.theme.

I bet there's one more blocker - who is willing to maintain it in contrib

I see the Drupal 6 module https://www.drupal.org/project/toolbar, perhaps it can be Drupal core Toolbar's new home?

@dydave maintains https://www.drupal.org/project/admin_toolbar and I made him aware of this issue in #3565206: [Meta] Roadplan for Admin Toolbar 3.7 and 4.x, as a potential maintainer.

That was originally a backport of the Drupal 7 module, makes sense to keep the namespace the same as core's.

As mentioned by my contrib partner @ressa above at #19, I've been maintaining the Admin Toolbar module for more than a year now and would certainly be interested in helping maintaining the Toolbar module if it moves over to contrib.

Feel free to add me directly as one of the maintainers, if you'd like, or please let me know if you would like me to formally apply in module's issue queue, I would be glad to do so.

Congrats everyone for all the great work and efforts getting core Navigation stabilized. 🥳

Thanks in advance! 😊

Running into #4 over at #3575909: Remove the Settings Tray dependency on Toolbar - settings tray doesn't really work without toolbar, looks like we either need to make settings tray work with Navigation instead, or remove settings tray as well.

The toolbar/claro stuff in system module is fully moved to toolbar module in #3579899: Remove remaining claro.theme functions, but we likely need a follow-up to that to clean up a few things around that such as hardcoded core/themes/claro paths (this will not prevent removing toolbar, but it will need to fixed eventually before claro is moved)

Re #21:
I've contacted the contrib Toolbar module maintainer who kindly granted me maintainer's rights, see:
#3607179: Applying for 'Maintainer' role for the project Toolbar

I went ahead and imported the core toolbar module with its complete history with the command:
git filter-repo --subdirectory-filter core/modules/toolbar/
into the 1.x branch in contrib Toolbar module's repo:
https://git.drupalcode.org/project/toolbar/-/commits/1.x

I'll make basic adjustments to the info, composer.json, .gitlab-ci files to get a minimal DEV release, which should allow unblocking the D12 compatible DEV for Admin Toolbar (4.x).

Added tests part 2 to issue summary.

I fed the current diff of #3611762: Move toolbar hook implementations to the toolbar module and #3612474: Move toolbar integration tests to toolbar module, part 2 to Claude (with Sonnet 4.6) to find any other missing gaps. It found these that seem like are not already covered:

There are also these shortcut module mentions that I don't think need to be done given that shortcut also is moving to contrib.

Pretty sure the contextual test should either be moved to toolbar or deleted, per #3465295: Integrate Top Bar Navigation with Contextual editing where it was decided not to implement similar functionality in navigation.

Added #3614955: Move library overrides for Toolbar from Claro and Default Admin to Toolbar for the library overrides, it seems pretty straightforward to move them from both Claro and Default Admin to Toolbar. Gets rid of some 'gin' mentions of default_admin even and also noticed that a CSS file was added by Default Admin that did not even exist. See there.

The contextual clicking integration test is already handled in #3612474: Move toolbar integration tests to toolbar module, part 2 by being removed, so that satisfies @catch's note in #38 :) No need to open an issue for that. So I think everything in #37 is now covered.

I found the following (used LLM to assist me, but verified the found code paths and even manually tested some stuff):

Will be removed with the Shortcut module, should be done before Toolbar IMHO, so it stays in contrib Shortcut:

1. ShortcutHooks.php:71 — uses #[Hook('toolbar')] and the toolbar_item render element

2. Shortcut tests heavily use Toolbar. ShortcutTestBase.php:20 , ShortcutTranslationUITest.php:43, ShortcutCacheTagsTest.php:32 and multiple shortcut tests grant 'access toolbar' permission.

Should still be moved to the Toolbar module to not loose these integrations

The backend parts of these were attempted to be moved in #3611762: Move toolbar hook implementations to the toolbar module but in many cases the utility classes, CSS/JS libraries, etc. stayed around with the modules apparently.

1. We already accepted the regression of announcements not appearing in the default toolbar (in Drupal CMS they are prominent on the dashboard). The base toolbar hook was moved but AnnouncementsFeedToolbarHooks.php:22 still implements hook_toolbar_alter() and LazyBuilders.php:48 — uses toolbar CSS classes and announcements_feed/drupal.announcements_feed.toolbar library.

2. User module integration in user.services.yml:53 — defines user.toolbar_link_builder and ToolbarLinkBuilder.php itself, despite the hook already moved to Toolbar.

3. Contextual menu integration for Toolbar has this toggle feature that shows ALL the contextually editable things. Navigation does not implement this. It was decided in #3465295: Integrate Top Bar Navigation with Contextual editing 2 years ago not do that. The hook implementation was moved to Toolbar already but contextual.libraries.yml:25 was not.

4. Workspaces UI module has integration with Toolbar. The hook implementation was moved already but WorkspacesUiLazyBuilders.php:44 remained. It uses toolbar-item, toolbar-icon CSS classes and workspaces_ui/drupal.workspaces_ui.toolbar library.

Should be removed at the same time as the Toolbar module:

1. Default Admin integration (this does not exist as contrib, so should be removed alongside Toolbar removal in core). PreprocessHooks.php:650 uses $this->currentUser->hasPermission('access toolbar'), ThemeHooks.php:222 overrides toolbar and menu__toolbar theme registry paths, PreprocessHooks.php:1223 — #[Hook('preprocess_toolbar_user_picture')] and template overrides in core/themes/default_admin/templates/navigation/.

2. Various small overrides and mentions.

• toolbar template overrides in core/themes/claro/templates/navigation/
• Umami profile has toolbar-warning.css, toolbar component CSS, toolbar template override
• PHPStan baseline — 6 suppressed entries for toolbar classes
• Navigation module — @see toolbar_page_top() docblock references
• core/misc — comments in displace.js and off-canvas CSS mentioning toolbar

I opened #3618746: Toolbar uses in Announcement, User, Contextual and Workspaces for the ones that still need moving (where we already moved hooks in #3611762: Move toolbar hook implementations to the toolbar module but left around other integrations.

@quietone opened and started working on the toolbar alter in announcements feed at #3618772: Move toolbar_alter hook implementations to the toolbar module, left some feedback there.