Problem/Motivation

Move tests of Toolbar from other modules to the toolbar module.

$ git grep -lwi "'toolbar'" | grep -v core/modules/toolbar/ | grep -v core/modules/editor | grep -v core/modules/jsonapi | grep -v core/modules/shortcut | grep -v core/modules/ckeditor5 | grep -v core/assets | grep -v phpstan-baseline | grep -v MAINTAINERS | grep Test.php | nl

Steps to reproduce

Proposed resolution

  1. core/modules/contextual/tests/src/FunctionalJavascript/ContextualLinksTest.php
  2. core/modules/contextual/tests/src/FunctionalJavascript/EditModeTest.php
  3. core/modules/responsive_image/tests/src/Unit/ResponsiveImageStyleConfigEntityUnitTest.php
  4. core/modules/system/tests/src/Functional/Theme/ToolbarClaroOverridesTest.php
  5. core/modules/workspaces/tests/src/Functional/WorkspaceSwitcherTest.php
  6. core/modules/workspaces/tests/src/Functional/WorkspaceTest.php
  7. core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryAuthenticatedPerformanceTest.php. - Toolbar was replaced with Navigation in #3560118: In Umami, replace Toolbar with Navigation, so removal install of Navigation as well.
  8. core/themes/default_admin/tests/src/Functional/AdminTest.php - a simple removal and should have been done in #3611749: Remove toolbar from tests where it is not needed

Remaining tasks

Verify that each of the tests is using the toolbar module and change as needed to not use the Toolbar module.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3612474

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

quietone created an issue. See original summary.

quietone’s picture

Issue summary: View changes
quietone’s picture

Issue summary: View changes
Status: Active » Needs review
smustgrave’s picture

Looks good left 1 question on the MR.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new98 bytes

The Needs Review Queue Bot tested this issue. The merge request has merge conflicts and cannot be merged. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

quietone’s picture

Status: Needs work » Needs review
gábor hojtsy’s picture

@smustgrave: resolved your one question :)

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for humoring me and taking a look. Didn’t mean to hold it up, kinda fell off my radar. Review queue is massive right now!

  • catch committed 77247452 on main
    task: #3612474 Move toolbar integration tests to toolbar module, part 2...
catch’s picture

Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to main, thanks!

We'll need a backport MR for 11.x

quietone’s picture

Status: Patch (to be ported) » Needs review

11.x backport ready

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

All green seems like a good backport.

needs-review-queue-bot’s picture

Status: Reviewed & tested by the community » Needs work
StatusFileSize
new4.29 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

quietone’s picture

Status: Needs work » Reviewed & tested by the community
Issue tags: +no-needs-review-bot

The diff applied cleanly to 11.x, so restoring RTBC and stopping the bot

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed ef423647 on 11.x
    task: #3612474 Move toolbar integration tests to toolbar module, part 2...