Problem/Motivation
Move tests of Toolbar from other modules to the toolbar module.
$ git grep -lwi "'toolbar'" | grep -v core/modules/toolbar/ | grep -v core/modules/editor | grep -v core/modules/jsonapi | grep -v core/modules/shortcut | grep -v core/modules/ckeditor5 | grep -v core/assets | grep -v phpstan-baseline | grep -v MAINTAINERS | grep Test.php | nl
Steps to reproduce
Proposed resolution
- core/modules/contextual/tests/src/FunctionalJavascript/ContextualLinksTest.php
- core/modules/contextual/tests/src/FunctionalJavascript/EditModeTest.php
- core/modules/responsive_image/tests/src/Unit/ResponsiveImageStyleConfigEntityUnitTest.php
- core/modules/system/tests/src/Functional/Theme/ToolbarClaroOverridesTest.php
- core/modules/workspaces/tests/src/Functional/WorkspaceSwitcherTest.php
- core/modules/workspaces/tests/src/Functional/WorkspaceTest.php
- core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryAuthenticatedPerformanceTest.php. - Toolbar was replaced with Navigation in #3560118: In Umami, replace Toolbar with Navigation, so removal install of Navigation as well.
- core/themes/default_admin/tests/src/Functional/AdminTest.php - a simple removal and should have been done in #3611749: Remove toolbar from tests where it is not needed
Remaining tasks
Verify that each of the tests is using the toolbar module and change as needed to not use the Toolbar module.
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|
Issue fork drupal-3612474
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3612474-11-x
changes, plain diff MR !16577
- 3612474-move-toolbar-integration
changes, plain diff MR !16407
Comments
Comment #3
quietone commentedComment #4
quietone commentedComment #5
smustgrave commentedLooks good left 1 question on the MR.
Comment #6
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. The merge request has merge conflicts and cannot be merged. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #7
quietone commentedComment #8
gábor hojtsy@smustgrave: resolved your one question :)
Comment #9
smustgrave commentedThanks for humoring me and taking a look. Didn’t mean to hold it up, kinda fell off my radar. Review queue is massive right now!
Comment #11
catchCommitted/pushed to main, thanks!
We'll need a backport MR for 11.x
Comment #13
quietone commented11.x backport ready
Comment #14
smustgrave commentedAll green seems like a good backport.
Comment #15
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #16
quietone commentedThe diff applied cleanly to 11.x, so restoring RTBC and stopping the bot
Comment #17
catchCommitted/pushed to 11.x, thanks!