Problem/Motivation

As part of making Navigation a standard piece of Drupal kit, and replacing Toolbar, we need to change Umami so it uses Navigation instead of Toolbar.

Issue fork drupal-3560118

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

phenaproxima created an issue. See original summary.

longwave made their first commit to this issue’s fork.

longwave opened merge request !14420

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » main
Status: Active » Needs review

This is the simplest change that works for me. The experimental warning still shows up. There are still some references to Toolbar in Umami but I think those can stay for now, in case someone installs Toolbar inside Umami?

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

Needs a rebase, but otherwise looks good. I think we can open a follow-up to de-toolbarify Umami.

catch’s picture

catch
he/him
Primary language English
commented
Priority: Normal » Major
Issue tags: +11.4.0 release priority

One more performance test to update.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I think it would be interesting to see the impact of #3418328: Optimise Layout builder EntityViewDisplay but it might also be easier to do that after this on its own so we don't mix it up with the toolbar to navigation switch. But I think the current increase in queries might be related to that problem with the navigation/layout builder situation.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

But yes, comparing with #3060985: Layout Builder attempts to builds sections to determine if it is disabled, that definitely adds stuff back that was removed by that other issue.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Easy enough to test. Applied the MR and did an umami install.

Makes sense.

Are we not doing for standard since standard and minimal are going away (I believe)

catch’s picture

catch
he/him
Primary language English
commented

Standard is #3560117: [meta] Add Navigation to the Standard profile and recipes but blocked on missing documentation and accessibility triage/fixes a bit longer.

We'll have some kind of default install that will be in-between standard and minimal, and the navigation bar will be in that (and admin theme etc.).

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

The MR needs a rebase.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll

Rebased, only adjusted one performance figure so back to RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !14420

  • catch committed 045450e3 on 11.x 
    task: #3560118 In Umami, replace Toolbar with Navigation

By:...

  • catch committed 20e9a3ae on main 
    task: #3560118 In Umami, replace Toolbar with Navigation

By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.