Problem/Motivation

#3452724: Navigation side bar and top bar should have appropriate aria labels has landed which means the last known stable blocker for Navigation module is fixed.

This means we should try to mark Navigation stable for 11.3.0, and being the process of replacing the toolbar module entirely.

#3421969: [PLAN] New Navigation and Top Bar to replace Toolbar Roadmap: Path to Stable has a list of should and could have issues, it would be good to do a final triage of that list and the navigation issue queue to make sure there are no hidden critical surprises in there.

For this issue, we need an MR removing the experimental flag from navigation.info.yml, and should also update the d.o documentation for experimental modules.

We also have follow-ups (linked) for:

- replacing toolbar in Umami
- replacing toolbar in Standard
- deprecating the toolbar module (will need to be for 11.4 now).

Issue fork drupal-3557578

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

pameeela’s picture

pameeela commented
Issue tags: +11.3.0 release priority

plopesc made their first commit to this issue’s fork.

plopesc opened merge request !13878

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented

Glad to see this is moving forward.

I’ve created an initial merge request to kick off the work.

Some discussion might be necessary to decide whether all the internal and final classes in the module should remain as they are, or could be more open once the module is considered stable.

That conversation could be moved to a follow-up if needed, though.

finnsky’s picture

finnsky commented

Congrats to everyone!

Probably also floating-ui lib should not be internal now?
https://git.drupalcode.org/project/drupal/-/blob/HEAD/core/core.librarie...

it can be used by other module themes

Usage candidates:
https://www.drupal.org/node/3197758
https://www.drupal.org/project/dialog_native

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Reviewed & tested by the community
Issue tags: +Drupal CMS release target

Making the library non-internal seems like something that could be done in a follow-up, and need not block this issue.

Tentatively marking RTBC, although it still needs sign-offs from UX and product managers. Drupal CMS is a major user of Navigation and we'd love to see it be stable.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Issue tags: -Needs UX manager review

+1 to mark Navigation as Stable.

I've tested it locally (both with Claro and Gin) and reviewed all the standing issues on the issue queue, and I've found nothing beyond what we already have on the Should have list.

Also to mention that we discussed it with core committers and @Emma Horrell said "I'm not aware of any UX issues that would be stable blocker - so no concerns from me".

So removing the Needs UX manager review tag to help unblock this.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue tags: -Needs product manager review

+1 for marking Navigation stable and for the follow-ups to utilize it by default in the install profiles and to deprecate the old toolbar.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Needs work

CSS changed a bunch after #3511280: Front-end theme styles can bleed into Navigation needs updating

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented

Should we wait for #3531516: Admin toolbar height is not 100% since upgrading to Drupal 11.2 as well? It seems pretty close.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Needs release manager review

We started a triage of the outstanding issues filed since #3421969: [PLAN] New Navigation and Top Bar to replace Toolbar Roadmap: Path to Stable had an out-of-date-ish IS. @ckrina, @lauriii, myself, and others credited here triaged all the major bugs, all the issues listed in the IS, etc., and found no blockers there. However, we did find some concerning issues in the Navigation that we started to tag as known issues to mention in the release notes (not yet added to the release notes drafts, but tagged as "11.3.0 release notes"). We did not quite finish the whole list -- will try to do so ASAP.

A couple of the bugs we noticed from the accessibility review (#3391723: [PLAN] Accessibility review for new Navigation bar) sounded like criticals to me, and under normal circumstances might have been raised as stable blockers. Given that nothing else is blocking stable and that Navigation is such a huge usability improvement, @ckrina and I proposed instead making these issues blockers for including Navigation in the Standard profile. So, I proposed a release management exception to allow Navigation to be marked as stable despite having these accessibility issues, listing them as known issues in the release notes, and a call-to-action for help to get them fixed either before 11.3.0 or in a patch release.

Issues that were especially concerning were:

If Navigation is experimental, these are major. If it is stable, issues with parts of the page not being accessible to keyboard navigation become critical. (I thought I had already promoted one of those to critical, but apparently Shinkasen wifi ate it.)

Also maybe:

Full accessibility roadmap: #3391723: [PLAN] Accessibility review for new Navigation bar

To be clear, I still think Navigation should be marked stable in 11.3 regardless. I also recognize that Navigation needs community help with getting these accessibility bugs fixed. But these issues should have been stable blockers and anything we can do to communicate that they're known bugs we care about fixing is valuable.

There's also another 50 or so random issues I need to review in the queue and I'll try to do so in the next day or so.

catch’s picture

catch
he/him
Primary language English
commented

It looks like #3541910: Elements in closed sidebar are focusable might fix #3543541: [PP-1] on the mobile viewport with the navigation sidebar collapsed the menu items are still available in the aural interface so we may want to merge or otherwise swap those two.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs work » Needs review

CSS styles in Stable9 updated after last changes in Navigation.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community

OK it seems all the issues mentioned issues after #12 are fixed, so moving back to RTBC so this doesn't get blocked and we don't miss the date. What is the next step?

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue summary: View changes
Related issues: +#3560118: In Umami, replace Toolbar with Navigation, +#3560117: [meta] Add Navigation to the Standard profile and recipes, +#3560123: Deprecate the Toolbar module

Added some related issues.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: -Needs release manager review

Thanks for opening the follow-ups. We can sort out what exactly should or should not block standard in the issue to add navigation to standard. There is some good progress on #3541910: Elements in closed sidebar are focusable already so would be great if people can keep an eye on that issue. Removing the RM review tag since both @xjm and me have commented here. @longwave also confirmed he's +1 in slack.

  • longwave committed 9ac8e261 on 11.3.x 
    task: #3557578 Mark Navigation as a stable module

By: catch
By: plopesc...

  • longwave committed 42e67ca7 on 11.x 
    task: #3557578 Mark Navigation as a stable module

By: catch
By: plopesc...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: +11.3.0 release notes

Let's do it! Committed and pushed 42e67ca70b2 to 11.x and 9ac8e261050 to 11.3.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !13878

xjm’s picture

xjm
she/her
Primary language English
commented

We need the release note draft to include the various known issues that @ckrina and I started tagging, including the accessibility issues and other bugs, with a CTA to fix them so that Navigation can be the default in Standard in 11.4.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.