Problem/Motivation

Navigation is about to become a stable module, in #3557578: Mark Navigation as a stable module.

Before that can happen, there are some outstanding accessibility issues that need to be triaged, per #3421969: [PLAN] New Navigation and Top Bar to replace Toolbar Roadmap: Path to Stable. We also need to sort out #3512287: [policy, no patch] Deprecate Stable9 and move to contrib, since that would have helped Navigation be marked stable sooner.

Child Issues

Must have

Should have

Issue fork drupal-3560117

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

phenaproxima created an issue. See original summary.

berdir’s picture

\Drupal\Tests\navigation\FunctionalJavascript\PerformanceTest will become mostly pointless with this change and could be removed either here or in a follow-up. The one specific assert should be moved to StandardPerformanceTest

thejimbirch’s picture

Should we also update the Standard recipes?

quietone’s picture

Related issues:

Remove duplicate related

longwave’s picture

Status: Active » Postponed

Discussed with @catch, the change itself is trivial but we can't actually do this until the critical accessibility issues from #3391723: [PLAN] Accessibility review for new Navigation bar are fixed, so marking postponed on that.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

catch’s picture

Status: Postponed » Active

I think that with #3541910: Elements in closed sidebar are focusable in 11.4, #3438477: High contrast mode needs some more refinement RTBC and also #3565213: Adjust contextual CSS for navigation module reset CSS RTBC (not accessibility but a regression in 11.3), that we're in a position to unpostpone this now.

We need to get the two RTBC issues in and a triage of the remaining accessibility issues would be good, but both of those can happen while an MR is prepared here.

@jimbirch we should probably update the standard recipe + profile at the same time to keep them more or less in sync.

kentr’s picture

Noting that #3421969: [PLAN] New Navigation and Top Bar to replace Toolbar Roadmap: Path to Stable says #3450523: Documentation for Navigation module should have been a stable blocker, in case it should also be a blocker for going into Standard.

catch’s picture

Title: [meta] Add Navigation to the Standard profile » [meta] Add Navigation to the Standard profile and recipes
Category: Feature request » Task
Priority: Normal » Critical

#3450523: Documentation for Navigation module has some basic documentation now (after fighting with 500 errors in the d.o handbook).

We're down to four issues identified as blocking on #3391723: [PLAN] Accessibility review for new Navigation bar, three of which are RTBC. Those issues aren't the same as the ones that were previously identified as blocking but I think we can be pretty confident they'll all be in before 11.4 is released at this point.

So I think we should go ahead and prepare an MR here given there won't be any code conflicts between these issues.

We should update both the install profile and the recipes, don't have a strong preference whether that's done in one issue or two, maybe see how it goes?

This is blocking #3484850: [meta] Tasks to deprecate Toolbar module which in turn blocks deprecating/removing the underscore and backbone js libraries from core, so bumping to critical. We might not have time to move toolbar to contrib for 12.0 but more chance of doing that if we get going now.

plopesc made their first commit to this issue’s fork.

plopesc changed the visibility of the branch 3560117-meta-add-navigation to hidden.

catch’s picture

All the issues identified by the accessibility team as blocking in #3391723: [PLAN] Accessibility review for new Navigation bar now have fixes committed. So we're properly down to #3575171: Add Navigation to the Standard profile and recipes now.

edit: got overexcited, #3551528: Mobile expanded sidebar modal overlay has invalid ARIA attribute: aria-expanded is still RTBC, but down to one.

kentr’s picture

edit: got overexcited, #3551528: Mobile expanded sidebar modal overlay has invalid ARIA attribute: aria-expanded is still RTBC, but down to one.

It's fixed now. 🚀

plopesc’s picture

Issue summary: View changes

Once #3575171: Add Navigation to the Standard profile and recipes has been merged, we are almost there!

plopesc’s picture

Once #3575171: Add Navigation to the Standard profile and recipes has been merged, we are almost there!

berdir’s picture

Status: Active » Fixed

I think we're done here with this mini meta?

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.