Closed (fixed)
Project:
Drupal core
Version:
main
Component:
navigation.module
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Nov 2025 at 15:15 UTC
Updated:
20 Mar 2026 at 12:15 UTC
Jump to comment: Most recent
Comments
Comment #2
berdir\Drupal\Tests\navigation\FunctionalJavascript\PerformanceTest will become mostly pointless with this change and could be removed either here or in a follow-up. The one specific assert should be moved to StandardPerformanceTest
Comment #3
thejimbirch commentedShould we also update the Standard recipes?
Comment #4
quietone commentedRemove duplicate related
Comment #5
longwaveDiscussed with @catch, the change itself is trivial but we can't actually do this until the critical accessibility issues from #3391723: [PLAN] Accessibility review for new Navigation bar are fixed, so marking postponed on that.
Comment #7
catchI think that with #3541910: Elements in closed sidebar are focusable in 11.4, #3438477: High contrast mode needs some more refinement RTBC and also #3565213: Adjust contextual CSS for navigation module reset CSS RTBC (not accessibility but a regression in 11.3), that we're in a position to unpostpone this now.
We need to get the two RTBC issues in and a triage of the remaining accessibility issues would be good, but both of those can happen while an MR is prepared here.
@jimbirch we should probably update the standard recipe + profile at the same time to keep them more or less in sync.
Comment #8
kentr commentedNoting that #3421969: [PLAN] New Navigation and Top Bar to replace Toolbar Roadmap: Path to Stable says #3450523: Documentation for Navigation module should have been a stable blocker, in case it should also be a blocker for going into Standard.
Comment #9
catch#3450523: Documentation for Navigation module has some basic documentation now (after fighting with 500 errors in the d.o handbook).
We're down to four issues identified as blocking on #3391723: [PLAN] Accessibility review for new Navigation bar, three of which are RTBC. Those issues aren't the same as the ones that were previously identified as blocking but I think we can be pretty confident they'll all be in before 11.4 is released at this point.
So I think we should go ahead and prepare an MR here given there won't be any code conflicts between these issues.
We should update both the install profile and the recipes, don't have a strong preference whether that's done in one issue or two, maybe see how it goes?
This is blocking #3484850: [meta] Tasks to deprecate Toolbar module which in turn blocks deprecating/removing the underscore and backbone js libraries from core, so bumping to critical. We might not have time to move toolbar to contrib for 12.0 but more chance of doing that if we get going now.
Comment #12
catchAll the issues identified by the accessibility team as blocking in #3391723: [PLAN] Accessibility review for new Navigation bar now have fixes committed. So we're properly down to #3575171: Add Navigation to the Standard profile and recipes now.
edit: got overexcited, #3551528: Mobile expanded sidebar modal overlay has invalid ARIA attribute: aria-expanded is still RTBC, but down to one.
Comment #13
kentr commentedIt's fixed now. 🚀
Comment #14
plopescOnce #3575171: Add Navigation to the Standard profile and recipes has been merged, we are almost there!
Comment #15
plopescOnce #3575171: Add Navigation to the Standard profile and recipes has been merged, we are almost there!
Comment #16
berdirI think we're done here with this mini meta?