Port password-hash.sh to a console command as part of #2289405: [META] Port all shell scripts to console commands.

CommentFileSizeAuthor
#25 2289409-nr-bot.txt132 bytesneeds-review-queue-bot
#14 2289409-14.patch7.59 KBdawehner
#14 interdiff-2289409.txt904 bytesdawehner
#7 2289409_7.patch8.91 KBchx
#2 drupal_2289409_2.patch6.92 KBxano
#1 drupal_2289409_1.patch1.85 KBxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new drupal_2289409_1.patch1.85 KB
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new drupal_2289409_2.patch6.92 KB

This patch deletes the script and adds test coverage.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Works fine with #2242947-37: Integrate Symfony Console component to natively support command line operations.

jmolivas’s picture

jmolivas commented

Since we have been working on this contributed project http://drupalconsole.com/ there is already code that could be reused on core or contributed space to facilitate the use of Console component in order to enable Drupal users to create commands easily.

Feel free to ping me or any console maintainers for help writing this commands.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: drupal_2289409_2.patch, failed testing.

chx’s picture

chx commented
Status: Needs work » Needs review
StatusFileSize
new 2289409_7.patch8.91 KB

This version works fine as it is. It doesn't contain a lot from above (except the reflection invoke), it follows the structure of dump-database-d8-mysql and steals the bootstrap code from it.

Disclaimer: this is not an endorsement of using Symfony Console much less the drupalconsole project. It's part of a "revisit before release candidate" issue so that's why I bother.

dawehner’s picture

dawehner
Primary language German
commented

I was looking at at https://github.com/symfony/Console/blob/master/Tester/CommandTester.php but it seems to just add value in case you have complex commands, like ones with input from actual users ... which is out of scope of this particular issue, but you know, we could in the future hide the input of the users from the command line, instead of requiring
the plain text password to appear in the bash history, and then the CommandTester would help ... but for now this looks good to go.

+++ b/core/tests/Drupal/Tests/Core/Console/Command/HashPasswordCommandTest.php
@@ -0,0 +1,45 @@
+
+    $method = new \ReflectionMethod($command, 'execute');
+    $method->setAccessible(TRUE);
+    $method->invoke($command, $input->reveal(), $output->reveal());

Note: The test helper uses ->run() which is a public function but needs a bit more of input first.

chx’s picture

chx commented

Note: I am not working on this issue since #2322877-5: Remove password-hash.sh and rebuild_token_calculator.sh. I offer help, if it's not wanted, no worries.

Status: Needs review » Needs work

The last submitted patch, 7: 2289409_7.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dawehner’s picture

dawehner
Primary language German
commented
Assigned: xano » Unassigned
Status: Needs work » Needs review
StatusFileSize
new interdiff-2289409.txt904 bytes
new 2289409-14.patch7.59 KB

As of symfony 3.x we can get rid of at least one level of indirection. Note: We could get rid of the command itself, but then the command files would no longer be reusable.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
  1. I wonder whether it is worth adding this to the core/scripts/drupal command and adding a base class or a trait to do command bootstrapping as necessary.
  2. +++ b/core/scripts/password-hash.php
diff --git a/core/scripts/password-hash.sh b/core/scripts/password-hash.sh
deleted file mode 100755

deleted file mode 100755
index cf5e9e3824..0000000000

index cf5e9e3824..0000000000
--- a/core/scripts/password-hash.sh

    I think we should deprecate in 8 rather than remove in Drupal 8 

  3. +++ b/core/tests/Drupal/Tests/Core/Console/Command/HashPasswordCommandTest.php
@@ -0,0 +1,45 @@
+/**
+ * @coversDefaultClass \Drupal\Core\Console\Command\HashPasswordCommand
+ * @group Console
+ */
+class HashPasswordCommandTest extends UnitTestCase {

    <3 tests at last!

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 2289409-nr-bot.txt132 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.