Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Quoting @alexpott from #2261477: Remove broken Drupal\system\Tests\ScriptTest:
As much as it pains me to remove these tests they are giving us a false sense of coverage. One issue is that these scripts are totally not multisite compatible which makes them very hard to test because we can't point them properly at the site under test.
So I'm going to commit this and set the issue to active and tag it "revisit before release" so we don;t forget to test these scripts and perhaps come up with a better way.
Comments
Comment #1
sunComment #2
jibranComment #3
jibranComment #4
xjmComment #5
catchThese are dead code at this point without test coverage.
I think we should consider removing them altogether, then add them back with test coverage if we want to. That gives us more flexibility to add them back differently if we want to.
In the meantime, drush is there.
Comment #6
chx CreditAttribution: chx commentedErm, #2289409: Port password-hash.sh to a console command has been submitted earlier today with test coverage. If I get a review or two I will do the other one today as well. It's a piece of cake.
Comment #11
alexpottI don't think we can remove core/scripts/password-hash.sh because it is currently working but maybe we can remove core/scripts/rebuild_token_calculator.sh because that has been broken for a very very long time. See #2356913: Fix rebuild_token_calculator.
Comment #14
apaderno