Add a field to view and edit content's groups

Maybe you could use basic relationship between content and group without activate the gnode submodule.
Then the groups is like a taxonomy. But if you do that, you don't have group content so i think you can't manage the group permissions and roles on this group type and other great features.

Or you can code a custom module that check your fields values when insert or update the node content so you can manage the relationship (group content) between your content and the goup.
For example, you can add a user to a group, it is the same process for the content i think :

function group_user_autocreate_entity_update(Drupal\Core\Entity\EntityInterface $entity) {
  # check the type
  $entity_type_id = $entity->getEntityTypeId();

  switch ($entity_type_id) {
    # is it a user ?
    case 'user':
      $group_main_id = $entity->get('field_group')->getString();

      # get the main group
      $this_group = Group::load($group_main_id);

      # add user to the group, this function already check if user is member of this group
      $this_group->addMember($entity);
      break;
  }
}

Hi Everyone,

I create a patch with a group submodule which provide this functionality, I already tested it in nodes and users.
The submodule requires Inline Entity Form, once enabled you should see a fieldset called "Group Options" in the entity form and it also respect the groups permissions.

Hi,
I've tried the patch in #3 and its adding the expected functionality.

Steps I've followed:
1. Apply patch
2. Enable group, gnode, and the new submodule "gcontent" provided by patch (please note that new submodule has a dependency on inline_entity_form so you will need that module too).

Once the Content and User plugins are enabled for the group type, you I get a new "Group Options" fieldset on the Node add/edit and User add/edit forms. For the User form it correctly adds the new/existing user to the group. For the node add/edit it correclty assigns the node as a Group Content.

Also, If you have fields on the group type > content/user, these fields will be displayed inside the Group Name fieldset.

@jidrone Iván, one tiny thing I've noted is that if you don't have any fields set on the group available content config, you still get the Group Name fieldset but when you expand it is empty. Maybe we can display a message saying something like "This bundle doesn't have any configurable fields".

Thank you for this patch that will greatly simplify the group for my users.

I will test it and I will make a return.

There is the OpenSocial distribution for Drupal 8 which has perfectly integrated this functionality. You can test on this demo site:

https://www.drupal.org/project/social

https://demo.getopensocial.com/

Here is the custom module they created, I did not test it (do not install it in production) :

"zip"

@jidrone I just tested the sub module and it works well.

But there is some missing parameter that is not configurable:

- On my site the group must be required.

- On my site, the content can only be assigned to one group. So you need a selection list instead of autocomplete.

- This relationship with the group must be a field, to customize its position in the node edit form and render in twig.

- The relationship feature should be disabled in the group tab. Currently a user can add nodes in he is not the author to his group and this is a big problem.

See the comment #5

@zenimagine i had a few of the same concerns and @jidrone is I believe refactoring to make this be a true field so you can configure things like Required, move the field around in the UI, perhaps even change the widget. I like auto-complete as the default since a site with lots of groups being all crammed into one select list can cause problems, but having it be configurable would be another benefit of this being a field.

@scotself the example module for open social displays the field with a selection list. This limits the content to a single group.

One could also mention Drupal Commerce with products that contain a store field. It can be configured in autocompletion or selection.

This is very good news if another patch is in development. I can not wait to test it.

Are you planning to disable the relationship tab and link links in groups? There should be the link add nicely.

The relationship feature should be disabled in the group tab. Currently a user can add nodes in he is not the author to his group and this is a big problem.

A better way would be to solve things separately and create new permissions as requested in #2771065: Group Node: Only authors should be able to create Gnodes for their nodes:
- Add own existing content
- Add any existing content

Hi Everyone,

Yes, I'm developing another patch, the following are the improvements and reasons behind each:

Extrafield instead of Field type:
To allow admins to customize its position in the entity edit form, I will provide it as an extra field which will only appear on "manage form display" tab, I prefer that instead of the creation of a new field type because I think it's an overhead to have schema, storage and display functionality we won't use.

Configurable settings by Content Plugin:
Currently the group module has this form "admin/group/settings", which only have the option "Use admin theme". I will use this form to add some configurations for the field like: required, allow multiple, widget: select or autocomplete.

Permission to access to the field:
I'm adding a permission to access to the field, especially useful if you want to avoid anonymous user to see it in registration form.

I agree with @dalra to manage all the access related things with permissions, because this patch takes care of groups permissions.

@jidrone It's awesome.

Can the field appear in the display ?

In the twig of my nodes, I want to display a link or rendered entity to the parent group.

Here is an example :

- In the screenshot of my product, I added above the dotted line the parent store. Drupal Commerce adds a field in the display of my product.

- In the screenshot of my article, I added the parent group above the dashed line. But I have to use views and EVA to get that (it's complicated). Adding a group field to the node view will be much simpler.

Hi @zenimagine,

I was thinking about your last request, in case we need to provide a display for the field is best to create a field type to have formatter settings to choose a view mode for the group.

So the following could be a possible approach:

• Change the submodule name to 'gcontent_field' and label to "Group Content Field" to be more related about what module does.
• Create a field type which will store the group_content_id.
• Create 2 widgets for the field: select and autocomplete.
• Create 2 formatter for the field: rendered entity and rendered_group.

@jidrone It seems to me very good.
Have you watched how the Open Social custom module works?
It could perhaps serve as a basis.

Create 2 widgets for the field: select and autocomplete.

Sounds great!
There also needs to be an option to remove the content from the group.
In the select it could be a None option and maybe a checkbox next to the autocomplete field.

@jidrone the module should verify that the user has already created a group before creating a new node.

If the user does not have a group and tries to create a node, you must display the group creation form with a message:

"You need to create a group to be able to create content"

Deleted

@dalra It would be nice to have an option to make it mandatory.

On my site, a user can not create a node if he does not have a group.

Maybe in the field parameter it would be interesting to add this option.

From what I understand, there is quite a bit of the functionality that is being discussed here in this patch: https://www.drupal.org/project/group/issues/2718195#comment-12869526 Marking the issue as related.

This patch introduces a pseudo field which makes it possible to:
- Show which group a node is in on node form and view
- Add/remove groups through the node form (either limited to a specific group type or any group)

Especially the add/remove functionality might not be obvious from the issue title...

Hi Everyone,

Finally I finished a patch with the field approach, I created a widget for the entity reference field called "Group Selector" and a Formatter called "Parent Group Entity".

When you initially configure the field is needed to synchronize it to add the values for existing group content, for that reason I created an option in the field to do that.

You only need to check it the first time, for that reason the default value is unchecked.

It's important to select the Group Content as referenced entity in the field to see this option.

I decided to continue this patch because the solution from #2718195: Add a computed field for entity's group(s), does not cover the purpose of this issue.

IMPORTANT: If you used the previous patch, first uninstall the gcontent module, before to apply this.

@jidrone Thank you, I will test the patch on Monday

I forgot to mention that I needed this patch #2939432: Make sure path has a value before calling purge in pathauto_entity_delete() for pathauto.

@jidrone I applied the patch, but did not understand how it works.

There is no group field in the content.

Hi @zenimagine,

This new patch works as a widget for an entity reference field, so the steps to make it work are the following:

• Go to "Manage Fields" for the content type do you want to add in groups.
• Add a new field of type Reference > Other.
• For the option "Type of item to reference" select Content > Group Content.
• The option "Allowed number of values" depends on your expected behaviour.
• On the next screen select all the group content bundles needed in "REFERENCE TYPE", I'm planning to do an improvement to set them as default value.
• Go to "Manage Form Display" and select the widget "Group Selector" for the field you just created.
• To show the group in the node display, go to "Manage Display" and select "Parent Group" as format the field.

@jidrone I encounter some problem with the patch, when I edit my node, I have a php error :

Error: Call to undefined method Drupal\gcontent_field\Plugin\Field\FieldWidget\GroupSelectorWidget::buildSelectAddMode() in Drupal\gcontent_field\Plugin\Field\FieldWidget\GroupSelectorWidget->buildAddActions() (line 788 of /var/www/www-domaine-com/web/modules/contrib/group/modules/gcontent_field/src/Plugin/Field/FieldWidget/GroupSelectorWidget.php) #0 /var/www/www-domaine-com/web/modules/contrib/group/modules/gcontent_field/src/Plugin/Field/FieldWidget/GroupSelectorWidget.php(702): Drupal\gcontent_field\Plugin\Field\FieldWidget\GroupSelectorWidget->buildAddActions(Array, 'group_node:arti...') #1 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Field/WidgetBase.php(104): Drupal\gcontent_field\Plugin\Field\FieldWidget\GroupSelectorWidget->formMultipleElements(Object(Drupal\Core\Field\EntityReferenceFieldItemList), Array, Object(Drupal\Core\Form\FormState)) #2 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Field/FieldItemList.php(287): Drupal\Core\Field\WidgetBase->form(Object(Drupal\Core\Field\EntityReferenceFieldItemList), Array, Object(Drupal\Core\Form\FormState)) #3 /var/www/www-domaine-com/web/core/modules/field_ui/src/Form/FieldConfigEditForm.php(99): Drupal\Core\Field\FieldItemList->defaultValuesForm(Array, Object(Drupal\Core\Form\FormState)) #4 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Entity/EntityForm.php(117): Drupal\field_ui\Form\FieldConfigEditForm->form(Array, Object(Drupal\Core\Form\FormState)) #5 [internal function]: Drupal\Core\Entity\EntityForm->buildForm(Array, Object(Drupal\Core\Form\FormState)) #6 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Form/FormBuilder.php(518): call_user_func_array(Array, Array) #7 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Form/FormBuilder.php(275): Drupal\Core\Form\FormBuilder->retrieveForm('field_config_ed...', Object(Drupal\Core\Form\FormState)) #8 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Controller/FormController.php(93): Drupal\Core\Form\FormBuilder->buildForm('field_config_ed...', Object(Drupal\Core\Form\FormState)) #9 [internal function]: Drupal\Core\Controller\FormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch)) #10 /var/www/www-domaine-com/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array) #11 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Render/Renderer.php(582): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #12 /var/www/www-domaine-com/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure)) #13 /var/www/www-domaine-com/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) #14 /var/www/www-domaine-com/vendor/symfony/http-kernel/HttpKernel.php(151): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #15 /var/www/www-domaine-com/vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) #16 /var/www/www-domaine-com/web/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #17 /var/www/www-domaine-com/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #18 /var/www/www-domaine-com/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(99): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #19 /var/www/www-domaine-com/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(78): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true) #20 /var/www/www-domaine-com/web/core/modules/ban/src/BanMiddleware.php(50): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #21 /var/www/www-domaine-com/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\ban\BanMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #22 /var/www/www-domaine-com/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(52): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #23 /var/www/www-domaine-com/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #24 /var/www/www-domaine-com/web/core/lib/Drupal/Core/DrupalKernel.php(669): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #25 /var/www/www-domaine-com/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #26 {main}.

Will not it be simpler than the module created a lock field ?

Autocomplete works, but the selection list shows the problem above.

Autocomplete displays the relationship content. Groups must be displayed. The name of the relationship is truncated

@jidrone "Widget: select" does not work on my site.

"Widget: autocomplete" works, but it does not display the group name.
In the autocompletion list, there is the name of the group, but when selected, it displays the name of the relationship.
If I change my knot how to know the group ?

Hi @zenimagine,

Thank you for all your testing, I will do the following changes in next patch:

• Fix select widget.
• Show Group Name first instead of Group content type when relation is added.

@jidrone Can the sub module directly create a lock field during installation ?

@jidrone A feature could be very interesting:

If the user does not have a group, when they create a node they should display a message (you must create a group to publish content) and the group creation form.

Here is the patch with the following fixes and improvements:

• Fix select widget.
• Show Group Name first instead of Group content type when relation is added.
• Respect entity cardinality.

I'm analyzing the possibility to create groups, maybe it could be an improvement in the future if the maintainer thinks the patch is useful.

I'm analyzing the possibility to create groups, maybe it could be an improvement in the future if the maintainer thinks the patch is useful.

Depending on your use casees (you might have others than we have ;) you might find group_behavior useful. It adds a group on node creation for a given content type (via content plugins), there is also groupmediaplus to automatically add media to the nodes group. Sorry for misusing your issue queue, I just wanted to mention it ....

Another small fix for the plugin entity cardinality.

@jidrone Should I uninstall the sub module before applying the patch?

@jidrone I uninstalled the sub module and reinstalled it again.

I did a quick test:

1) In "Manage View" node, the field does not list any rendered entities. View screenshots Capture d’écran du 2018-12-13 12-02-19.png and Capture d’écran du 2018-12-13 12-01-44.png

2) When the group is selected, the label of the field disappears. View screenshots Capture d’écran du 2018-12-13 11-51-08.png and Capture d’écran du 2018-12-13 11-51-25.png

3) Why not create a real selection list as in Drupal Commerce for the store selection for the product. Groups should be listed by type of group. View screenshots Capture d’écran du 2018-12-13 12-04-32.png

4) In the group name ' are replaced by '

Hi @zenimagine,

I fixed the things in comment #39, except the 4 because I didn't understand, is not needed to reinstall the module.

@jidrone Thank you, it works much better.
In 4 I mean that ' are replaced by '

I will continue to test it, but is it essential to have the button "Add group"?
A simple pick list when the field and limited to a single pick will require less manipulation. See the screenshots, for example the "Language" field.

1) One choice

2) Many choices

One more thing, I have the module https://www.drupal.org/project/message
When I use the token of the group field to display a link to the parent group of the node, this displays the relationship entity with the node.

Normally I should have the name and link of the parent group

Hi @zenimagine,

In this patch I fixed the ' replaced by '

The "Add Group" button is really needed for the ajax functionality in the field items and regarding the token you can follow this great article about how to do it https://www.flocondetoile.fr/blog/token-and-chained-entities-drupal-8

@jidrone 884/5000
Thanks for the patch, it works.
The character problem is fixed.
I managed to find the right token, with your link.

Just one or two things that may need to be reviewed:

1) in the screenshot Capture d’écran du 2018-12-14 19-53-27.png when I add a group to the content, this is well presented.

2) in the screenshot Capture d’écran du 2018 12 14 19 52 33.png when I change the group of a content, this is poorly presented. The design is not suitable for the smartphone, I think the "Edit" button and the title of the relationship should not be displayed.

3) since this sub-module manages the relations between the groups and the nodes directly on the editing page of the node. Why the module does not prohibit access to the page (this page may be of interest to the site administrator, but not to the group administrator) :
/group/ID/content
and the "Associate Content" and "Add Content" buttons on :
/group/ID/nodes

4) with you take a look at the demonstration of open social? try to add content, a selection list is available for groups. But I am not a programmer.

5) There are also chips that appear next to the button. I do not know if this is related to Bootstrap

Huh, we have 3 issues with roughly the same scope:
* (this one) #2813405: Add a field to view and edit content's groups
* #2718195: Add a computed field for entity's group(s)
* #2774533: Better UI for adding content to multiple groups

Let's try to sort this out and consolidate. I'll start with the easiest:
* #2774533: Better UI for adding content to multiple groups - this code looks like included in both other issues so tentatively closing as dup.
* (this one) #2813405: Add a field to view and edit content's groups - I did not test this patch, but code-wise it looks well elaborated. chapeau! alas, it suffers from a denormalized design to take a entityreference field and sync it to group relation.
* #2718195: Add a computed field for entity's group(s) - a computed field that has no storage and loads and stores from group relation.

I'd suggest to consolidate the patches by replacing this patch's field syncing with the other patches much cleaner computed field approach.
(Of course YMMV and we can query a maintainer verdict about that)

Hi @axel.rutz,

I didn't test the #2718195: Add a computed field for entity's group(s), does it allow to add the content to the group from the entities form?.

I'm asking because this patch allows all View, Add, Edit and Remove.

> I'm asking because this patch allows all View, Add, Edit and Remove.

Yes, it does. I mentioned that earlier. What exactly do you mean by edit? Do you mean the group relation? I'm not sure if this can/should be done in the field widget... Apart from that you can View, Add and Remove with the other patch.

I'm testing #2718195: Add a computed field for entity's group(s), to see if we can replace the field syncing as @axel.rutz propose.

This new patch includes the suggestion from @axel.rutz, instead of syncing field storage, it creates a computed field called "Group content" ready to use on entities from Group Content Plugins.

Thanks @axel.rutz.

@jidrone Thank you, the sub module is already installed on my site. To update to the new patch, should you uninstall your module? Thank you

Hi @zenimagine,

You don't need to uninstall, just rebuild cache and this time the field will appear automatically, so you don't need to create it.

@jidrone Currently I have created fields for the previous patch. It is no longer useful ?

Hi @zenimagine,

They are no longer useful, because they depends on field storage and previous syncing functionality, I recommend you to use the new one.

@jidrone Thank you, the patch works. But I see 2 problems:

- the rendered entities of the group do not correspond to the displays of the group type.

- it is not possible to limit the relation to a single group (single selection).

@jidrone When I turn on the group in the node type view, it displays the name of the relationship. You must display the name of the group.

The field should also be required

If the field is not configurable, maybe the solution would be to add parameters for the group in edit the node type

Hi @zenimagine,

I added those options to the widget, the default values are Multiple: Yes and Required No.

Regarding the view modes for the groups, the default formatter is rendered entity, but the entity type being referenced is the group content, to show the group you will need to select "Parent Group Entity" as formatter in Manage Display.

@jidrone Super thank you, it works. It misses the label of the field, once it is selected

Would it be possible to customize the label of the field "Group content" in the widget?

I think only the name of the group should be displayed. The name of the relationship of the content is not useful

The group field in the node edit form for the multivalue is more convenient in the patch below.

With your last patch and the changes you've made, maybe it's possible to create the same rendering for multiple values. As well as a simple list for a single value.

https://www.drupal.org/project/group/issues/2718195

Hi @zenimagine,

The reason why I don't follow that approach is because in the patch you mentioned is only posible to reference the group, so is not possible to set any custom fields you have configured for the content plugin and other important case is for users is not possible to assign them a group role.

The field from this patch references the group content which makes more sense and also allow you to completely admin the group content relation, for this reason is needed the ajax behavior and the "Add to group" button.

This patch fixes the field label hidden when group is selected and also removes the group content bundle label.

To replace the field label I think it can be done using hook_entity_bundle_field_info_alter, I also removed the inline_entity_form dependency because from patch in comment #22 it's not needed but I forgot to remove it.

@jidrone Thank you, the label is correctly displayed.

When I click on the "Remove" button, it is the name of the group content that appears in place of the group name.

I can no longer display the token with the "Message" module.

<a href='[message:field_node_reference:entity:group_content:entity:group:url]'>[message:field_node_reference:entity:group_content:entity:group:title]</a>

With the field created manually, it will work. Now the code above does not display the group.

Hi @zemagine,

I fixed the name of the group when removing, but the token I think is related with #2794343: Programatically defined fields for custom content entities are not available as tokens in Pathauto from token module.

@jidrone Thank you, the name of the group is now fixed.

But the open problem for the chips, has been closed and does not fix the problem.

It would be nice to add a token to the module to display the parent group of a node.

Is it normal for the button to use ul and li ?

Hi @zenimagine,

I added support for token and yes it is normal to see the button as ul and li because it is a dropbutton, in the admin theme it looks good, so you can check how the theme "Seven" does.

@jidrone Perfect, the token works. Regarding the chips on the buttons, I think there is a problem with the Bootstrap theme. This problem only appears with this module. On the rest of the site, the drop-down buttons are correctly displayed.

Here are some idea of ​​features to add:

- On the page "/admin/content" it would be nice if the module Group adds a column with the parent groups of the nodes. Mass operations could also be added "Add nodes to groups" and "Delete nodes from groups".

- When this sub module is installed, I think it should disable the page "/group/ID/content", which is very confusing for the user. On the "/group/ID/nodes" page, the "Add new content" and "Add existing content" buttons should also be disabled.

- A check should be made when the user creates a node. View a message, if it does not have a group yet "Before creating a content, you must create a group (group creation link)".

- The group content field is limited to groups created by the user, that's fine. But the site administrator should have access to the complete list of groups.

- Maybe this is a problem of my site, but the "Edit" button in the "Group Content" field on the node edit page does not work.

That's it for now. Thank you for your work.

Is it normal that the field is also on the user account ?

Hi @zenimagine,

Here are my thoughts:

"/admin/content" column parent groups:
I think that is a great suggestion but it is out of the scope of this issue, I suggest to create a new issue for that.

Disable "/group/ID/content":
This field added by this patch should be an additional functionality, for that reason I don't like the idea to disable core functionalities of group module because both can coexist and can be useful depending of your site roles and group contents administration scenarios.

Group creation link:
I can add a link to create a group if the user has the permissions and there are no available groups.

Access to groups:
This module check the permissions of groups for all the operations and for the list of available groups, so the super admin user should be able to do anything, please check the group types permission and help me to test.

Edit button:
For me it works, maybe other users on this issue queue can test it.

Field on user entity type:
Yes it's ok to see the field on users, that is because this submodule detects all the fieldable entity types which have support for group module via GroupContentEnabler plugin type, the group module adds the "group_membership" for users (this patch allow to create users and add them to groups) and the gnode submodule adds the "group_node" for nodes.
It means if you or someone else add support to other fieldable entity type for group, then the field "group_content" will be available on the entity form.

@jidrone The work you've done here on a computed reverse reference field, and especially on the corresponding widget, is great. I can see many use cases for this outside of group too. How much work do you think it would be to generalise it into its own contrib module that could be used with any entity reference field; the Group module could then have an optional dependency on this new contrib module.

If you research this, please consider the functionality of the cer module.

Hi @jonathanshaw,

I think the formatter I created in this patch is totally intended to be use with groups, then if the module proposed by @maxilein does not provide a generalized way to do this maybe we can help on that module or create a new contrib.

@jidrone Hi, when I try to add a group, it does not work and I have an error :

Emplacement https://www.domaine.com/fr/node/243/edit?_wrapper_format=drupal_ajax&aja...
Référent https://www.domaine.com/fr/node/243/edit

Error: Call to a member function getContentPlugin() on null in Drupal\gcontent_field\Plugin\Field\FieldWidget\GroupSelectorWidget->formMultipleElements() (line 711 of /var/www/www-domaine-com/web/modules/contrib/group/modules/gcontent_field/src/Plugin/Field/FieldWidget/GroupSelectorWidget.php) #0 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Field/WidgetBase.php(104): Drupal\gcontent_field\Plugin\Field\FieldWidget\GroupSelectorWidget->formMultipleElements(Object(Drupal\gcontent_field\Field\GcontentFieldItemList), Array, Object(Drupal\Core\Form\FormState)) #1 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Entity/Entity/EntityFormDisplay.php(171): Drupal\Core\Field\WidgetBase->form(Object(Drupal\gcontent_field\Field\GcontentFieldItemList), Array, Object(Drupal\Core\Form\FormState)) #2 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Entity/ContentEntityForm.php(125): Drupal\Core\Entity\Entity\EntityFormDisplay->buildForm(Object(Drupal\node\Entity\Node), Array, Object(Drupal\Core\Form\FormState)) #3 /var/www/www-domaine-com/web/core/modules/node/src/NodeForm.php(115): Drupal\Core\Entity\ContentEntityForm->form(Array, Object(Drupal\Core\Form\FormState)) #4 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Entity/EntityForm.php(117): Drupal\node\NodeForm->form(Array, Object(Drupal\Core\Form\FormState)) #5 [internal function]: Drupal\Core\Entity\EntityForm->buildForm(Array, Object(Drupal\Core\Form\FormState)) #6 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Form/FormBuilder.php(518): call_user_func_array(Array, Array) #7 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Form/FormBuilder.php(368): Drupal\Core\Form\FormBuilder->retrieveForm('node_partenaire...', Object(Drupal\Core\Form\FormState)) #8 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Form/FormBuilder.php(625): Drupal\Core\Form\FormBuilder->rebuildForm('node_partenaire...', Object(Drupal\Core\Form\FormState), Array) #9 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Form/FormBuilder.php(318): Drupal\Core\Form\FormBuilder->processForm('node_partenaire...', Array, Object(Drupal\Core\Form\FormState)) #10 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Controller/FormController.php(93): Drupal\Core\Form\FormBuilder->buildForm('node_partenaire...', Object(Drupal\Core\Form\FormState)) #11 [internal function]: Drupal\Core\Controller\FormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch)) #12 /var/www/www-domaine-com/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array) #13 /var/www/www-domaine-com/web/core/lib/Drupal/Core/Render/Renderer.php(582): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #14 /var/www/www-domaine-com/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure)) #15 /var/www/www-domaine-com/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) #16 /var/www/www-domaine-com/vendor/symfony/http-kernel/HttpKernel.php(151): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #17 /var/www/www-domaine-com/vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) #18 /var/www/www-domaine-com/web/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #19 /var/www/www-domaine-com/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #20 /var/www/www-domaine-com/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(99): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #21 /var/www/www-domaine-com/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(78): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true) #22 /var/www/www-domaine-com/web/core/modules/ban/src/BanMiddleware.php(50): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #23 /var/www/www-domaine-com/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\ban\BanMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #24 /var/www/www-domaine-com/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(52): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #25 /var/www/www-domaine-com/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #26 /var/www/www-domaine-com/web/core/lib/Drupal/Core/DrupalKernel.php(693): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #27 /var/www/www-domaine-com/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #28 {main}.

Hi @zenimagine,

I was testing but I couldn't reproduce that error.

@jidrone This problem only appears with the site administrator. For the user to work

I couldn't reproduce the error with different scenarios.
This patch only improves the access to field when editing own user account and the message when reached entity cardinality.

Small usability improvement, the relation field gets cleared after new relation is added.

@jidrone Thank you, I tested the patch and I still have the same error. I do not know where it comes from.

@jidrone When I open the ajax link, I have the message below, but I do not understand what it means :

[{"command":"insert","method":"prepend","selector":null,"data":" \u003Cdiv role=\u0022contentinfo\u0022 aria-label=\u0022Error message\u0022 class=\u0022messages messages--error\u0022\u003E\n \u003Cdiv role=\u0022alert\u0022\u003E\n \u003Ch2 class=\u0022visually-hidden\u0022\u003EError message\u003C\/h2\u003E\n An unrecoverable error occurred. The uploaded file likely exceeded the maximum file size (24 MB) that this server supports.\n \u003C\/div\u003E\n \u003C\/div\u003E\n ","settings":null}]

@jidrone Have you tested the module with several types of groups?

With one type of group it works, but with the others, I have this error and nothing happens.

@jidrone I asked the question on stackexchange and a user replied :

In your gcontent_field module, you're calling ->getContentPlugin() in the Drupal\gcontent_field\Plugin\Field\FieldWidget\GroupSelectorWidget->formMultipleElements() method.

You're assuming that you're calling the method on an object, but for some reason, the object is not there so you're getting NULL. You should do a check on the object to see if the object is actually an object. Maybe, use is_a() or gettype() functions to confirm your variable type before calling the getContentPlugin() method? Or see why the object is not being passed to your method correctly?

Hi @zenimagine,

Try this small change.

@jidrone I will test that. Have you managed to reproduce the problem ?

@jidrone I applied the patch, but that does not solve the problem.

With one type of group it works, but not with the other type of group.

Thanks for all the work here so far! This is getting close to a very useful feature.

In addition to the unresolved bug from #77 through #89, I'm setting to needs work for a few more things:

1. There's no obvious way to change the "Group content" label. Yes, I could form alter the widget and entity_view_alter to fix the display, but wow that's a lot of work. I know this is a "magic" field that appears automatically, but it'd be great if it also appeared on 'manage fields' in some way, at least to let you change the name/label.

Eventually it could support other goodies that normally appear at manage fields, like required, default value, etc., but that might get too complicated and should probably be a follow-up issue.

2. We should also consider if "Group content" makes sense as the default label for this, regardless of if you can easily customize it. It's really "Groups this content belongs to" or even just "Groups" (in the context of a field on site content). If I'm looking at, say, an event that can belong to multiple groups, the things this field shows me are the groups the event belongs to. The event is the "group content", and this field is really pointing to the groups themselves.

3. It'd be better if once you enable this, a site builder gets to turn it *on* on the 'Manage form display' page for any entity types that make sense, instead of having to manually turn it off everywhere it doesn't.

4. If I login as a group admin, the help text needs help:

Group content
No added yet to groups.
[ ]
Type a group
(Add to Group)

"Group content" should be configurable (see #1 above).

a. "No added yet to groups.:"

Should be: "Not yet added to groups." or even "Not in any groups."

b. "Type a group"

This is a (not very helpful) description, but the form element it describes has no label (making this an accessibility bug). I think there should be a "Group name" label, then you don't need the description at all. The call-to-action remains "Add to Group".

5. If you press "Add to Group" without typing a group name, nothing happens, no error or warning is generated.

6. If the content does not yet belong to any groups, and you type an invalid name and try to "Add to Group", the name is marked red, but there's no other error message:

We need to display the form validation error messages in this case.

7. If you successfully add the content to a group, then try again with something invalid, you now see an error message, but it's generic and not very user-facing-friendly:

There are no entities matching "dww".

Should be something like: There are no groups named "%group_name".

8. If I login as a user that belongs to a few groups, but doesn't have permission to post anything to those groups, and I try to create content that *could* be associated with a group (but not by me), I get the following error message:

If the current user doesn't have permission to add content to a group, the widget should hide those aspects completely, and only show current group memberships in a read-only listing.

9. Configuring display is clumsy. If I use 'label', I get the label of the association between the content and each group. This always duplicates the name of the content itself, and as a site-builder or end user, it just seems like a bug. If I choose "entity ID" I see that they're unique entities, even though the labels are equivalent. If I use 'rendered entity' I get the full rendered entity of the association of the content and each group, again, totally useless for me to see as an end user. The only option that actually makes any sense here is "Parent group entity", but then I'm forced to use a view mode to render the full entity. At this point, I have to add a new 'Name-only' view mode of group entities, then come back to configure the display of every content type on my site to click a few different times on each of these 'Group content' field formatters. :(

I can't imagine a scenario where you want to see the group-association entities with this formatter. Why doesn't it immediately assume you're talking about the parent group, and then retain the options for label-only (with and without a link to the group entity itself), id, or a full rendered entity? Or if there's a reasonable use-case for seeing the group-content-association entities, make that the special case that requires more clicks.

10. It'd be great to have some functional tests for all these cases. Stretch goal. ;) I leave it to the maintainers to decide if this is a requirement.

Hi Everyone,

Here is the new patch with some improvements suggested in #90:

1. Field label now is customizable from "admin/group/settings".
2. Default field label now is "Groups".
3. That is a good suggestion, I tried to do that following the right process, but it didn't work, maybe there is a core issue for base fields added via hook_entity_base_field_info or computed fields, I will need to investigate more.
4. Added group field label and text improvements.
5. Added validation when empty field, I suggest to enable Inline Form Errors module for better UX.
6. Improved validation messages.
7. I suggest to enable Inline Form Errors module for better UX.
8. Improved message when user doesn't have permission.
9. The field on this patch is referencing the group content entity instead of group, it is especially useful for example in user membership, because it gives the possibility to configure the group roles.
   Then you can set the formatter as referenced entity and show a summary of user membership.
   By default the field is hidden from display and with the mentioned scenario I think is better not to assume the field formatter as parent group
10. Yes, maybe we will need some tests

Moved to needs review, it didn't pass the PHP5 tests because it uses php ternary null coalescing added in PHP7, but I think it is not a blocker because php 5 support will end soon.

Jup: Drupal 8 will require PHP 7 starting March 6, 2019 (one year from now); PHP 7.1+ recommended | Drupal Groups

@jidrone thank you for this update.
However there is some detail to settle.

No label is set by default, so only the required field star appears if I do not customize the label.

I noticed that users tend to select a group and save the content without clicking the "Add a group" button. The content shows a wander in the form but it is not obvious to them.

I am receiving the same error as @zenimagine in #77 with latest patch and as Administrator.

I would also echo @zenimagine's comment in #95 regarding the "Add to Group" button. Ideally, the groups would just be connected upon saving the actual piece of content, eliminating the extra step.

Thank you for your work on this @jidrone! I will see if I can dig in and contribute anything.

I believe the reason for the "Add to Group" step is a data integrity issue: so that required fields aren't left empty on the Relationship entity. For instance, for Group Membership plugin you likely will have to fill out the Group Membership entity (group roles field to fill out, along with any other custom membership entity fields in order for the "groups to just be connected". I suppose if the 2-step wizard is disabled for a plugin, maybe then you could safely skip that step, since the configuration is such that this step is skipped when creating the Relationship entity directly (rather than via the related entity's form via this new field widget). Hope that makes sense...

@scotself good point about having additional fields on the Relationship entity. I wasn't thinking about that because 1) I don't yet have any need to add fields on the Relationship entity, and 2) I can't get this patch to work to even see what the UX flow looks like in terms of filling such fields when adding new groups to a piece of content.

I created a new patch based of the one in #45 here: https://www.drupal.org/project/group/issues/2718195#comment-12869526

What I liked about that code is that it inherently supports any display widgets that an EntityReference field supports, and it doesn't require the additional "Add to Group" step. (However, I hadn't considered the additional Relationship fields @scotself mentioned in #97 - I'm not sure how those would be handled.)

Anyway, I took that patch as a starting point and leveraged some of @jidrone's logic to restrict group relationship addition/removal based on the appropriate permissions. I also added logic such that the computed field is only added to content types that are enabled for one or more groups.

Perhaps this may be useful to someone!

So the current patch is #91 and #99 is a case study based on old #45? Wouldn't it be good to improve #91?

Hi everyone, I will work on this again on next week.

@jidrone Maybe you could find help here https://www.drupal.org/project/gnode_field

Re: @zenimagine #103: how could we possibly know? ;) There's no description on the project page. I cloned the repo and there's no README or anything. I looked in gnode_field_help() and found only this:

$output .= '<p>' . t('Functionality as it relates to groups on the site.')

I have no idea WTF that module is for. ;) Hah, just found #3033566: Hi, what is this module for ? ;)

Oh, at least gnode_field.info.yml has this:
description: Add groups directly from the node form.
Guess I should have looked there before hook_help. Oh well...

Anyway, yeah, it seems quite overlapping. Would be great to merge efforts if possible, get this functionality working here and deprecate that project so we don't end up with splintered/forked modules for the same feature.

Thanks for the pointer!
-Derek

@axel.rutz #2718195-45: Add a computed field for entity's group(s) was a better starting point for me because it worked / produced no errors, allowed me to use any entity reference widget (in my case I want to use a checkbox list), eliminated the extra "Add to Group" step, and was comparatively simpler code. That may be an older patch and a closed issue, but it's still valuable work.

Per the issue of a group content entity allowing additional fields, I feel like this would be best handled with the optional 2-step wizard. On the content edit screen you'd select the groups you want, then, based on the selected groups, show the group content form for each selected group (IF the wizard is enabled - for instances where the group content entity has no additional fields, you just disable the wizard to eliminate this step). Not sure how your patch handles it @jidrone, but I think this would be the most flexible and ideal UX.

@balbuf

#2718195-45: Add a computed field for entity's group(s) was a better starting point for me because it worked / produced no errors, allowed me to use any entity reference widget (in my case I want to use a checkbox list), eliminated the extra "Add to Group" step, and was comparatively simpler code. That may be an older patch and a closed issue, but it's still valuable work.

Would your patch allow for a radio button list of groups to be displayed on an article?
In the article node, I would like to allow users to choose a group from a radio list and click save.
This would add an article to a group with just 2 clicks.

Also, I would like the content to be in just one group (Public or Private).
If the content is already in the Public group and the user adds it to the Private group, the content needs to removed from the Public group.

Would that be possible with your patch?
Thank you

I have applied patch #91, but cannot enable 'gcontent_field' module, as it is complaining about my Entity module version:

Entity (>=8.x-1.0-rc1) (incompatible with version )

I have tried with both 1.0-rc1 and 1.0-dev version of Entity, without success.

EDIT: I could enable the module via Drupal Consol.

#107:
> Entity (>=8.x-1.0-rc1)

i do not see that line in the patch. Alas, if it's in a info.yml file, it should read:

> Entity (>=1.0-rc1)

Testing #91, some remarks:
1. The Group selection on node/add forms needs the "Relationship: Add entity relation" permission, although the "Entity: Add content entities" permission should suffice
2. If the user does not have the permission to remove a relation, he cannot change the group again. This seems to be a bit strict, since the node does not exists yet
3. It only works with the default group type, not with any custom group type. There I'm getting a similar error as #77:

Error: Call to a member function getContentPlugin() on null in Drupal\group\Entity\GroupContent->getContentPlugin() (line 102 of /var/www/html/web/modules/contrib/group/src/Entity/GroupContent.php)

#0 /var/www/html/web/modules/contrib/group/modules/gcontent_field/src/Plugin/Field/FieldWidget/GroupSelectorWidget.php(1122): Drupal\group\Entity\GroupContent->getContentPlugin()
#1 /var/www/html/web/modules/contrib/group/modules/gcontent_field/src/Plugin/Field/FieldWidget/GroupSelectorWidget.php(703): Drupal\gcontent_field\Plugin\Field\FieldWidget\GroupSelectorWidget->getAllowedGroups(Array, 'group_node:arti...', Array)
#2 /var/www/html/web/core/lib/Drupal/Core/Field/WidgetBase.php(104): Drupal\gcontent_field\Plugin\Field\FieldWidget\GroupSelectorWidget->formMultipleElements(Object(Drupal\gcontent_field\Field\GcontentFieldItemList), Array, Object(Drupal\Core\Form\FormState))
#3 /var/www/html/web/core/lib/Drupal/Core/Entity/Entity/EntityFormDisplay.php(171): Drupal\Core\Field\WidgetBase->form(Object(Drupal\gcontent_field\Field\GcontentFieldItemList), Array, Object(Drupal\Core\Form\FormState))
#4 /var/www/html/web/core/lib/Drupal/Core/Entity/ContentEntityForm.php(125): Drupal\Core\Entity\Entity\EntityFormDisplay->buildForm(Object(Drupal\node\Entity\Node), Array, Object(Drupal\Core\Form\FormState))
#5 /var/www/html/web/core/modules/node/src/NodeForm.php(115): Drupal\Core\Entity\ContentEntityForm->form(Array, Object(Drupal\Core\Form\FormState))

Hello, I've found the patch from https://www.drupal.org/project/group/issues/2718195 in Open Social, now I need to implement a similar thing and I wonder: what patch should I use here to be "future=proof"?

I see two completely different approaches and I fear that choosing the wrong one will cause issues on the long run, so just wondering what's the general opinion here for the future.

We've now got 3 possible options:

1. #91
2. #2718195-45: Add a computed field for entity's group(s)
3. https://www.drupal.org/project/gnode_field

Fun. ;)

• I reviewed / tested #87 (see #90), but I haven't reviewed #91 yet.
• Only briefly looked at #2718195.
• Barely looked at gnode_field.

I can't give any recommendation on the "future-proof" choice. :(

Would love to get everyone into a shared conversation about it. Not sure if this issue is the best place for that. #d8-group in Drupal Slack? DrupalCon bof with a remote option (Zoom, Slack, etc?). I'm not yet clear who "everyone" means. :/

@kristiaanvandeneynde group maintainer
@scottalan from gnode_field
@jidrone from #91
@joachim, @axel.rutz, @modestmoes, @recrit, @realityloop, @adammalone et al from #2718195
... ?

Thoughts on how to proceed?

Thanks!
-Derek

p.s. Opened #3045046: Consider merging this into group module? to ping @alanscott as the maintainer of gnode_field.

@dww,

Derek, thanks for bringing this up so we can sort out this whole mess.

* Looked into https://www.drupal.org/project/gnode_field. That module uses a form_alter approach that i'd strongly discourage.
* My comments from #46 still apply so i'd strongly advise going with #91 and not the closed issue

Also, until drupal.org supports a branch-per-issue, someone(tm) might open a sandbox and invite everyone here.
With a complex patch like this one this might really help. (Just my 2 cents, i don't think i can put much bandwidth in here.)

+++ b/modules/gcontent_field/gcontent_field.module
@@ -0,0 +1,77 @@
+  if ($entity_types = gcontent_field_get_entity_types()) {

Isn't this going to be circular?

Clarifiing current patch (which the last question correctly refers to).

FWIW, we're using #91 in a project for the last couple months and haven't had any issues thus far.

> FWIW, we're using #91 in a project for the last couple months and haven't had any issues thus far.

OK, setting this to RTBC to bug @kristiaanvandeneynde and get his review on this.
It would be really nice if we get this in soon and move forther improvements into a followup.

Setting back to Needs work, for #91 we have some comments in #90 which have not been addressed and #109:

Does not work for any other group type than the default group type mentioned in #85 and #109

Some points from #90 not yet addressed, such as

9. Configuring display is clumsy. [...] The only option that actually makes any sense here is "Parent group entity", but then I'm forced to use a view mode to render the full entity. At this point, I have to add a new 'Name-only' view mode of group entities, then come back to configure the display of every content type on my site to click a few different times on each of these 'Group content' field formatters. :(

I can't imagine a scenario where you want to see the group-association entities with this formatter. Why doesn't it immediately assume you're talking about the parent group, and then retain the options for label-only (with and without a link to the group entity itself), id, or a full rendered entity? Or if there's a reasonable use-case for seeing the group-content-association entities, make that the special case that requires more clicks.

Please see #90 (#91 for what has been taken care of) and #109

Also, I would add, that the form widget is also clumsy and missleading. On default autocomplete is enabled which let's you select a list of all content. The custom widget "Group Selector" is what you want. I hoped there is a more standard way to use existing widgets and formatters...

Glad to see this moving forward. Yes, needs work. :) I started reviewing #91. Agreed that there are still a number of items from #90 not yet addressed. Also found these:

1. --- /dev/null
   +++ b/modules/gcontent_field/config/install/gcontent_field.settings.yml
   
   +++ b/modules/gcontent_field/config/install/gcontent_field.settings.yml
   @@ -0,0 +1,2 @@
   
   @@ -0,0 +1,2 @@
   +entity_field_label:
   +  user: 'Group Memberships'
   \ No newline at end of file
   

   No newline

2. +++ b/modules/gcontent_field/gcontent_field.info.yml
   @@ -0,0 +1,8 @@
   +description: 'Provide a new field which allows you to add group content from entity form'
   

   A) 'Defines a group content field type.'

   - Needs a period.
   - Simpler language more in line with core field types (image, text, etc).

   Or:

   B) 'Defines a group content relationship field type.'

   or very wordy, and referring to things we don't normally want to say in the user-facing text like "entity", but even more descriptive:

   C) 'Defines a field type to associate content with groups directly on the entity form.'

   ?

3. +++ b/modules/gcontent_field/gcontent_field.info.yml
   @@ -0,0 +1,8 @@
   +version: 1.0
   

   This shouldn't be here, and will be added by d.o during packaging.

4. +++ b/modules/gcontent_field/gcontent_field.libraries.yml
   @@ -0,0 +1,12 @@
   \ No newline at end of file
   

   And here

5. +++ b/modules/gcontent_field/gcontent_field.module
   @@ -0,0 +1,77 @@
   + * Get entities where the field should be added.
   

   Maybe:

   "Get entities that should have a group content field."
   ?

6. +++ b/modules/gcontent_field/gcontent_field.module
   @@ -0,0 +1,77 @@
   +    // Check if fields can be attached to the entity type.
   +    if ($entity_type_definition->get('field_ui_base_route')) {
   

   This seems like a weird way to test if the entity type in question is field-able. There must be a cleaner way to to this that doesn't depend on field_ui. Can't we test if something implements a certain interface, instead?

7. +++ b/modules/gcontent_field/gcontent_field.module
   @@ -0,0 +1,77 @@
   +      $entity_types[$plugin_definition['entity_type_id']] = (string) $entity_type_definition->getLabel();
   

   Can we be more flexible here and honor a config setting or something to make this field opt-in instead of opt-out? Basically #90.3 (I think).

8. +++ b/modules/gcontent_field/src/Element/GroupAutocomplete.php
   @@ -0,0 +1,57 @@
   + * Provides an group autocomplete form element.
   

   s/an/a

9. +++ b/modules/gcontent_field/src/Element/GroupAutocomplete.php
   @@ -0,0 +1,57 @@
   +      $form_state->setError($element, t('Many groups are called %value. Specify the one you want by appending the id in parentheses, like "@value (@id)".', $params));
   

   Could shorten the text to:
   'Many groups are called %value. Pick one by appending the ID in parentheses, like "@value (@id)".'

10. +++ b/modules/gcontent_field/src/Element/GroupAutocomplete.php
    @@ -0,0 +1,57 @@
    +      // More helpful error if there are only a few matching groups.
    +      $multiples = [];
    +      foreach ($groups as $id => $name) {
    +        $multiples[] = $name . ' (' . $id . ')';
    +      }
    +      $params['@id'] = $id;
    +      $form_state->setError($element, t('Multiple groups match this reference; "%multiple". Specify the one you want by appending the id in parentheses, like "@value (@id)".', ['%multiple' => implode('", "', $multiples)] + $params));
    +    }
    

    Nice touch with the error message here!

    However, it's more wordy than needed. Could be:

    'Multiple groups match: "%multiple". Pick one by appending the ID in parentheses, like "@value (@id)".'

11. +++ b/modules/gcontent_field/src/Element/GroupAutocomplete.php
    --- /dev/null
    +++ b/modules/gcontent_field/src/Field/GcontentFieldItemList.php
    

    Stopping review here for now...

No time for further review.

It does seem like a shared branch somewhere in a sandbox of some sort could be helpful. d.o sandbox? GitLab? GitHub? Thoughts?

Thanks!
-Derek

I created a d.o sandbox:

https://www.drupal.org/sandbox/dww/3045926

Clone of group module's 8.x-1.x branch.

I pushed a 2813405-group-content-field branch with #91 from here as commit c34f0ed.

Also pushed commit 6356f92 to fix #118 except points 6 and 7.

I added @jidrone, @axel.rutz, @joachim as co-maintainers. If anyone else wants access, please let me know.

Can we concentrate our efforts there to get this actually RTBC?

Thanks!
-Derek

> I created a d.o sandbox:

❤ to work with you!

Great, I will check this as soon as I can.

Addressed all things on #109 and the point 6 of #118

Whoops, #122 is empty. But based on the sandbox project, I think this is what @jidrone meant to upload. I haven't reviewed or tested it, but it's got some commits from both me and @jidrone in it. ;) Interdiff relative to #91 attached.

Still needs work for more from #90, but calling this NR to see what the testbot and others think.

Here is the new patch with 118.6 resolved, maybe I didn't pushed to sandbox before I created the patch.

Regarding the 118.7, related to 90.3, I wrote in 91 that I did the right code based on Drupal documentation but it was setting the field visible by default anyway. But after my latest tests it is working as expected and now the field should be configured in "Manage form display" to appear.

I someone else can test it, then we can say all issues from 90 and 118 are resolved.

Just a note I'll be testing the latest patch for a client project over the next week or so, was thinking of creating a computed field to do this then fortunately found this issue first.

@catch: Great! I made you co-maintainer on https://www.drupal.org/sandbox/dww/3045926 if you want to push any commits there.

I'll also be doing another round of review + testing on this for a project in the next few days. Hopefully we can coordinate any fixes and avoid duplicating any work. Here or #d8-group in Slack. I'm not at DrupalCon, sadly.

Thanks!
-Derek

Minor, but there's a null coalesce operator in gcontent_field.module which means a syntax error on PHP 5.6. Core's about to drop support for PHP 5.6 with 8.7.x but it'll still be supported by 8.6.0 a bit longer.

Three more.

Drupal 8.6 will still support PHP 5.6, but that version of PHP is an unsupported version by the PHP maintainers and for that reason most of the hosting providers already support PHP 7, so I think we don't need to downgrade the code, but if other users agree with you we can change it.

Hi Everyone, did someone has time to test this patch with the latest improvements?

I've been using patch from #124 for a while now, not in prod but on a quite complex site under heavy development, no big issue encountered.

Same as @esolitos, we've not launched the project, but it's quite complex and we've had no issues with this patch while building out the client's product.

@jidrone Hi, I currently have the patch 91. Can I update with patch 124 or do I have to uninstall the sub module to update ? Thank you

@Jidrone I applied patch 124 and the group is not added to the node.

If I select a group and click on added, the addition form disappears and the group is not added.

If I try to save the node, I have a PHP error :

Drupal\Component\Plugin\Exception\PluginNotFoundException : The "entity:group_content:administrateur-group_node-partenaire" plugin does not exist. Valid plugin IDs for Drupal\Core\TypedData\TypedDataManager are: formatted_price, duration, entity_revision_reference, entity_revision, entity_revision:advancedqueue_queue, entity_revision:block, entity_revision:block_content, entity_revision:block_content:basic, entity_revision:block_content_type, entity_revision:comment, entity_revision:comment:annonce, entity_revision:comment:article, entity_revision:comment:demande, entity_revision:comment:discussion, entity_revision:comment:evenement, entity_revision:comment:itineraire, entity_revision:comment:produit, entity_revision:comment:recette, entity_revision:comment:service, entity_revision:comment_type, entity_revision:commerce_checkout_flow, entity_revision:commerce_log, entity_revision:commerce_order_item_type, entity_revision:commerce_order, entity_revision:commerce_order:default, entity_revision:commerce_order:produit, entity_revision:commerce_order:recurring, entity_revision:commerce_order:service, entity_revision:commerce_order_item, entity_revision:commerce_order_item:default, entity_revision:commerce_order_item:produit, entity_revision:commerce_order_item:recurring_product_variation, entity_revision:commerce_order_item:recurring_standalone, entity_revision:commerce_order_item:service, entity_revision:commerce_order_type, entity_revision:commerce_payment, entity_revision:commerce_payment:payment_default, entity_revision:commerce_payment:payment_manual, entity_revision:commerce_payment_method, entity_revision:commerce_payment_method:paypal, entity_revision:commerce_payment_method:credit_card, entity_revision:commerce_payment_gateway, entity_revision:commerce_currency, entity_revision:commerce_pricelist, entity_revision:commerce_pricelist:commerce_product_variation, entity_revision:commerce_pricelist_item, entity_revision:commerce_pricelist_item:commerce_product_variation, entity_revision:commerce_product_variation_type, entity_revision:commerce_product_variation, entity_revision:commerce_product_variation:default, entity_revision:commerce_product_variation:produit, entity_revision:commerce_product_variation:service, entity_revision:commerce_product_attribute, entity_revision:commerce_product, entity_revision:commerce_product:default, entity_revision:commerce_product:produit, entity_revision:commerce_product:service, entity_revision:commerce_product_type, entity_revision:commerce_product_attribute_value, entity_revision:commerce_product_attribute_value:couleur, entity_revision:commerce_product_attribute_value:masse, entity_revision:commerce_product_attribute_value:taille, entity_revision:commerce_product_attribute_value:temps, entity_revision:commerce_product_attribute_value:volume, entity_revision:commerce_promotion_coupon, entity_revision:commerce_promotion, entity_revision:commerce_subscription, entity_revision:commerce_subscription:standalone, entity_revision:commerce_subscription:product_variation, entity_revision:commerce_billing_schedule, entity_revision:commerce_order_report, entity_revision:commerce_order_report:order_report, entity_revision:commerce_order_report:order_items_report, entity_revision:commerce_order_report:tax_report, entity_revision:commerce_order_report:promotion_report, entity_revision:commerce_shipment_type, entity_revision:commerce_shipping_method, entity_revision:commerce_package_type, entity_revision:commerce_shipment, entity_revision:commerce_shipment:default, entity_revision:commerce_store, entity_revision:commerce_store:online, entity_revision:commerce_store:personnel, entity_revision:commerce_store:professionnel, entity_revision:commerce_store_type, entity_revision:commerce_tax_type, entity_revision:contact_form, entity_revision:contact_message, entity_revision:contact_message:feedback, entity_revision:contact_message:personal, entity_revision:content_moderation_state, entity_revision:crop_type, entity_revision:crop, entity_revision:crop:1_1, entity_revision:crop:2_1, entity_revision:crop:3_1, entity_revision:crop:3_2, entity_revision:crop:a4, entity_revision:editor, entity_revision:entity_legal_document_acceptance, entity_revision:entity_legal_document, entity_revision:entity_legal_document_version, entity_revision:entity_legal_document_version:cgu, entity_revision:entity_legal_document_version:mentions_legales, entity_revision:entity_legal_document_version:politique_de_confidentialite, entity_revision:field_config, entity_revision:field_storage_config, entity_revision:field_validation_rule_set, entity_revision:file, entity_revision:filter_format, entity_revision:flag, entity_revision:flagging, entity_revision:flagging:like_group, entity_revision:flagging:like_node, entity_revision:flagging:like_product, entity_revision:flagging:like_store, entity_revision:flagging:report_comment, entity_revision:flagging:report_group, entity_revision:flagging:report_node, entity_revision:flagging:report_private_message, entity_revision:flagging:report_product, entity_revision:flagging:report_profile, entity_revision:flagging:report_store, entity_revision:flagging:report_user, entity_revision:group_role, entity_revision:group_type, entity_revision:group, entity_revision:group:administrateur, entity_revision:group:personnel, entity_revision:group:professionnel, entity_revision:group_content, entity_revision:group_content:administrateur-group_membership, entity_revision:group_content:administrateur-group_node-guide, entity_revision:group_content:group_content_type_019ce60735906, entity_revision:group_content:group_content_type_0a627b6b58289, entity_revision:group_content:group_content_type_28f8a8dbd2f8b, entity_revision:group_content:group_content_type_9307df917f9ab, entity_revision:group_content:group_content_type_b1946b84b0196, entity_revision:group_content:group_content_type_ec36c5a835021, entity_revision:group_content:group_content_type_fa2db4a50c8e0, entity_revision:group_content:personnel-group_membership, entity_revision:group_content:personnel-group_node-annonce, entity_revision:group_content:personnel-group_node-article, entity_revision:group_content:personnel-group_node-discussion, entity_revision:group_content:personnel-group_node-evenement, entity_revision:group_content:personnel-group_node-itineraire, entity_revision:group_content:personnel-group_node-recette, entity_revision:group_content:professionnel-group_membership, entity_revision:group_content:professionnel-group_node-annonce, entity_revision:group_content:professionnel-group_node-article, entity_revision:group_content:professionnel-group_node-recette, entity_revision:group_content_type, entity_revision:image_style, entity_revision:language_content_settings, entity_revision:configurable_language, entity_revision:media, entity_revision:media:audio, entity_revision:media:file, entity_revision:media:image, entity_revision:media:remote_video, entity_revision:media:video, entity_revision:media_type, entity_revision:message_template, entity_revision:message, entity_revision:message:mas_create_comment, entity_revision:message:mas_create_group, entity_revision:message:mas_create_node, entity_revision:message:mas_create_product, entity_revision:message:mas_create_store, entity_revision:message:mas_user_register, entity_revision:message:notify, entity_revision:message:private_message_notification, entity_revision:metatag_defaults, entity_revision:node_type, entity_revision:node, entity_revision:node:annonce, entity_revision:node:article, entity_revision:node:demande, entity_revision:node:discussion, entity_revision:node:evenement, entity_revision:node:guide, entity_revision:node:itineraire, entity_revision:node:page, entity_revision:node:partenaire, entity_revision:node:question, entity_revision:node:recette, entity_revision:node:tutoriel, entity_revision:pathauto_pattern, entity_revision:private_message, entity_revision:pm_thread_delete_time, entity_revision:private_message_thread, entity_revision:pm_thread_access_time, entity_revision:profile_type, entity_revision:profile, entity_revision:profile:customer, entity_revision:redirect, entity_revision:responsive_image_style, entity_revision:search_api_index, entity_revision:search_api_server, entity_revision:search_api_task, entity_revision:search_api_autocomplete_search, entity_revision:solr_field_type, entity_revision:menu, entity_revision:action, entity_revision:taxonomy_term, entity_revision:taxonomy_term:annonce_categories, entity_revision:taxonomy_term:annonce_tags, entity_revision:taxonomy_term:article_tags, entity_revision:taxonomy_term:boutique_tags, entity_revision:taxonomy_term:discussion_tags, entity_revision:taxonomy_term:evenement_tags, entity_revision:taxonomy_term:groupe_tags, entity_revision:taxonomy_term:itineraire_tags, entity_revision:taxonomy_term:page_tags, entity_revision:taxonomy_term:produit_labels, entity_revision:taxonomy_term:produit_tags, entity_revision:taxonomy_term:profil_sexe, entity_revision:taxonomy_term:question_categories, entity_revision:taxonomy_term:recette_categories, entity_revision:taxonomy_term:recette_ingredients, entity_revision:taxonomy_term:recette_niveaux, entity_revision:taxonomy_term:recette_tags, entity_revision:taxonomy_term:recette_types, entity_revision:taxonomy_term:service_tags, entity_revision:taxonomy_vocabulary, entity_revision:tour, entity_revision:user, entity_revision:user_role, entity_revision:webform, entity_revision:webform_submission, entity_revision:webform_submission:concours_fevrier_2018, entity_revision:webform_submission:invitation, entity_revision:webform_submission:mode_de_livraison, entity_revision:webform_submission:passerelle_de_paiement, entity_revision:webform_submission:supprimer_la_boutique, entity_revision:webform_submission:supprimer_le_compte, entity_revision:webform_submission:supprimer_le_groupe, entity_revision:webform_options, entity_revision:workflow, entity_revision:menu_link_content, entity_revision:view, entity_revision:paragraph, entity_revision:paragraph:evenement_programmations, entity_revision:paragraph:itineraire_poi, entity_revision:paragraph:recette_ingredients, entity_revision:paragraph:recette_instructions, entity_revision:paragraphs_type, entity_revision:entity_form_display, entity_revision:entity_view_display, entity_revision:entity_form_mode, entity_revision:entity_view_mode, entity_revision:date_format, entity_revision:base_field_override, filter_format, metatag, search_api_html, search_api_text, solr_document, solr_field, entity, entity:advancedqueue_queue, entity:block, entity:block_content, entity:block_content:basic, entity:block_content_type, entity:comment, entity:comment:annonce, entity:comment:article, entity:comment:demande, entity:comment:discussion, entity:comment:evenement, entity:comment:itineraire, entity:comment:produit, entity:comment:recette, entity:comment:service, entity:comment_type, entity:commerce_checkout_flow, entity:commerce_log, entity:commerce_order_item_type, entity:commerce_order, entity:commerce_order:default, entity:commerce_order:produit, entity:commerce_order:recurring, entity:commerce_order:service, entity:commerce_order_item, entity:commerce_order_item:default, entity:commerce_order_item:produit, entity:commerce_order_item:recurring_product_variation, entity:commerce_order_item:recurring_standalone, entity:commerce_order_item:service, entity:commerce_order_type, entity:commerce_payment, entity:commerce_payment:payment_default, entity:commerce_payment:payment_manual, entity:commerce_payment_method, entity:commerce_payment_method:paypal, entity:commerce_payment_method:credit_card, entity:commerce_payment_gateway, entity:commerce_currency, entity:commerce_pricelist, entity:commerce_pricelist:commerce_product_variation, entity:commerce_pricelist_item, entity:commerce_pricelist_item:commerce_product_variation, entity:commerce_product_variation_type, entity:commerce_product_variation, entity:commerce_product_variation:default, entity:commerce_product_variation:produit, entity:commerce_product_variation:service, entity:commerce_product_attribute, entity:commerce_product, entity:commerce_product:default, entity:commerce_product:produit, entity:commerce_product:service, entity:commerce_product_type, entity:commerce_product_attribute_value, entity:commerce_product_attribute_value:couleur, entity:commerce_product_attribute_value:masse, entity:commerce_product_attribute_value:taille, entity:commerce_product_attribute_value:temps, entity:commerce_product_attribute_value:volume, entity:commerce_promotion_coupon, entity:commerce_promotion, entity:commerce_subscription, entity:commerce_subscription:standalone, entity:commerce_subscription:product_variation, entity:commerce_billing_schedule, entity:commerce_order_report, entity:commerce_order_report:order_report, entity:commerce_order_report:order_items_report, entity:commerce_order_report:tax_report, entity:commerce_order_report:promotion_report, entity:commerce_shipment_type, entity:commerce_shipping_method, entity:commerce_package_type, entity:commerce_shipment, entity:commerce_shipment:default, entity:commerce_store, entity:commerce_store:online, entity:commerce_store:personnel, entity:commerce_store:professionnel, entity:commerce_store_type, entity:commerce_tax_type, entity:contact_form, entity:contact_message, entity:contact_message:feedback, entity:contact_message:personal, entity:content_moderation_state, entity:crop_type, entity:crop, entity:crop:1_1, entity:crop:2_1, entity:crop:3_1, entity:crop:3_2, entity:crop:a4, entity:editor, entity:entity_legal_document_acceptance, entity:entity_legal_document, entity:entity_legal_document_version, entity:entity_legal_document_version:cgu, entity:entity_legal_document_version:mentions_legales, entity:entity_legal_document_version:politique_de_confidentialite, entity:field_config, entity:field_storage_config, entity:field_validation_rule_set, entity:file, entity:filter_format, entity:flag, entity:flagging, entity:flagging:like_group, entity:flagging:like_node, entity:flagging:like_product, entity:flagging:like_store, entity:flagging:report_comment, entity:flagging:report_group, entity:flagging:report_node, entity:flagging:report_private_message, entity:flagging:report_product, entity:flagging:report_profile, entity:flagging:report_store, entity:flagging:report_user, entity:group_role, entity:group_type, entity:group, entity:group:administrateur, entity:group:personnel, entity:group:professionnel, entity:group_content, entity:group_content:administrateur-group_membership, entity:group_content:administrateur-group_node-guide, entity:group_content:group_content_type_019ce60735906, entity:group_content:group_content_type_0a627b6b58289, entity:group_content:group_content_type_28f8a8dbd2f8b, entity:group_content:group_content_type_9307df917f9ab, entity:group_content:group_content_type_b1946b84b0196, entity:group_content:group_content_type_ec36c5a835021, entity:group_content:group_content_type_fa2db4a50c8e0, entity:group_content:personnel-group_membership, entity:group_content:personnel-group_node-annonce, entity:group_content:personnel-group_node-article, entity:group_content:personnel-group_node-discussion, entity:group_content:personnel-group_node-evenement, entity:group_content:personnel-group_node-itineraire, entity:group_content:personnel-group_node-recette, entity:group_content:professionnel-group_membership, entity:group_content:professionnel-group_node-annonce, entity:group_content:professionnel-group_node-article, entity:group_content:professionnel-group_node-recette, entity:group_content_type, entity:image_style, entity:language_content_settings, entity:configurable_language, entity:media, entity:media:audio, entity:media:file, entity:media:image, entity:media:remote_video, entity:media:video, entity:media_type, entity:message_template, entity:message, entity:message:mas_create_comment, entity:message:mas_create_group, entity:message:mas_create_node, entity:message:mas_create_product, entity:message:mas_create_store, entity:message:mas_user_register, entity:message:notify, entity:message:private_message_notification, entity:metatag_defaults, entity:node_type, entity:node, entity:node:annonce, entity:node:article, entity:node:demande, entity:node:discussion, entity:node:evenement, entity:node:guide, entity:node:itineraire, entity:node:page, entity:node:partenaire, entity:node:question, entity:node:recette, entity:node:tutoriel, entity:pathauto_pattern, entity:private_message, entity:pm_thread_delete_time, entity:private_message_thread, entity:pm_thread_access_time, entity:profile_type, entity:profile, entity:profile:customer, entity:redirect, entity:responsive_image_style, entity:search_api_index, entity:search_api_server, entity:search_api_task, entity:search_api_autocomplete_search, entity:solr_field_type, entity:menu, entity:action, entity:taxonomy_term, entity:taxonomy_term:annonce_categories, entity:taxonomy_term:annonce_tags, entity:taxonomy_term:article_tags, entity:taxonomy_term:boutique_tags, entity:taxonomy_term:discussion_tags, entity:taxonomy_term:evenement_tags, entity:taxonomy_term:groupe_tags, entity:taxonomy_term:itineraire_tags, entity:taxonomy_term:page_tags, entity:taxonomy_term:produit_labels, entity:taxonomy_term:produit_tags, entity:taxonomy_term:profil_sexe, entity:taxonomy_term:question_categories, entity:taxonomy_term:recette_categories, entity:taxonomy_term:recette_ingredients, entity:taxonomy_term:recette_niveaux, entity:taxonomy_term:recette_tags, entity:taxonomy_term:recette_types, entity:taxonomy_term:service_tags, entity:taxonomy_vocabulary, entity:tour, entity:user, entity:user_role, entity:webform, entity:webform_submission, entity:webform_submission:concours_fevrier_2018, entity:webform_submission:invitation, entity:webform_submission:mode_de_livraison, entity:webform_submission:passerelle_de_paiement, entity:webform_submission:supprimer_la_boutique, entity:webform_submission:supprimer_le_compte, entity:webform_submission:supprimer_le_groupe, entity:webform_options, entity:workflow, entity:menu_link_content, entity:view, entity:paragraph, entity:paragraph:evenement_programmations, entity:paragraph:itineraire_poi, entity:paragraph:recette_ingredients, entity:paragraph:recette_instructions, entity:paragraphs_type, entity:entity_form_display, entity:entity_view_display, entity:entity_form_mode, entity:entity_view_mode, entity:date_format, entity:base_field_override, entity_reference, field_item:address, field_item:address_zone, field_item:address_country, field_item:comment, field_item:commerce_remote_id, field_item:commerce_plugin_item:commerce_condition, field_item:commerce_plugin_item:commerce_promotion_offer, field_item:commerce_plugin_item:commerce_subscription_type, field_item:commerce_plugin_item:commerce_prorater, field_item:commerce_plugin_item:commerce_shipping_method, field_item:commerce_adjustment, field_item:commerce_price, field_item:commerce_billing_period, field_item:commerce_scheduled_change, field_item:commerce_shipment_item, field_item:datetime, field_item:daterange, field_item:duration, field_item:entity_reference_revisions, field_item:file, field_item:file_uri, field_item:geolocation, field_item:image, field_item:link, field_item:metatag, field_item:office_hours, field_item:list_float, field_item:list_string, field_item:list_integer, field_item:path, field_item:physical_measurement, field_item:physical_dimensions, field_item:redirect_source, field_item:state, field_item:telephone, field_item:text_with_summary, field_item:text_long, field_item:text, field_item:viewsreference, field_item:webform, field_item:yoast_seo, field_item:email, field_item:integer, field_item:float, field_item:uri, field_item:string_long, field_item:decimal, field_item:map, field_item:created, field_item:password, field_item:timestamp, field_item:entity_reference, field_item:boolean, field_item:string, field_item:uuid, field_item:language, field_item:changed, timestamp, language, boolean, timespan, any, language_reference, integer, duration_iso8601, map, email, string, datetime_iso8601, list, float, uri, binary dans Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (ligne 53 de /var/www/www-example-com/web/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

The new node is not added as a related entity in groups with the chosen group(select widget) with patch #124. Anyone else also got this issue?

I followed these steps:

1. Go to "Manage Fields" for the content type do you want to add in groups.
2. Add a new field of type Reference > Other.
3. For the option "Type of item to reference" select Content > Group. (Not group content).
4. The option "Allowed number of values" depends on your expected behaviour.
On the next screen select all the group content bundles needed in "REFERENCE TYPE", I'm planning to do an improvement to set them as default value.
5. Go to "Manage Form Display" and select the widget "Group Selector" for the field you just created.

I can see the groups but when i save the node nothing happens in groups.

Can confirm #136. If you try to create a node with a group config constructed ID that's greater than 32 chars, the error is triggered.

It appears the group module hashes the config ID when it's over the limit

  # web/modules/contrib/group/src/Plugin/GroupContentEnablerBase.php
  public function getContentTypeConfigId() {
    $preferred_id = $this->getGroupTypeId() . '-' . str_replace(':', '-', $this->getPluginId());

    // Return a hashed ID if the readable ID would exceed the maximum length.
    if (strlen($preferred_id) > EntityTypeInterface::BUNDLE_MAX_LENGTH) {
      $hashed_id = 'group_content_type_' . md5($preferred_id);
      $preferred_id = substr($hashed_id, 0, EntityTypeInterface::BUNDLE_MAX_LENGTH);
    }

    return $preferred_id;
  }

The only related line I see in the stack trace is
Drupal\gcontent_field\Plugin\Field\FieldWidget\GroupSelectorWidget->elementValidate(Array, Object, Array)

Should this patch be correcting the plugin ID before passing to Drupal core?

There is another problem with the group field, it can not be used with a relation from a node. This poses problems with views, messages, and tokens. It's not really a field.

Can not go back to the parent group of a node.

@zenimagine I usually create views if GroupContent instead of Content, because it decreases the amount of JOINS.

But, a part from that, it's definitely possible to go down this path: Node -> GroupContent -> Group -> GroupContent -> Node, and you can access all the fields of each of those entities.

The naming of the relationships is not the best, something like "Content from group content" to access the Node when you have a GroupContent.

BTW: I'm not sure also that your report is related to the current issue.

@esolitos I opened a new problem https://www.drupal.org/project/group/issues/3056822

Hi Everyone,

Here is a new patch with the following:

• Fixed issue reported in #136
• Some code standard improvements.
• Some unused variables removed.

I reviewed the test failures for the patch in #142, and they're all

Error: Call to a member function getBaseFieldDefinitions() on null

And appear to be coming from this core update
https://www.drupal.org/project/drupal/issues/3035953

specifically

@@ -266,7 +284,7 @@ public function getViewsData() {

     // Load all typed data definitions of all fields. This should cover each of
     // the entity base, revision, data tables.
-    $field_definitions = $this->entityManager->getBaseFieldDefinitions($this->entityType->id());
+    $field_definitions = $this->entityFieldManager->getBaseFieldDefinitions($this->entityType->id());

which is called in

// GroupContentViewsData.php
$data = parent::getViewsData();

Not sure if the failures should be a blocker for approving this patch since I'd expect other patches to fail similarly. Maybe we need a separate issue to track?

I'm having an issue, when editing/creating group content via an Entity Reference field and the Inline Entity Form: the group selector is visible, but group is not saved. For that I have to edit that created referenced node separately and then only I'm able to attribute a group to that node.

I'm using that approach because I'm writing blog post, with some part of them is only visible to group members (the referenced entity). It would be great if I could attribute a group to the referenced entity while editing the 'parent' node and the Inline Entity Form.

Is it possible to fix this?

I addressed the error on tests mentioned in #143 by creating this new issue #3061353: Replace deprecated EntityManager and add EntityFieldManager in GroupContentViewsData because they are not related to this patch.

I updated the patch to account for nested Add to Group forms. I tested it with a media entity reference field using the 'Inline entity form - Complex' widget, and was able to successfully add the parent node to a group as well as a new inline media entity.

Finally had a chance to review and test this again. Excited this is getting close!

Our sandbox has fallen behind patch #142, so I'm testing that directly.

NW for:
#90.4a
#90.8

I still find #90.9 clumsy and limited. If we're going to have all the different formatter options, can we have a more powerful/flexible choice for parent group that provides:

...the options for label-only (with and without a link to the group entity itself), id, or a full rendered entity

? Looks like @anruether agrees in #117. Does that need to be a follow-up feature request? @jidrone's answer in #91.9 doesn't really make sense to me:

The field on this patch is referencing the group content entity instead of group, it is especially useful for example in user membership, because it gives the possibility to configure the group roles.
Then you can set the formatter as referenced entity and show a summary of user membership.

But the gcontent_field module and everything it provides only injects itself as a field on content associated with groups (at least in my testing). For example, I don't see any mention of it at:
/admin/group/content/manage/private-group_membership/form-display
I'm confused how this computed field + widget on group content (e.g. events, private pages, etc) can be used to subscribe users to groups?
As it is in #142, the widget's behavior is wildly different depending on what widget you use (more than usual). ;) You get fundamentally different possible target entities, not just different ways to select from among the same set.

Behold:
Autocomplete
Checkboxes
Select

If I try to even use IEF and then visit a private_page entity form, I get WSOD with:

The website encountered an unexpected error. Please try again later.
TypeError: Argument 1 passed to Drupal\group\Plugin\GroupContentEnabler\GroupMembership::createAccess() must implement interface Drupal\group\Entity\GroupInterface, null given, called in /Applications/MAMP-common/htdocs/breema-d8/web/modules/contrib/group/src/Entity/Access/GroupContentAccessControlHandler.php on line 30 in Drupal\group\Plugin\GroupContentEnabler\GroupMembership->createAccess() (line 116 of modules/contrib/group/src/Plugin/GroupContentEnabler/GroupMembership.php).

The only one that works at all is Group Selector where the available choices make sense (in both select and autocomplete variants).
(Side nit #147.2: the convention in core / contrib is that this should be 'Group selector' (no 'S', only 's')).

I honestly think this field would be safer if we forced the group selector widget. Everything else (as a form display widget choice for this magic field) seems to not give anyone what they want. How can any of those screenshots possibly be the right UI for a content editor creating private content to add to a group?

Also unaddressed:
#113
#127 and #128

Meanwhile, #146 includes syntax errors, so we can't really review/test it. But if that's a bug, it's unaddressed, too.

Thanks!
-Derek

p.s. Updating the summary for remaining tasks. Let's cross off stuff if we have working patches that address any of it. Thanks! Also hiding a bunch of old files.

Fixing minor formatting bug in the summary, adding link to 147.

Some additional NW items:

1. +++ b/modules/gcontent_field/gcontent_field.info.yml
   @@ -0,0 +1,7 @@
   +name: 'Group Content Field'
   +description: 'Defines a group content field type.'
   

   These could use some help. Something explaining a bit more about what this magic computed field provides, at least for the description. Something like:

   description: Defines a field to view and edit the groups that content belong to.

   (or something -- better alternatives welcome).

2. +++ b/modules/gcontent_field/gcontent_field.tokens.inc
   @@ -0,0 +1,62 @@
   +          'ty pe' => $field_token_name,
   

   Looks like a typo 'ty pe'.

3. +++ b/modules/gcontent_field/src/Plugin/Field/FieldWidget/GroupSelectorWidget.php
   @@ -0,0 +1,1184 @@
   +    $add_more_elements['add_relation'] = [
   +      '#title' => $this->t('Group'),
   +      '#type' => 'select',
   +      '#description' => $this->t('Select a group'),
   +      '#options' => $allowed_groups,
   +    ];
   

   If $allowed_groups is empty, this gives you an empty select dropdown form element. For example, if a piece of content already belongs to all the possible groups. The form element should disappear once all the groups are gone or none are available.
   

4. Same story for autocomplete. Once all the groups are assigned, the autocomplete form element should disappear.

Thanks!
-Derek

Hi, I applied the last patch to the module. How to display the parent group of a node in the Message module with Token?

I tested the token below and it does not work :

[message:field_node_reference:entity:group_content:entity:group:title]

[message:field_node_reference:entity:group_content:entity:group:title]
[message:field_node_reference:entity:group_content:group:title]
[message:field_node_reference:group_content:entity:group:title]
[message:field_node_reference:group_content:group:title]
[message:field_node_reference:entity:group:entity:group:title]
[message:field_node_reference:entity:group:group:title]
[message:field_node_reference:group:entity:group:title]
[message:field_node_reference:group:group:title]

This fixes everything from #149.
Pushed to the sandbox as commit a20f1ec
Still NW (see summary and #147)

I was in a hurry when I uploaded #151. Left stray garbage in the .info file while fixing #149.1. This patch actually works. ;) Still needs help for all the open points.

@dww Hi, thanks for the patch, can you integrate the token ? Because currently there is no dean to link the content to the group with the token.

Can not find token of the parent group of a node.

@zenimagine: I don't currently need or care about the tokens, so that hasn't been what I've been testing and fixing. It's possible I fixed it "on accident" by correcting the typo I saw in #149.2 since that was in gcontent_field_token_info().

I just added #150 to the summary for remaining tasks. Please test patch #152. If it's now working, please cross off #150 from the summary as complete (wrapping in <del> tags like the others). Otherwise, someone who cares about the tokens will have to debug this and fix it (or document how it works if it's already working).

Thanks/sorry,
-Derek

p.s. Note to committers: d.o's issue credit heuristics think I should be the author of this patch. Definitely not. ;) Please use @jidrone as the author. Thanks!

Fixed #127 and #128, pushed to the sandbox as commit 6cf1bfb34ed. I think this should pass on the default PHP 5 now...

Interdiffs against #152 (to see the 3 fixes from @catch) and against #142 (to see everything "I" fixed since @jidrone's last patch).

Whoops, I missed the point in #117 that #85 / #109 is still broken. Added those to the summary's remaining tasks. (Another feature / aspect I don't care about, so hopefully someone with multiple group types can take a look). ;)

Cheers,
-Derek

As of #146, while that patch might have been messed up, the interdiff seems to make sense. It drops the assumption that we're at the form root, else no changes. So someone(tm) might want to integrate that interdiff. Cool to see the ball rolling, kudos derek and everyone!

@axel.rutz re: #157 -- oh yeah, good point. The syntax errors are just the PHP7 null coalesce operators (now fixed) so this should pass on both PHP5 and PHP7. Integrated patch #146, fixed a very minor code style bug in it, pushed to the sandbox, crossed off from the summary. I did *not* test the case mentioned of using IEF.

We almost certainly need tests for at least some of this functionality (see #90.10). Tagging and adding to the summary.

Cheers,
-Derek

I tested the following Token with patch #158 :

[message:field_node_reference:entity:group_content:group:title]

[message:field_node_reference:entity:group_content:entity:group:entity:title]
[message:field_node_reference:entity:group_content:entity:group:title]

None work. In the first patch, tokens worked.

This fixes #90.9 (see also #117 and #147).

I started down the road of making the single ParentGroupFormatter class support more settings to determine what kind of formatter you want. Then I realized the whole thing was extending the EntityReferenceEntityFormatter and saw how much code I'd have to duplicate from the other EntityReference*Formatter classes to support the other display types (label + ID).

So, then I split ParentGroupFormatter into 3 formatter classes, ParentGroup(Entity|Id|Label)Formatter, each extending from the corresponding EntityReference*Formatter. I put the magic from getEntitiesToView() into a trait that's shared among all 3 (can't use a base class since each formatter needs to extend a different EntityReference*Formatter class).

Given the shared trait, the 3 formatter classes are now very simple. Only ParentGroupEntityFormatter needs to override any parent methods (to get the right view_mode options for groups). The other two are exactly the parent formatter classes, with the overridden getEntitiesToView() from the trait.

The trait itself might want a rename (currently "ParentGroupFormatterGetEntitiesTrait").

Otherwise, we now have all the display flexibility we might want for this (especially ParentGroupLabelFormatter with an option to link to the group or not).

Cheers,
-Derek

This fixes #147.2 (s/Group Selector/Group selector/).

Note: the fails on #158 for 8.8.x core are due to #3061353: Replace deprecated EntityManager and add EntityFieldManager in GroupContentViewsData not this patch. We shouldn't test against 8.8.x until #3061353 is fixed.

Fixes code style bugs being warned about in https://www.drupal.org/pift-ci-job/1338423

However, I really don't like that modules/gcontent_field/css/gcontent-field.admin.css targets everything first via a .js selector. I think we should remove that, although I haven't actually tried it, yet. Maybe @jidrone can comment on why the patch defines those styles in that way. Adding this to the summary as a @todo.

Bah, missed a few more code style problems I had introduced in #160.

Thanks for your work, Derek!

I tested #163 and saw this if you add a regular group reference field after enabling gcontent_field:

Widget and Formatter of regular group reference fields are identical to those of the new field. This leads to WSOD when for the reference field...
- in the widget, you select Group Selector
- in the formatter, you select Parent Group ... (for a group reference field this option doesn't make any sense anyways)

I guess those settings shouldn't be there in the first place ?! Let me know if you need the full backtrace:

Error: Call to undefined method Drupal\group\Entity\Group::getGroup() in Drupal\gcontent_field\Plugin\Field\FieldFormatter\ParentGroupLabelFormatter->getEntitiesToView() (line 23 of /var/www/html/web/modules/contrib/group/modules/gcontent_field/src/Plugin/Field/FieldFormatter/ParentGroupFormatterGetEntitiesTrait.php)

@anruether re: #164: Ugh, yeah. I see exactly what you mean. This is a Big Problem(tm) with the approach in this patch. The custom computed field here is "just" an entity_reference field type. So, the formatters and widget are configured to apply to that field type, and therefore they show up *everywhere* in the field_ui when you're touching any kind of entity_reference field. :(

I think the Right Way(tm) to deal with this is that instead of just defining our own custom GcontentFieldItemList class and configuring this magic entity_reference field to use it, we should really define a new, custom field *type* for all this. It should simply extend entity_reference, but have a different field type ID. Then, the custom formatters and widget will target the custom field type. That way, these magic formatters and widget won't "leak" out into other entity reference types.

That's +1000 from me, but I fear @jidrone won't like it, since it'd mean we'd completely resolve #90.9 in my favor: namely, that the "other" ways to format these group_content entities wouldn't keep "working" (if you call the screenshots in #147 "working"). ;)

Short of that, I don't know of any way to hide the formatter(s) and widget(s) from the "wrong" kinds of entity_reference fields. We only get a plugin annotation, and at that level, all we have to work with is a specific field type. We don't get to test properties of the entity the field is attached to, etc. Maybe someone else knows a way around this.

@joachim re: #113:

+ if ($entity_types = gcontent_field_get_entity_types()) {
Isn't this going to be circular?

I don't see how. There's no call to gcontent_field_get_entity_types() inside gcontent_field_get_entity_types(). The code you quoted is inside gcontent_field_entity_base_field_info(), which calls gcontent_field_get_entity_types() which does a bunch of stuff but I don't see how anything in there would trigger another call to gcontent_field_entity_base_field_info().

Crossing #113 off the list of remaining tasks. @joachim please clarify if I'm misunderstanding your concern.

@zenimagine re #165 - nope, I didn't change the field name. But I *did* change the IDs for the field formatter, so existing sites running the patch will have to re-save their 'Manage display' world on any group-enabled content types to get the formatters working again.

@dww Yes, thank you indeed, you have to save the display again. I was too fast in my comment.
But concerning Tokens, the last patch does not correct. With the Message module, I created a message template for the new nodes and I was unable to trace the name of the parent group.

@zenimagine re: #167: Yup. The brokenness of tokens is: a) already in the summary of remaining tasks, b) something I already said I don't care about (or more accurately, the project I'm currently working on that needs this functionality doesn't care about) and therefore it's not something I'm going to be able to fix for you. Sorry.

Meanwhile, cleaning up some other aspects of the summary that either had typos/grammar bugs, or were out-of-date based on recent changes.

@dww #166;
> The custom computed field here is "just" an entity_reference field type. So, the formatters and widget are configured to apply to that field type, and therefore they show up *everywhere* in the field_ui when you're touching any kind of entity_reference field. :(

I did not fully grok the problem, but i guess a solution without making up a new field type ID might (or might not) come from \Drupal\Core\Field\WidgetBase::isApplicable / \Drupal\Core\Field\FormatterBase::isApplicable ;-)

Re: #169: Cool, that sorta helps. ;) This takes advantage of that method to hide the custom formatters and widget unless the field is our custom computed field.

However, I still think our own (unique) field type would be better, since:

a) This patch is a hack, hard-coding the field name to 'group_content' and type (entity_reference). I don't think there's a safe way to really know that's what our computed field is called, and hard-coding the field name like this seems like a major hack. However, I don't know how else to identify our field since it's re-using 'entity_reference' type.

b) While this hides the custom formatters and widget from other entity_reference fields (yay -- solves #164), all the (IMHO totally bogus -- see #147) alternate widgets and formatters for entity_reference fields still appear when configuring the group_content computed field. @jidrone probably thinks that's a feature. I consider it a bug. ;)

Anyway, it's here for consideration. I'm not sold this is the right solution, but it's better than nothing.

Maybe there's a compromise on #90.9:
go for a custom field type, but then opt in to the formatters / widgets that could be useful to someone with the right settings and config, but not to those that cannot be made useful without custom development work no matter how you configure them.

Hi everyone,
Yes, I think we can go for a custom field type, I'm going to explain better why a Rendered entity formatter makes sense:
Any content entity type can be added as Group Content is the needed plugin is provided, out of the box the group module has support for Users and Nodes.
The field provided by this module detects all entity types with support for groups and adds the field to them.
Here is where the formatter can be useful:

• You can add users to groups (Group memberships) by using this field.
• Create a view mode for the group content(Group membership).
• In user manage display select the Rendered entity formatter for the group_content field.
• Set the view mode previously created.
• Now when you see the user account you can see a list of their memberships.

@jidrone re: #172: Thanks for the reply. Indeed, I recently discovered that the field shows up directly on user entities, letting you manage group memberships while editing a user. At #147 I foolishly thought it would be on the group content relationship entities (which didn't make sense):

For example, I don't see any mention of it at:
/admin/group/content/manage/private-group_membership/form-display
I'm confused how this computed field + widget on group content (e.g. events, private pages, etc) can be used to subscribe users to groups?

...but I hadn't noticed the field on users (yet). Given that, yes, I see there could be reasons to show the relationship entities (the membership itself, including the group roles, etc) not just the parent group. I've been looking at this issue entirely from the content side, not users.

So yeah, we probably need to retain the "raw" entity reference formatters for the new field type, although arguably we can get rid of the other widgets since I don't see how the other widgets help, even for the user case.

If we go with a new custom field type, probably the cleanest way to propagate the other entity reference formatters to them is to have trivial classes that extend the core formatter classes, but use different plugin IDs and target our custom field type. More or less like the new formatters I added in #160, only without needing to use the trait to override getEntitiesToView().

Anyway, I hope you get a chance to work on some of the remaining items, since I'm basically out of time for right now, and will be busy at least for the next 3+ weeks.

Thanks!
-Derek

> If we go with a new custom field type, probably the cleanest way to propagate the other entity reference formatters to them is to have trivial classes that extend the core formatter classes, but use different plugin IDs and target our custom field type.

hook_field_widget_info_alter / hook_field_formatter_info_alter ?

Hi everyone,
Latest commit to https://www.drupal.org/sandbox/dww/3045926, has the new field type approach for you to test, with the hook_field_formatter_info_alter.