Please add me to the co-maintainer(s) module. Because the module needs co-maintainer(s)

Comments

pifagor created an issue. See original summary.

gisle’s picture

The project page says they are looking for co-maintainer. This does not mean that the owner (Dave Reid) is going to hand out co-maintainership to anyone. The person taking over need to show that he/she has some interest in maintaining this project (as opposed to someone trying to bag a Drupal project co-maintainer just to have it on their CV in order to impress clients).

To show that you have a genuine interest in contributing to this project, you should start out by posting patches to the project's issue queue, and you should demonstrate that you have an ability to get those patches reviewed tested and approved by the community (RTBC).

In some cases, you will be added as a co-maintainer after demonstrating: 1) That you have a genuine interest in maintaining the project; 2) are capable of creating code that is secure, good, and follow community guidelines – but that is up to the owner.

But I don't think any responsible project owner will add someone as co-maintainer without seeing some code.

pifagor’s picture

Dear @gisle. I'm not a new person in the community.
Check out my profile and your questions will be out of date.

Thank you for your advice. I will take note of your remarks.

gisle’s picture

pifagor wrote:

Check out my profile and your questions will be out of date.

Of course I already did. Quantity is not the same as quality.

pifagor’s picture

@gisle

Quantity is not the same as quality.

I have patches of varying quality, both simple and complex.

I appreciate your dedication to the drupal. But still I have to say. I support other projects by spending my own time.
I find it incorrect and unacceptable for such a reaction to volunteer help and the quality of my code.
Yes, I agree that I have to contribute to the module. I will do it.

And I have a remark.
I have reviewed your profile. And I see that you not only me gave me such answers. I don't understand how ethically giving such answers when a person offers volunteer help. The programmer wastes his own time for which he does not receive funds. It should bring respect, not a negative reaction.
That is the essence of the Drupal community. Mutual assistance and mutual respect.

gisle’s picture

pifagor wrote:

The programmer wastes his own time for which he does not receive funds. It should bring respect, not a negative reaction.

I agree that we must to respect each other. However, you cannot request that I check out your profile, and then claim that it is a sign of disrespect that I honour such a request.

pifagor wrote:

Yes, I agree that I have to contribute to the module. I will do it.

Great! I think that is the procedure: Contribute first, then request to be added as co-maintainer (and not the other way around).

pifagor’s picture

Version: 8.x-1.x-dev » 7.x-2.x-dev

I worked on issues:

I created a patch:
https://www.drupal.org/project/xmlsitemap/issues/2957682
https://www.drupal.org/project/xmlsitemap/issues/1670086
https://www.drupal.org/project/xmlsitemap/issues/2957690
https://www.drupal.org/project/xmlsitemap/issues/2957692
https://www.drupal.org/project/xmlsitemap/issues/2945381
https://www.drupal.org/project/xmlsitemap/issues/2957576
https://www.drupal.org/project/xmlsitemap/issues/2939318

I viewed, tested and showed activity on issues
https://www.drupal.org/project/xmlsitemap/issues/2951689
https://www.drupal.org/project/xmlsitemap/issues/2923022
https://www.drupal.org/project/xmlsitemap/issues/2931593
https://www.drupal.org/project/xmlsitemap/issues/2923583
https://www.drupal.org/project/xmlsitemap/issues/1396220
https://www.drupal.org/project/xmlsitemap/issues/2851552
https://www.drupal.org/project/xmlsitemap/issues/2864290 (added test for the patch)
https://www.drupal.org/project/xmlsitemap/issues/2932993
https://www.drupal.org/project/xmlsitemap/issues/2646152
https://www.drupal.org/project/xmlsitemap/issues/1481798
https://www.drupal.org/project/xmlsitemap/issues/1918478
https://www.drupal.org/project/xmlsitemap/issues/2943217
https://www.drupal.org/project/xmlsitemap/issues/2776447
https://www.drupal.org/project/xmlsitemap/issues/2852713
https://www.drupal.org/project/xmlsitemap/issues/2950567
https://www.drupal.org/project/xmlsitemap/issues/2944085
https://www.drupal.org/project/xmlsitemap/issues/1966512
https://www.drupal.org/project/xmlsitemap/issues/2958535

PS:
The version of the module has already 2 years of testing problem. It is not fixed. Also, there is virtually no support for the 7 version of the module.