xmlsitemap_menu failing to properly create sitemaps for other languages. [#1966512]

Problem:

Sitemap generation would only work for the current language - other languages would be incomplete or contain links to the wrong nodes.

Steps to reproduce;

1. Install Drupal 7, i18n and xmlsitemap.
2. Set up multiple languages, create some translated nodes with custom paths.
3. Set up a menu - set the menu translation mode to "Translate and Localize"
4. Create menu items for different languages, to the various different nodes.
5. On the front end, the menu will only show items that match the current language - so you can swap out menu items for specific languages.
6. Create a sitemap for each language.
7. Run Cron. The site map for the current language will populate correctly, other languages will display incorrect links, and without their aliases.

I tracked the problem down the xmlsitemap_menu_create_link function.

This was looking for the menu item's language in the wrong place, so all menu items were given "language undefined" UND.

Also the way that the menu works in "Translate and Localize" mode is that when the menu is displayed, any menu items that don't match the current language (or are language neutral) are hidden. This causes all other links to be set as inaccessible in the xmlsitemap table.

Comment	File	Size	Author
#26	Screen Shot 2016-03-09 at 4.22.44 PM.png	54.9 KB	RavindraSingh
#20	xmlsitemap_menu-1966512-17.patch	1.29 KB	jyraya
#17	xmlsitemap_menu-1966512-16.patch	1.47 KB	jyraya
#15	xmlsitemap_menu-1966512-14.patch	1.49 KB	jyraya
#7	xmlsitemap_menu-1966512-7.patch	984 bytes	vladan.me
#1	xmlsitemap-1966512.patch	983 bytes	silloyd

Comments

Comment #1

silloyd commented 10 April 2013 at 12:09

Status	File	Size
new	xmlsitemap-1966512.patch	983 bytes

Patch attached that fixes the issue for me.

Comment #2

ludo.r

Brussels

commented 25 July 2013 at 10:41

Status:

Active

» Needs review

This patch works perfectly for me.

My menus are set to " Fixed Language".

Comment #3

25 July 2013 at 10:44

Status:

Needs review

» Needs work

The last submitted patch, xmlsitemap-1966512.patch, failed testing.

Comment #3.0

(not verified) commented 25 July 2013 at 10:44

Issue summary:

View changes

edit

Comment #4

tolasam commented 24 March 2014 at 18:57

Status:

Needs work

» Needs review

1: xmlsitemap-1966512.patch queued for re-testing.

Comment #5

24 March 2014 at 19:00

Status:

Needs review

» Needs work

The last submitted patch, 1: xmlsitemap-1966512.patch, failed testing.

Comment #6

dr.osd commented 30 October 2014 at 02:44

Issue summary:

View changes

Same problem. Appliyng patch missing node/xx and taxonomy/xx path links from sitemap.xml in not base language.

Comment #7

vladan.me commented 21 December 2014 at 22:56

Status:

Needs work

» Needs review

Status	File	Size
new	xmlsitemap_menu-1966512-7.patch	984 bytes

This patch actually should fix both issues mentioned in XML generation process
+ $menu_item['xmlsitemap']['access'] = $menu_item['access'] && !$menu_item['external'];
This allows menus that are wrongly interpreted as hidden (i18n issue) to be visible.

+  $menu_item['xmlsitemap']['language'] = isset($menu_item['language']) ? $menu_item['language'] : LANGUAGE_NONE;

This sets appropriate language of the menu item so it gets set well while generating links and figuring out if menu should be visible or not.
Rolling the same patch.

Comment #8

vladan.me commented 22 December 2014 at 00:22

Related issues:

+#2395459: XML generation process

Probably needs some additional tests since nothing fails.

Comment #9

simon georges commented 4 February 2015 at 15:33

I can confirm it's much better with the patch than without (unfortunately, still not perfect, but much much better).

Comment #10

simon georges commented 13 February 2015 at 14:20

Nevermind, I had an issue with the data of my menu.
I can confirm my sitemaps now exactly match the status of the menus and the languages. Thanks a lot for the patch, this is really needed for websites with i18n.

Comment #11

giupenni commented 14 February 2015 at 00:35

Works like a charm.

Thank you.

Comment #12

simon georges commented 16 February 2015 at 13:11

Status:

Needs review

» Reviewed & tested by the community

Ok, I think that qualifies as several reviews ;-)

Comment #13

dave reid

he/him

English

Nebraska USA

commented 19 February 2015 at 16:13

If I wasn't using i18n, what affect does removing the check on $item['hidden'] have? Do we know the side effects of that change?

Comment #14

jyraya commented 20 March 2015 at 11:26

I agree with Dave Reid, removing simply $item['hidden'] is not the best solution because what do we do if the menu link is actually hidden?

After debugging the full process determining the value of 'hidden', I observed that "xmlsitempap_menu" use "menu_link_load" function to load the menu link.

Before returning the menu item, it translates it.

In my environment but I think it is also the case in yours, "I18N menu" alters this translation process by, amongst other actions, forcing the attribute 'hidden' to TRUE if the menu link language does equal to "LANGUAGE_NONE" ("und") or to the interface language.

So to solve the problem, I see so far 2 possibilities:

We could try to force the language of the interface in order that the I18N alteration does not set "hidden" to TRUE. I cannot figure out yet how to do it and all side-effects that can have to proceed like that.
In the function "xmlsitemap_menu_create_link", we could check if the menu link is actually hidden or not by querying the table "menu_links".

In my opinion, the 2nd possibility is the easiest one to implement. The patch "xmlsitemap_menu-1966512-14.patch" could be an implementation.

Comment #15

jyraya commented 20 March 2015 at 11:26

Status	File	Size
new	xmlsitemap_menu-1966512-14.patch	1.49 KB

Comment #16

20 March 2015 at 11:31

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 15: xmlsitemap_menu-1966512-14.patch, failed testing.

Comment #17

jyraya commented 20 March 2015 at 13:35

Status	File	Size
new	xmlsitemap_menu-1966512-16.patch	1.47 KB

New version, I will not meet EOL problems this time.

Comment #18

jyraya commented 20 March 2015 at 13:37

Status:

Needs work

» Needs review

Comment #19

20 March 2015 at 13:40

Status:

Needs review

» Needs work

The last submitted patch, 17: xmlsitemap_menu-1966512-16.patch, failed testing.

Comment #20

jyraya commented 20 March 2015 at 13:51

Status:

Needs work

» Needs review

Status	File	Size
new	xmlsitemap_menu-1966512-17.patch	1.29 KB

Last try.

Comment #21

justb3a commented 27 April 2015 at 11:13

#20 works for me. Thanks!

Comment #22

steveoriol

Grenoble 🇫🇷

commented 9 August 2015 at 09:43

#20 works for me. Thanks!

Comment #23

alvar0hurtad0

he/him

Spanish

Cáceres

commented 25 February 2016 at 21:47

Status:

Needs review

» Reviewed & tested by the community

yes, it works.

Comment #24

RavindraSingh commented 7 March 2016 at 10:55

Status:

Reviewed & tested by the community

» Needs work

Reopening it, as this is not working with 7.x-2.2 release.
It is still adding duplicate and adding node/nid URLs.

Comment #25

dave reid

he/him

English

Nebraska USA

commented 8 March 2016 at 18:15

This should be going inside the xmlsitemap_i18n submodule to alter the default link values generated by xmlsitemap_menu. xmlsitemap_menu should know *nothing* about i18n and should only support what core supports.

Comment #26

RavindraSingh commented 9 March 2016 at 16:49

Status	File	Size
new	Screen Shot 2016-03-09 at 4.22.44 PM.png	54.9 KB

Nope, it looks like when nodes are getting duplicate from the xmlsitemap_node submodule.

Node

commented 11 March 2018 at 22:20

Status:

Needs work

» Needs review

4 files were hidden/shown/deleted

Status	File	Size
hidden	xmlsitemap-1966512.patch	983 bytes
hidden	xmlsitemap_menu-1966512-7.patch	984 bytes
hidden	xmlsitemap_menu-1966512-14.patch	1.49 KB
hidden	xmlsitemap_menu-1966512-16.patch	1.47 KB