Problem/Motivation

It would be great to allow admins to specify per entity inclusion in the site map instead of using the global 'administer xmlsitemap' permission, which grants a bunch of extra stuff we don't want admins tampering with.

Proposed resolution

Add a new permission.

Remaining tasks

Patch.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 2776447-9.patch2.34 KBacbramley
#7 interdiff-2776447-6-7.txt1.99 KBacbramley
#7 2776447-7.patch2.34 KBacbramley
#5 2776447-new-permission-5.patch1.22 KBSpadXIII
#2 2776447-new-permission-2.patch1.4 KBSam152

Issue fork xmlsitemap-2776447

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Sam152 CreditAttribution: Sam152 at PreviousNext commented
Status: Active » Needs review
FileSize
2776447-new-permission-2.patch1.4 KB

New permission.

Status: Needs review » Needs work

The last submitted patch, 2: 2776447-new-permission-2.patch, failed testing.

The last submitted patch, 2: 2776447-new-permission-2.patch, failed testing.

SpadXIII’s picture

SpadXIII CreditAttribution: SpadXIII at ezCompany commented
FileSize
2776447-new-permission-5.patch1.22 KB

We have just updated the patch to apply to the latest dev.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
Status: Needs work » Needs review

You need to add a patch test.

acbramley’s picture

acbramley CreditAttribution: acbramley at PreviousNext for Service NSW commented
FileSize
2776447-7.patch2.34 KB
interdiff-2776447-6-7.txt1.99 KB

Rerolled against latest dev. I've kept the original permission there as well to avoid an upgrade path and it makes sense that those users should also have access. I've also added a test case.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper at PreviousNext commented
Issue tags: +#pnx-sprint
acbramley’s picture

acbramley CreditAttribution: acbramley at PreviousNext for Service NSW commented
FileSize
2776447-9.patch2.34 KB

Straight reroll.

rbrownell’s picture

rbrownell
Primary language English
Location Ottawa, Ontario, Canada
CreditAttribution: rbrownell at Bounteous commented
Status: Needs review » Reviewed & tested by the community

Just tested this patch and it delivers the promised result. The code behind the patch is uncomplicated and looks good. I think this should be merged into a release.

chegor’s picture

chegor CreditAttribution: chegor as a volunteer commented

+1 RTBC

Dave Reid made their first commit to this issue’s fork.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
Status: Reviewed & tested by the community » Needs work

Patch did not apply and I don't love the name using "administer" in the label. I'd rather prefer "override xmlsitemap link settings". The included test also doesn't actually verify that the new permission allows users to see the fields on node forms like we are trying to fix.

Dave Reid opened merge request !20

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
Status: Needs work » Needs review

  • Dave Reid committed 265decf on 8.x-1.x 
    Issue #2776447: Added a new "override xmlsitemap link settings"...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot for Principal Financial Group commented
Status: Needs review » Fixed

Committed the MR to 8.x-1.x. Thanks all!

  • Dave Reid committed 265decf on 2.x 
    Issue #2776447: Added a new "override xmlsitemap link settings"...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.