Problem/Motivation

The query destination key is wrong mapped, causing not redirecting to the previous form.

URL: http://example.com/admin/config/search/xmlsitemap/entities/settings
Form: XmlSitemapEntitiesSettingsForm

Link Url created before patch: /admin/config/search/xmlsitemap/settings/node/article?query%5Bdestination%5D=/admin/config/search/xmlsitemap/entities/settings

Link Url created after patch: /admin/config/search/xmlsitemap/settings/node/article?destination=/admin/config/search/xmlsitemap/entities/settings

Proposed resolution

Code fix

Remaining tasks

- Review/commit patch

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 After_patch.png99.82 KBAanal.addweb
#3 Before_patch.png88.28 KBAanal.addweb
#2 xmlsitemap-xmlsitemapentitiessettingsform-destination-query-2931593-2.patch680 bytesGeduR
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

GeduR created an issue. See original summary.

GeduR’s picture

GeduR CreditAttribution: GeduR at Metadrop commented
Status: Active » Needs review
FileSize
xmlsitemap-xmlsitemapentitiessettingsform-destination-query-2931593-2.patch680 bytes

Please review!

Aanal.addweb’s picture

Aanal.addweb CreditAttribution: Aanal.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
Before_patch.png88.28 KB
After_patch.png99.82 KB

@GeduR, Thanks for providing the patch, It works as expected & As per the given requirement. I Checked it using simplytest.me & attached the results for the same.

tunic’s picture

tunic
he/him
Primary language Spanish
Location Madrid
CreditAttribution: tunic at Metadrop commented
Status: Needs review » Reviewed & tested by the community

Simple patch, received feedback is good, moving to RTBC.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
Status: Reviewed & tested by the community » Needs work

the patch did not pass automatic tests because we need fix tests for dev version module

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
Status: Needs work » Reviewed & tested by the community
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented

  • pifagor committed 23b04ea on 8.x-1.x authored by GeduR 
    Issue #2931593 by GeduR, dhwani.addweb, pifagor, tunic: Wrong...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.