If Tippy is not installed, generally element descriptions are used instead. However, the value of #admin_notes still appears as the Tippy question mark, but it does not work; no tooltip is displayed.

CommentFileSizeAuthor
#2 webform.webform.issue_3403835.yml4.87 KBjrockowitz
#2 search-for-webform_help.txt3.3 KBjrockowitz

Issue fork webform-3403835

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Liam Morland created an issue. See original summary.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
Status: Active » Needs work
FileSize
search-for-webform_help.txt3.3 KB
webform.webform.issue_3403835.yml4.87 KB

The attached webform can be used to show most of the areas impacted when the tippyjs library is disabled.

Features/areas impacted.

  • Admin notes - Question mark is displayed with no tooltip
  • Webform shortcuts - Question mark is displayed with no tooltip
  • Element - Nothing is displayed

Notes

  • Configuration/Settings elements are fine because the #description is displayed below the element.
  • Anywhere is '#type' = 'webform_help' is impacted (see attached text file)

Thoughts

  • If this is the first time someone is noting this issue, it might not be an issue because no one is disabling tippyjs.
  • We could stop people from disabling tippyjs or display a warning when the do disable tippyjs.
  • We could block the rendering to an empty question mark via \Drupal\webform\Element\WebformHelp.
Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at OpenPlus commented

I noticed it now because I hadn't used #admin_notes before. I've always had a few JS libraries as possible enabled, just Tabby because the UI doesn't work properly without it. I think it would be best if the #admin_notes much like the descriptions do for other elements with Tippy is disabled.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
Status: Needs work » Needs review

Let's agree to fix your immediate issue with #admin_notes and address other tippyjs issues as the come up.

jrockowitz opened merge request !384

  • jrockowitz committed 34d926cb on 6.2.x 
    Issue #3403835: #admin_notes do not appear without Tippy
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at Webform module Open Collective, The Big Blue House commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.