Write dedicated rendering tests [#2922896]

Problem/Motivation

Webform module output submission data in multiple formats including HTML, plain text, and email using render array, tokens, and Twig. By default, Drupal 8 escapes all HTML tags, which is causing issues for plain text emails.

Proposed resolution

Write dedicated rendering tests

Remaining tasks

List all possible render scenarios
Document what is being rendered where
Make sure email is always consider SafeMarkup
Write dedicated test form
Clean update the Webform module rendering pipeline
Write tests

Comment	File	Size	Author
#29	2922896-rendering-tests-30.patch	52.26 KB	jrockowitz
#29	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 646 pass
#26	2922896-rendering-tests-27.patch	52.08 KB	jrockowitz
#26	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 645 pass, 1 fail PHP 5.6 & MySQL 5.5, D8.4 645 pass, 1 fail
#24	2922896-rendering-tests-24.patch	51.56 KB	jrockowitz
#24	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 645 pass, 1 fail
#20	2922896-rendering-tests-20.patch	46.35 KB	jrockowitz
#20	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 641 pass
#17	2922896-rendering-tests-17.patch	31.06 KB	jrockowitz
#17	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 641 pass
#14	2922896-rendering-tests-14.patch	12.91 KB	jrockowitz
#14	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 640 pass, 1 fail
#11	2922896-rendering-tests-11.patch	12.84 KB	jrockowitz
#11	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 635 pass, 15 fail
#8	2922896-rendering-tests-8.patch	0 bytes	jrockowitz
#8	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 Patch Failed to Apply
#4	2922896-rendering-tests-3.patch	4.4 KB	jrockowitz
#4	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 Patch Failed to Apply
#2	2922896-rendering-tests-1-.patch	4.52 KB	jrockowitz
#2	8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 639 pass, 2 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

12 November 2017 at 22:29

jrockowitz created an issue. See original summary.

Comment #2

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 13 November 2017 at 21:06

Status:

Active

» Needs review

File	Size
2922896-rendering-tests-1-.patch	4.52 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 639 pass, 2 fail

Comment #3

13 November 2017 at 21:26

Status:

Needs review

» Needs work

The last submitted patch, 2: 2922896-rendering-tests-1-.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #4

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 13 November 2017 at 22:01

Status:

Needs work

» Needs review

File	Size
2922896-rendering-tests-3.patch	4.4 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 Patch Failed to Apply

Comment #5

13 November 2017 at 22:03

jrockowitz committed 432b786 on 2922896-rendering-tests
```
Issue #2922896: Write dedicated rendering tests
```

Comment #6

13 November 2017 at 22:08

Status:

Needs review

» Needs work

The last submitted patch, 4: 2922896-rendering-tests-3.patch, failed testing. View results

Comment #7

13 November 2017 at 22:09

jrockowitz committed bcae673 on 2922896-rendering-tests
```
Issue #2922896: Write dedicated rendering tests
```

Comment #8

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 13 November 2017 at 22:10

Status:

Needs work

» Needs review

File	Size
2922896-rendering-tests-8.patch	0 bytes
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 Patch Failed to Apply

Comment #9

13 November 2017 at 22:14

Status:

Needs review

» Needs work

The last submitted patch, 8: 2922896-rendering-tests-8.patch, failed testing. View results

Comment #10

13 November 2017 at 23:11

jrockowitz committed 0c7c684 on 2922896-rendering-tests
```
Issue #2922896: Write dedicated rendering tests
```

Comment #11

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 13 November 2017 at 23:13

Status:

Needs work

» Needs review

File	Size
2922896-rendering-tests-11.patch	12.84 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 635 pass, 15 fail

Comment #12

13 November 2017 at 23:25

Status:

Needs review

» Needs work

The last submitted patch, 11: 2922896-rendering-tests-11.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #13

13 November 2017 at 23:29

jrockowitz committed c3cab53 on 2922896-rendering-tests
```
Issue #2922896: Write dedicated rendering tests
```

Comment #14

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 13 November 2017 at 23:29

Status:

Needs work

» Needs review

File	Size
2922896-rendering-tests-14.patch	12.91 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 640 pass, 1 fail

Comment #15

13 November 2017 at 23:42

Status:

Needs review

» Needs work

The last submitted patch, 14: 2922896-rendering-tests-14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #16

13 November 2017 at 23:53

jrockowitz committed bbd2d86 on 2922896-rendering-tests
```
Issue #2922896: Write dedicated rendering tests
```

Comment #17

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 13 November 2017 at 23:54

Status:

Needs work

» Needs review

File	Size
2922896-rendering-tests-17.patch	31.06 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 641 pass

Comment #18

14 November 2017 at 01:44

jrockowitz committed 97a4a02 on 2922896-rendering-tests
```
Issue #2922896: Write dedicated rendering tests
```

Comment #19

14 November 2017 at 02:29

jrockowitz committed dbe74ad on 2922896-rendering-tests

Issue #2922896: Write dedicated rendering tests. Fix resend form.

Comment #20

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 14 November 2017 at 02:30

File	Size
2922896-rendering-tests-20.patch	46.35 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 641 pass

Comment #21

14 November 2017 at 02:44

jrockowitz committed 71d3016 on 2922896-rendering-tests

Issue #2922896: Write dedicated rendering tests. Allow handlers to...

Comment #22

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 14 November 2017 at 03:06

Comment #23

14 November 2017 at 04:02

jrockowitz committed 979bf17 on 2922896-rendering-tests

Issue #2922896: Write dedicated rendering tests. Write tests.

Comment #24

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 14 November 2017 at 04:02

File	Size
2922896-rendering-tests-24.patch	51.56 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 645 pass, 1 fail

Comment #25

14 November 2017 at 04:19

Status:

Needs review

» Needs work

The last submitted patch, 24: 2922896-rendering-tests-24.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #26

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 14 November 2017 at 04:26

Status:

Needs work

» Needs review

File	Size
2922896-rendering-tests-27.patch	52.08 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 645 pass, 1 fail PHP 5.6 & MySQL 5.5, D8.4 645 pass, 1 fail

Comment #27

14 November 2017 at 04:43

Status:

Needs review

» Needs work

The last submitted patch, 26: 2922896-rendering-tests-27.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #28

14 November 2017 at 04:54

jrockowitz committed 19d32ff on 2922896-rendering-tests

Issue #2922896: Write dedicated rendering tests. Write tests.

Comment #29

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 14 November 2017 at 04:54

Status:

Needs work

» Needs review

File	Size
2922896-rendering-tests-30.patch	52.26 KB
8.x-5.x: PHP 5.6 & MySQL 5.5, D8.3 646 pass

Comment #30

14 November 2017 at 12:38

jrockowitz committed 0a7d1f0 on 8.x-5.x

Issue #2922896 by jrockowitz: Write dedicated rendering tests

Comment #31

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented 14 November 2017 at 12:38

Status:

Needs review

» Fixed

Comment #32

28 November 2017 at 12:39

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Write dedicated rendering tests

Problem/Motivation

Proposed resolution

Remaining tasks

Comments

Related issues

Referenced by