Fatal error: Declaration of Drupal\video_embed_html5\Plugin\video_embed_field\Provider\Html5::renderEmbedCode($width, $height, $autoplay) must be compatible with Drupal\video_embed_field\ProviderPluginInterface::renderEmbedCode($width, $height, $autoplay, $loop, $mute, $controls, $rel) in /modules/contrib/video_embed_html5/src/Plugin/video_embed_field/Provider/Html5.php on line 0

We have to add the parameters:

  /**
   * Render embed code.
   *
   * @param string $width
   *   The width of the video player.
   * @param string $height
   *   The height of the video player.
   * @param bool $autoplay
   *   If the video should autoplay.
   * @param bool $loop
   *   If the video should loop.
   * @param bool $mute
   *   If the video should play muted.
   * @param bool $controls
   *   Whether show controls (youtube only).
   * @param bool $rel
   *   Whether show related videos (youtube only).
   *
   * @return mixed
   *   A renderable array of the embed code.
   */
  public function renderEmbedCode($width, $height, $autoplay, $loop, $mute, $controls, $rel);
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anybody created an issue. See original summary.

Anybody’s picture

Patch attached, please review because the current module version is broken.

Status: Needs review » Needs work

The last submitted patch, 2: video_embed_html5_renderEmbedCodeParametersFix_3159736-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Anybody’s picture

Title: Html5::renderEmbedCode parameters not compatible with ProviderPluginInterface::renderEmbedCode » Youtube looping (#2866001): Html5::renderEmbedCode parameters not compatible with ProviderPluginInterface::renderEmbedCode
Category: Bug report » Feature request
Priority: Major » Minor
Status: Needs work » Needs review
Parent issue: » #2866001: Youtube looping

Sorry! The issue is based on a patch from #2866001: Youtube looping which also requires alignments in all dependent modules.