CommentFileSizeAuthor
#7 drupal-practice-errors-3117686-7.patch23.16 KBnarendra.rajwar27
#2 drupal-practice-errors-3117686-2.patch24.21 KBakshay_d
Screenshot 2020-03-04 at 3.53.22 PM.png429.09 KBakshay_d
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akshay_d created an issue. See original summary.

akshay_d’s picture

akshay_d
Primary language Kannada
Location Bangalore
CreditAttribution: akshay_d at Specbee commented
Assigned: akshay_d » Unassigned
Status: Active » Needs review
FileSize
drupal-practice-errors-3117686-2.patch24.21 KB

Fixed all the practice errors and injected dependency
, please review

JeroenT credited Maithri Shetty.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs review » Needs work

Patch no longer applies.

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language Hindi
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Material for Drupal India Association commented
Assigned: Unassigned » narendra.rajwar27
narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language Hindi
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Material for Drupal India Association commented
Status: Needs work » Needs review
FileSize
drupal-practice-errors-3117686-7.patch23.16 KB

Re-rolled the patch in #2.

narendra.rajwar27’s picture

narendra.rajwar27
he/him
Primary language Hindi
Location India
CreditAttribution: narendra.rajwar27 as a volunteer and at Material for Drupal India Association commented
Assigned: narendra.rajwar27 » Unassigned

I have no clue that it is still assigned to me. Unassigning the issue.

Takuma Shimabukuro’s picture

Takuma Shimabukuro CreditAttribution: Takuma Shimabukuro at CI&T commented
Assigned: Unassigned » Takuma Shimabukuro
Status: Needs review » Reviewed & tested by the community

Hi narendra.rajwar27 , I ran the phpcs commands, but it still show error to me.
I fixed it on issue I found a lot of format errors in the module..
Please review it.

Takuma Shimabukuro’s picture

Takuma Shimabukuro CreditAttribution: Takuma Shimabukuro at CI&T commented
Assigned: Takuma Shimabukuro » Unassigned