White screen of death when viewing order salesforce tab

Hey there,

This was totally puzzling to me at first. I just started testing the newest dev versions of the salesforce_api and uc_salesforce and suddenly noticed that browsing to the "salesforce" tab of any ubercart order was now resulting in a white screen of death. Upon consulting the error log I noticed:

PHP Fatal error: Call to undefined method stdClass::retrieve()

Upon checking uc_sf_order.module I see the line (around 530):

$data = $sf->retrieve(array($order->salesforce->sfid), $order->salesforce->name);

which seems to be where the error is sourced from. What is so strange about this is that I am certain that I was able to open an order's "salesforce" tab in the past, while using the same uc_sf_order.module code. Even looking back at very old revisions of uc_sf_order.module (which I know have not shown this problem) I see this same $data = $sf->retrieve[...] line.

Anyway, I searched around the api code for similar "retrieve" patterns/functions and noticed that instead of $sf->retrieve(), salesforce_api_retrieve() seems to be used as a wrapper that eventually calls$sf->client->retrieve(). So my guess is that the above line should be:

$data = salesforce_api_retrieve(array($order->salesforce->sfid), $order->salesforce->name);

Upon making this change, things seem to work again.

So I'm guessing that something about the API changed recently which broke things. Perhaps there is some clue at #1046692: [refactoring] Get rid of salesforce.class.inc? I'm guessing that any use of $sf->retrieve() should be replaced with salesforce_api_retrieve().

Ryan