On validation error for telephone field, error message shown is '@telephone' is invalid. It will be better if we show the number itself.

CommentFileSizeAuthor
#5 telephone_is_invalid-2729091-5.patch1.27 KBzaporylie
#2 telephone_invalid-2729091-2.patch502 byteszuhair_ak
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zuhair_ak created an issue. See original summary.

zuhair_ak’s picture

zuhair_ak
He/Him
Primary language Malayalam
Location Dubai
CreditAttribution: zuhair_ak at Zyxware Technologies commented
Status: Active » Needs review
FileSize
telephone_invalid-2729091-2.patch502 bytes

I have added a patch changing the variable @telephone to @number which shows the number.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie at Ny Media AS commented

You are absoluty right, but your patch needs reroll. Hope you don't mind if I fix and merge it.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie at Ny Media AS commented
Status: Needs review » Needs work
Issue tags: +#drupalironcamp
zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie at Ny Media AS commented
FileSize
telephone_is_invalid-2729091-5.patch1.27 KB

Here's rerolled patch.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie at Ny Media AS commented
Status: Needs work » Needs review

  • zaporylie committed ff8115b on 8.x-2.x 
    Issue #2729091 by zaporylie, zuhair_ak: '@telephone' is invalid on...
zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie at Ny Media AS commented
Status: Needs review » Fixed
zuhair_ak’s picture

zuhair_ak
He/Him
Primary language Malayalam
Location Dubai
CreditAttribution: zuhair_ak at Zyxware Technologies commented

Thanks for the reroll and merging the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.