Move display related settings from manage fields to manage display. As for the suggestion made in comment #5 in #2816395: Make it possible to disable sticky table headers:

I understand why the setting was added in the manage fields section, as there are other settings related to the header, however it would make more sense to add it to manage display, because it is a display setting. For that maybe a new issue should be created.

See screenshots.

Screenshot

Screenshot

CommentFileSizeAuthor
#19 Manage display Drush Site Install.jpg113.7 KBlolandese
#19 Basic page Site Install.jpg105.75 KBlolandese
#14 move_display_settings_to_manage_display_form-2841782-14.patch11.39 KBlolandese
#12 move_display_settings_to_manage_display_form-2841782-12.patch12 KBlolandese
#11 move_display_settings_to_manage_display_form-2841782-11.patch10.44 KBlolandese
#8 move_display_settings_to_manage_display_form-2841782-6.patch9.91 KBlolandese
#7 Basic page purple.dev_.jpeg69.58 KBlolandese
#5 move_display_settings_to_manage_display_form-2841782-5.patch6.68 KBlolandese
#4 move_display_settings_to_manage_display_form-2841782-4.patch2.63 KBlolandese
Basic page purple.dev_.png89.88 KBlolandese
Table purple.dev_.png89.86 KBlolandese
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lolandese created an issue. See original summary.

lolandese’s picture

lolandese CreditAttribution: lolandese at HCL Technologies Limited commented
Issue summary: View changes
lolandese’s picture

lolandese CreditAttribution: lolandese at HCL Technologies Limited commented
Issue summary: View changes
Related issues: +#2816395: Make it possible to disable sticky table headers
lolandese’s picture

lolandese CreditAttribution: lolandese at HCL Technologies Limited commented
Status: Active » Needs work
FileSize
move_display_settings_to_manage_display_form-2841782-4.patch2.63 KB

Initial patch moving only the 'Sticky header' setting for now.

lolandese’s picture

lolandese CreditAttribution: lolandese at HCL Technologies Limited commented
FileSize
move_display_settings_to_manage_display_form-2841782-5.patch6.68 KB

Added also the 'Hide table header row' settings. One to go (Show link to export table data as CSV).

lolandese’s picture

lolandese CreditAttribution: lolandese at HCL Technologies Limited commented
Status: Needs work » Needs review

Added also 'Show link to export table data as CSV depending on permission' (with a link to the relevant section of the permission settings page).

Now we can differ the display of a table per display type (default, full node, teaser, etc.).

Screenshot

Last thing to do is to provide an upgrade path where field settings are migrated to display settings for all entities (nodes, taxonomies, users) with displays that contain a table field.

lolandese’s picture

lolandese CreditAttribution: lolandese at HCL Technologies Limited commented
FileSize
Basic page purple.dev_.jpeg69.58 KB
lolandese’s picture

lolandese CreditAttribution: lolandese at HCL Technologies Limited commented
FileSize
move_display_settings_to_manage_display_form-2841782-6.patch9.91 KB

Attaching forgotten patch of #6.

gopisathya’s picture

gopisathya CreditAttribution: gopisathya at HCL Technologies Limited commented
Status: Needs review » Reviewed & tested by the community

In this case its logical to move the field settings to Manage Display. Still need the upgrade path.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton at Jeneration Web Development commented
Status: Reviewed & tested by the community » Needs work

I love what I see going on here, I think this will be a great usability improvement :)

However, If we still need the upgrade path, this patch is not yet RTBC, so changing status.

lolandese’s picture

lolandese CreditAttribution: lolandese at HCL Technologies Limited commented
FileSize
move_display_settings_to_manage_display_form-2841782-11.patch10.44 KB

Reroll against latest dev.

lolandese’s picture

lolandese CreditAttribution: lolandese at HCL Technologies Limited commented
Status: Needs work » Needs review
FileSize
move_display_settings_to_manage_display_form-2841782-12.patch12 KB

Included upgrade path from latest stable (7.x-2.5) to latest dev.

gopisathya’s picture

gopisathya CreditAttribution: gopisathya at HCL Technologies Limited commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly.
It retains the old values from the field settings to manage display settings.

lolandese’s picture

lolandese CreditAttribution: lolandese at HCL Technologies Limited commented
FileSize
move_display_settings_to_manage_display_form-2841782-14.patch11.39 KB

Reroll against latest dev.

  • lolandese committed a02aa11 on 7.x-2.x 
    Issue #2841782 by lolandese: Move display related settings from manage...
lolandese’s picture

lolandese CreditAttribution: lolandese at HCL Technologies Limited commented
Status: Reviewed & tested by the community » Fixed

  • lolandese committed a02aa11 on 7.x-3.x 
    Issue #2841782 by lolandese: Move display related settings from manage...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

lolandese’s picture

lolandese CreditAttribution: lolandese as a volunteer and commented
Version: 7.x-2.x-dev » 8.x-2.x-dev
Status: Closed (fixed) » Patch (to be ported)
Parent issue: » #2189203: D8 port (from the existing 7.x-3.x to a new 8.x-3.x)
FileSize
Basic page Site Install.jpg105.75 KB
Manage display Drush Site Install.jpg113.7 KB

Compare D8 with D7 below:

Screenshot

Screenshot

Depending on the fact if these features are available in D8, we should move (option with default value):

  • Header orientation: Horizontal
  • Sticky header: Yes
  • Striping (odd/even class): Yes
  • Sortable: Disabled
  • Hide first row: No
  • Hide empty columns ignoring column header: No
  • Trim empty trailing rows: No
  • Trim empty trailing columns: No
  • Hide empty rows: No
  • Hide empty columns: No
  • Show link to export table data as CSV depending on permission: No