Problem/Motivation

Remove composer.json from the module document. As the individual composer.json in module folder is not necessary anymore if the module does not have explict dependency.

Proposed resolution

Provide the patch

Remaining tasks

User interface changes

API changes

Data model changes

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Issue summary: View changes
Status: Active » Fixed

Added the commit.

aks22’s picture

aks22 CreditAttribution: aks22 as a volunteer and at Cybage Software Pvt Ltd. commented

Hi Naveen,

As per below post can we add composer.json with minimum definitions for PHP community support?

https://www.drupal.org/node/2514612
https://www.drupal.org/node/2404989

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented

@aks22 ,

Yup as sharethis is only a drupal module and rely on lots of drupal core services and modules to work so I don't think its needed at the moment when later when durpal core components will be exposed outside the drupal then we can add the composer.json

Also sharethis does not require any external library to work.

if you're using it in your PHP project then i would love to add.Btw I would love to know how're you using it
Thanks for your concern!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.