Closed (fixed)
Project:
ShareThis
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
22 Jan 2016 at 14:44 UTC
Updated:
7 Feb 2016 at 16:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
naveenvalechaComment #3
naveenvalechaComment #4
miteshmapComment #5
miteshmapComment #7
naveenvalechaThanks for the initial patch, its a great start.
I have comitted the #5 to a new coder branch for checking have we addressed all, and here's we need some more love http://pareview.sh/pareview/httpgitdrupalorgprojectsharethisgit-coder
Edit : Ignore the test failure.
Comment #8
miteshmap@naveenvalecha: Thank you for the quick update.
I could apply the patch, so no reroll is needed.
Comment #9
miteshmapComment #10
miteshmapAdded a new complete patch, previous patch was not good.
Comment #13
naveenvalechaThanks for the updated patch!! @miteshmap
I have committed the #10 to a coder branch for checking have we addressed all, and here's we need some more love http://pareview.sh/pareview/httpgitdrupalorgprojectsharethisgit-coder
We are just few steps away for pushing this in.
Quick Overview :
why did we broke the comment line so early
It would be "The sharethis Manager."
It would be "The Sharethis Manager."
we also need a @return for the return type of the function
we still need the description of these parameters.
let's use the short arrays here and please don't broke the array elements line with starting element.
Same here short arrays.
let's use the short arrays here and please don't broke the array elements line with starting element.
Comment #14
harsha012 commentedAdded patch as per Comment 13
Comment #15
naveenvalechaunrelated change.
I have no reviewed the patch b/c the the patch file size is also small but it should be more than #10
@harsha012,
please address the changes after applying #10, also provide the interdiff next time https://www.drupal.org/documentation/git/interdiff
Comment #16
snehi commentedRemoving mentioned unrelated changes.
Comment #18
naveenvalechaI have committed the patch #10 , the rest of the patches were not correct.
Please don't post the patches without reading the thread.
Comment #20
naveenvalechaI have created another followup issue for fixing the rest of the standards https://www.drupal.org/node/2655716
Thanks! for working on this.