This issue is for the plan for next release

  1. #2653412: Fixup random failures in tests
  2. #2659250: Cannot add ShareThis field to View
  3. #2672104: ShareThis is displayed even if the pseudo-field is set to hidden on the display settings
  4. #2672388: Changing the position of the ShareThis buttons doesn't have effect on them.
  5. #2659250: Cannot add ShareThis field to View
  6. #2722099: Not able to select services in the configuration page
  7. #2755679: Sharethis no share nodes.
  8. #2728639: Share this does not work when change content layout

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue summary: View changes
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue summary: View changes
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Sharethis - 8.x-2.0-beta2 » Sharethis - 8.x-2.0-beta3
Issue summary: View changes

Beta2 is out with following improvements :

  1. #2655016: Fix up the coding standards - Round 1
  2. #2655716: Fix up the coding standards - Round 2
  3. #2655022: Add Readme.txt file to the module
  4. #2681001: Remove depreciated methods in code base.
  5. #2688907: Fix up the coding standards - Round 3
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue summary: View changes

Updated issue summary.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue summary: View changes

Adding more issues

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue summary: View changes

updating issue summary.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: naveenvalecha » Unassigned
Issue summary: View changes
Status: Active » Fixed

Released beta3 with these improvements/changes :

  1. Issue #2728639 by navneet0693, heddn, naveenvalecha: Share this does not work when change content layout
  2. Issue #2755679 by edysmp, davidparedes21, naveenvalecha: Sharethis no share nodes
  3. Issue #2722099 by navneet0693, jeevanbhushetty, sajiniantony, naveenvalecha, tragic.rich: Not able to select services in the configuration page
  4. Issue #2659250 by heddn, naveenvalecha, Corregidor, edysmp: Cannot add ShareThis field to View
  5. Issue #2672388 by navneet0693, naveenvalecha, Yogesh Pawar: Changing the position of the ShareThis buttons doesn't have effect on them
  6. Issue #2702081 by mikey_p, xangy, naveenvalecha: Use secure version of button.js
  7. Issue #2672104 by adamwhite, navneet0693, naveenvalecha: ShareThis is displayed even if the pseudo-field is set to hidden on the display settings
  8. Issue #2699705 by navneet0693, jeevanbhushetty, naveenvalecha: Pathauto URL and URL alias are not fetched

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

lokeshsn22’s picture

lokeshsn22 commented

Hi,

When i install this module and preview the node, it gives me an error. The error is as below
"The "node" entity cannot have a URI as it does not have an ID". It works fine without this module. There is a patch mentioned for this issue, even i tried it, Its not working. The patch is in the url "https://www.drupal.org/node/2706325". Can someone take it up this issue.

Thanks,
Lokesh.S

rgristroph’s picture

rgristroph commented

Due to the necessity of using this: https://www.drupal.org/project/sharethis/issues/2885710 I am using a pinned commit on the dev branch in my composer.json.

Maybe we can make another beta or even a full release ?

I am also using a patch from here https://www.drupal.org/node/2816573 which would be nice to get into a beta.

If there are other issues that are blocking maybe I can help out on them.