Follow-up to #2655016: Fix up the coding standards - Round 1

http://pareview.sh/pareview/httpgitdrupalorgprojectsharethisgit-8x-2x

Fixup all the coding standards

Testing :

Setup the coder on your local and scan the module code whether there are not any coding standards pending.

CommentFileSizeAuthor
#33 2655716-32.patch27.9 KBnaveenvalecha
#31 2655716-30.patch28.44 KBnaveenvalecha
#28 sharethisfixcodeissues-2655716-25.patch782 bytesharsha012
#25 sharethis-fixcodeissue-2655716-24.patch4.84 KBharsha012
#25 interdiff-2655716-21-24.txt30.25 KBharsha012
#21 interdiff-21-12.txt2.43 KBmiteshmap
#21 sharethis-coding-standard-2655716-21.patch27.43 KBmiteshmap
#20 sharethis-fix-standard-code-2655716-20.patch5.64 KBharsha012
#18 fix-code-standard-2655716-16.patch6.7 KBharsha012
#16 2655716-16.patch6.7 KBharsha012
#16 interdiff-2655716-12-16.txt6.7 KBharsha012
#12 2655716-12.patch26.88 KBmiteshmap
#8 2655716-8.patch5.73 KBmiteshmap
#6 interdiff-2655716-2.patch18 KBharsha012
#5 interdiff-2655716-2.txt18 KBharsha012
#5 2655716-2.patch0 bytesharsha012

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue summary: View changes
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Fixed » Active
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Parent issue: #2655016: Fix up the coding standards - Round 1 » #2655010: Sharethis - 8.x-2.0-beta3
Related issues: +#2655016: Fix up the coding standards - Round 1
harsha012’s picture

harsha012 commented
StatusFileSize
new 2655716-2.patch0 bytes
new interdiff-2655716-2.txt18 KB

Added the Patch for the fixing the standard Code format

harsha012’s picture

harsha012 commented
StatusFileSize
new interdiff-2655716-2.patch18 KB
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue tags: -Novice

@harsha012,
please start a new patch and fix the remaining coding standards issue http://pareview.sh/pareview/httpgitdrupalorgprojectsharethisgit-8x-2x

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
StatusFileSize
new 2655716-8.patch5.73 KB

@naveenvalecha: Js errors and warnings are not resolved in patch, Not sure of how to use eslint. If you can provide me some link to setup and use. that will be help full. :)

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: 2655716-8.patch, failed testing.

naveenvalecha’s picture

naveenvalecha
He/Him
commented

Eslist drupal specific settings https://www.drupal.org/node/1955232
See how to use eslint http://eslint.org/docs/user-guide/command-line-interface
Thanks for sticking to this, we are new to RTBC after the Eslint and Reame.txt errors covers

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
StatusFileSize
new 2655716-12.patch26.88 KB

Thank you @naveenvalecha, Tried to remove errors as much as possible. :)

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 12: 2655716-12.patch, failed testing.

naveenvalecha’s picture

naveenvalecha
He/Him
commented

awesome work so far!, we have covered a lot to fix
I have pushed the #12 to a seperate branch 2655716-12 and after check its review , only few are pending
http://pareview.sh/pareview/httpgitdrupalorgprojectsharethisgit-2655716-12

Please post the interdiff next time so that I'll be able to view what changes have you done after #12
https://www.drupal.org/documentation/git/interdiff

harsha012’s picture

harsha012 commented
StatusFileSize
new interdiff-2655716-12-16.txt6.7 KB
new 2655716-16.patch6.7 KB

Added the Patch for the errors as per the #15

naveenvalecha’s picture

naveenvalecha
He/Him
commented

Re #16 : Did you forget to upload the right patch ? both are interdiffs

harsha012’s picture

harsha012 commented
StatusFileSize
new fix-code-standard-2655716-16.patch6.7 KB

@naveenvalecha: this is patch not a interdiff

naveenvalecha’s picture

naveenvalecha
He/Him
commented

@harsha112,
Please apply the patch #12 in your local branch and commit those changes and then checkout from that branch and create a new branch and address your changes and provide a patch then.
Please see how to reroll the patch https://www.drupal.org/patch/reroll

harsha012’s picture

harsha012 commented
StatusFileSize
new sharethis-fix-standard-code-2655716-20.patch5.64 KB

added the patch

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
StatusFileSize
new sharethis-coding-standard-2655716-21.patch27.43 KB
new interdiff-21-12.txt2.43 KB

Hi @naveenvalecha, Here are some more fixes with interdiff, against #12 ;) The indentions error are not covered in this patch, those are actually not shows up with drupalcs or best practice :( any thoughts?

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
Status: Needs work » Needs review
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Needs work

@miteshmap, that's great, nice fixes,yup we will also need to take care about the drupalcs as well.
I have comitted the #21 interdiff in branch 2655716-12
We have few more nitpicks that needs to fix http://pareview.sh/pareview/httpgitdrupalorgprojectsharethisgit-2655716-12

The last submitted patch, 21: sharethis-coding-standard-2655716-21.patch, failed testing.

harsha012’s picture

harsha012 commented
StatusFileSize
new interdiff-2655716-21-24.txt30.25 KB
new sharethis-fixcodeissue-2655716-24.patch4.84 KB

Hi @naveenvalecha, Here are the fixes of the error mentioned in http://pareview.sh/pareview/httpgitdrupalorgprojectsharethisgit-2655716-12.

harsha012’s picture

harsha012 commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 25: sharethis-fixcodeissue-2655716-24.patch, failed testing.

harsha012’s picture

harsha012 commented
StatusFileSize
new sharethisfixcodeissues-2655716-25.patch782 bytes

Added the Code for the test to pass

harsha012’s picture

harsha012 commented
Status: Needs work » Needs review
harsha012’s picture

harsha012 commented
Status: Needs review » Needs work
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs work » Needs review
StatusFileSize
new 2655716-30.patch28.44 KB

Leaving the rest of the js changes for Round 3(https://www.drupal.org/node/2663336#comment-10826012) b/c have open questions for the new changes.
Alright I have taken this up.Fixed more coding standards.
http://pareview.sh/pareview/httpgitdrupalorgprojectsharethisgit-2655716-30

Status: Needs review » Needs work

The last submitted patch, 31: 2655716-30.patch, failed testing.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: Unassigned » neetu morwani
StatusFileSize
new 2655716-32.patch27.9 KB

Assigning to neetu morwani for peer review.
http://pareview.sh/pareview/httpgitdrupalorgprojectsharethisgit-2655716-32

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue tags: +Novice, +Needs reroll
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll

Status: Needs review » Needs work

The last submitted patch, 33: 2655716-32.patch, failed testing.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: neetu morwani » Unassigned
Status: Needs work » Fixed

Committed and pushed to 8.x-2.x
Thanks!

  • naveenvalecha committed f7f454e on 8.x-2.x 
    Issue #2655716 by harsha012, miteshmap, naveenvalecha: Fix up the coding...

The last submitted patch, 28: sharethisfixcodeissues-2655716-25.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.