Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#2 queue_ui.3.1.4.rector.patch1.95 KBproject update bot

Issue fork queue_ui-3434070

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new1.95 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.9
  3. palantirnet/drupal-rector: 0.20.1

benstallings’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I was able to install & enable this in Drupal 11.

kubrt’s picture

Was able to install and enable 3.1.4 with patch #2, however, update status scan reports this issue as well

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Queue UI 3.1.4
Scanned on Thu, 08/15/2024 - 15:43.

web/modules/contrib/queue_ui/src/Form/ItemDetailForm.php:
+--------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status | line | message |
+--------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Ignore | 131 | Call to deprecated method renderPlain() of interface
Drupal\Core\Render\RendererInterface. Deprecated in
drupal:10.3.0 and is removed from drupal:12.0.0. Use
Drupal\Core\Render\RendererInterface::renderInIsolation()
instead.
|
+--------+------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

emilorol’s picture

The fix for line 131 of "queue_ui/src/Form/ItemDetailForm.php" is this one:

$data = $this->renderer->renderPlain($data);

Change to this:

$data = $this->renderer->renderInIsolation($data);

benstallings’s picture

@emilorol thanks for the fix. See MR!47.

voleger’s picture

Version: 3.1.4 » 3.2.x-dev
Status: Reviewed & tested by the community » Needs work

3.1.x will not receive Drupal 11 compatibility. Please prepare changes to 3.2.x branch

voleger’s picture

Issue tags: -ProjectUpdateBotD11
ptmkenny’s picture

@benstallings Can you target 3.2.x for your MR? I tried to move it for you, but it seems only the person who created the merge request or a maintainer can change the target.

ptmkenny’s picture

I fixed the call to renderInIsolation, which was incorrect. renderInIsolation was introduced in 10.3, so using it without the deprecation helper will throw an exception on Drupal 10.2 and below.

See the change record.

nicolasgraph made their first commit to this issue’s fork.

nicolasgraph changed the visibility of the branch renderInIsolation to hidden.

nicolasgraph’s picture

Status: Needs work » Needs review

After pulling 3.2.x in the MR ; there is not much to change; upgrade_status is already happy !
Updating status for the 434070-manual-drupal-11 branch.

ptmkenny’s picture

This looks ok to me, but another option is to drop the core version requirement from composer.json.

Requiring drupal/core in composer.json is not required (if it is not required, the core version is pulled in from mymodule.info.yml), and it creates additional work every time core is updated.

voleger’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.