This module provide a custom field formatter for Bible references (simple plain text field) to szentiras.hu. The module is mainly for Hungarian Drupal users, since szentiras.hu provides Hungarian Bible translations only. Currently supports 3 behaviours:

  1. Simple link: create a link to szentiras.hu.
  2. Load text on click: on clicking loads the referenced text from szentiras.hu by its API.
  3. Auto load text: load all referenced text on page onload event from szentiras.hu by its API.

Similar projects: Szentirashu is a Drupal 7 reftagger modul for szentiras.hu.

Project page: https://www.drupal.org/sandbox/bubu/2805297

Git clone command: git clone --branch 8.x-1.x https://git.drupal.org/sandbox/bubu/2805297.git szentirashu_formatter

Pareview.sh: http://pareview.sh/pareview/httpgitdrupalorgsandboxbubu2805297git

Reviews of other projects:
https://www.drupal.org/node/2805677#comment-11656887
https://www.drupal.org/node/2789885#comment-11656965
https://www.drupal.org/node/2787053#comment-11657021

This is my 1st Drupal module.

Comments

bubu created an issue. See original summary.

bubu’s picture

Issue summary: View changes
bubu’s picture

Issue summary: View changes
PA robot’s picture

Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

bubu’s picture

Issue tags: +PAreview: review bonus
saveva’s picture

Hi @Bubu.

Invited to help a bit with the Review Process and the queue here are some remarks, the first and most important: I'm not the person to decide on that but the review process implicates that your code should be long enough to analyze coding skills and should not only consist of a few copied and adapted routines. This does not mean that your project isn't worth being published. You can always contact an administrator to publish the project in the project name space.

The goal of this application review process is to determine if your code allows to evaluate knowledge and skills and if the answer is yes to promote not only your project but you as a user.

Based on this introduction: Probably it would be a good idea to move both projects out of the sandbox, the [D7] and the [D8] version and to merge them into one project that you can maintain. Please see https://www.drupal.org/node/2505727

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
No: Does not follow the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements. / No: List of security issues identified.
Coding style & Drupal API usage
List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
  1. * As I pointed out above, your code is probably not long enough to promote your account. Please consider asking for a single project promotion.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Regards.
uh

saveva’s picture

Status: Needs review » Needs work
Issue tags: -PAreview: review bonus

Hi @bubu.

I've reviewed your reviews as well and at least two of the three reviews contain nothing more than findings of the automatic review process using pareview.sh. And this means that you're not qualifying for the review bonus.

Regards.
uh

saveva’s picture

bubu’s picture

Hi @saveva,
Thank you for the review. I'm grateful.
I have read the linked documents about single project promotion, but it's not clear for me,
1. how should I ask single project promotion,
2. why is marked "Needs work".

saveva’s picture

Hi @bubu.

If a single project promotion is ok for you, git administrators should be notified by the issue tag.

Regards.
uh

bubu’s picture

Hi @saveva,

1. I don't plan to create another module, so single project promotion is enough for me. It seems to me, you added "PAReview: Single project promote" tag in #8. That's it?

2. Why you changed status to "Needs work"? What should I do more?

Thanks!

saveva’s picture

Status: Needs work » Needs review

Hi @bubu.

I changed it to needs review.

uli

Warped’s picture

Status: Needs review » Postponed (maintainer needs more info)

Thank you for your contribution!

After 2017 March 7 everyone can promote a project to a full project.  A full project has a short project name and a drupal.org/project URL.  It can also have releases (like alpha1 or 1.0).  Edit your sandbox project, and then choose the 'Promote' tab.

https://www.drupal.org/docs/8/understanding-drupal-version-numbers/drupa...
https://www.drupal.org/docs/8/choosing-a-drupal-version/what-do-version-...
https://www.drupal.org/docs/8/understanding-drupal-version-numbers/what-...
https://www.drupal.org/docs/8/choosing-a-drupal-version/release-stable-v...

If you'd like to opt into security coverage, please ensure your module is ready for a full release, and then set this issue back to 'needs review'

Immense apologies for how long it took to get to this review completed.

apaderno’s picture

Status: Postponed (maintainer needs more info) » Closed (won't fix)
Issue tags: -PAreview: single application approval

I am closing due to lack of replies.

If you are still working on this application, and you need to be able to opt in the security coverage for the projects you maintain, please set the status to Needs review. (See also the project application workflow).