Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 Jan 2015 at 09:02 UTC
Updated:
1 Aug 2015 at 16:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mallezieComment #2
arunmv commentedHI Tim,
I have downloaded and installed the module and tried to create a new Maximum size crop effect in an image style. But it showed me a blank page. On reviewing the code I found that the function 'image_dimensions_max_resize' called in line 87 of the module file is not defined. When i commented the line 87, it is working fine.
Please fix this issue.
Comment #3
mallezieI've must overlooked that rename when cleaning up the code. This is fixed now.
Comment #4
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #5
nesta_ commentedWe can see a shadow in the image
Comment #6
mallezienguerrero, could you provide some more info?
I assume you're image already has this shadow?
Comment #7
nesta_ commentedYes Yes, sorry, i try and is ok! Good job!
Thanks!!!
Comment #8
nesta_ commentedI have reviewed both the configuration part as .module code, all is well structured and functioning as expected.
RTBC +1
Comment #9
mallezie@nguerrero: Thank you for the review. If all seems fine you can mark the status to RTBC.
Comment #10
nesta_ commentedI'm back to review it and used all configuration options, placing the crop in the 9 radio buttons and making maximization and perfect crop.
Comment #11
mallezieComment #12
cweagansThanks for your contribution!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #13
mallezieThank you for the review, and accepting the application! You just made my day!