Module name: OG Configurable Details Block (og_details)
http://drupal.org/sandbox/madmatter23/1225874

This module creates a more configurable alternative to the default OG Details block by allowing you to:

  • Limit create links by integrating w/ OG Audience By Type
  • Hide invite link
  • Hide member count link
  • Hide group manager link
  • Hide Join & My Membership links

This other OG Group Posting modules do not modify this block. Namely, Content Type Administration by Organic Group and OG Audience By Type.

Development
-----------

Rather than creating an admin setting page and simply using hook_og_links_alter() to unset links, I chose to create an alternate OG Details block. This will allow new links and content to be added that may be out of the scope of OG core.

Intended for 6.x with possible 7.x release.

Comments

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Active » Needs review
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Needs work

* README.TXT should be README.txt, see http://drupal.org/node/318#naming
* Remove all old CVS $Id$ tags, not needed anymore
* why do you need hook_enable()? you want to set the module weight once on installation. If the module is disabled and enabled again the weight is still there and does not need to updated again.
* "Implementation of hook_block()." Between doc block and function name should be no extra line. Also elsewhere.
* module: @file doc block is missing, see http://drupal.org/node/1354#files
* "//we only have one block" Comments should have a space after '//', should start upper cased and should end with a "."
* Comments should not exceed 80 characters.

grasmash’s picture

grasmash CreditAttribution: grasmash commented
Status: Needs work » Needs review

Thank you for the noting these changes. I've corrected the errors that you listed. Please let me know if there is anything more that should be done.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Needs work
  • git release branch missing, see http://drupal.org/node/1015226
  • README.txt is missing
  • og_details_og_abt_create_links(): there should be no new line between function and doc block
  • "Implementation of hook_block()." remove the extra empty line from the doc block.
  • 'This will disable the \'Invite Friend\' link': use double quotes to avoid the "\" in translatable strings. Such escaping may not be handled properly by .pot file generators for text translation, and it's also somewhat awkward to read.

Those issues are quite minor, so I think your module is nearly ready.

grasmash’s picture

grasmash CreditAttribution: grasmash commented

Thanks for the reply!

Sorry, forgot to 'git add' the new README.txt file.

grasmash’s picture

grasmash CreditAttribution: grasmash commented
Status: Needs work » Needs review

Ok, I've added the README.txt file and made the formatting changes that you mentioned.

I've also created a new git branch '6.x-1.x' and merged it with the master branch so that they're both up to date. Hope I understood the instructions right. Please let me know if you'd like me to set it up differently.

Thanks!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Reviewed & tested by the community

minor things:

  • lines in README.txt should not exceed 80 characters
  • "//save configuration to variable table": all comments should start capitalized, there should be a space after "//" and a "." at the end.

RTBC for me. Now while we are waiting for the access grants to create full projects would you be so kind to do a review of the other applications pending? Just pick one from this list: http://drupal.org/project/issues/projectapplications?status=8

grasmash’s picture

grasmash CreditAttribution: grasmash commented

Thanks, I've made those small changes and done a bit of module review to boot!

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, madmatter! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process AND for doing a review! As you know, anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to continue working in that process and join the group of reviewers.

As you continue to work on your module, keep in minde: Commit messages - providing history and credit and Release naming conventions.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Title: OG Configurable Details Block » [D6] OG Configurable Details Block
Issue summary: View changes