As described at https://www.drupal.org/project/prlp/issues/2572237 (that one is for D7), there are some cases when certain user roles are allowed to access/manage some site administration sections. But that's not the case for some "more sensitive" places, like this one.

Said that, I think it's better to have separated permissions. That way we can to decide if mentioned roles are able to access settings or not.

Patch in the way...

CommentFileSizeAuthor
#5 prlp-split_permissions-3126080-5.patch1.24 KBloze
#2 prlp-split_permissions-3126080-2.patch707 byteswaspper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

waspper created an issue. See original summary.

waspper’s picture

waspper CreditAttribution: waspper as a volunteer and at Skilld commented
FileSize
prlp-split_permissions-3126080-2.patch707 bytes

Attaching patch...

waspper’s picture

waspper CreditAttribution: waspper as a volunteer and at Skilld commented
Status: Active » Needs review
Jitesh Doshi’s picture

Jitesh Doshi CreditAttribution: Jitesh Doshi at SpinSpire commented
Status: Needs review » Postponed (maintainer needs more info)

Making this change will break existing installations. Can you please include a migration that assigns this new permission to all existing users that have the "administer users" permission?

loze’s picture

loze CreditAttribution: loze commented
Status: Postponed (maintainer needs more info) » Needs review
FileSize
prlp-split_permissions-3126080-5.patch1.24 KB

Here's a patch that adds an update hook.
Thanks.

qzmenko’s picture

qzmenko
Primary language Russian
Location Novosibirsk
CreditAttribution: qzmenko as a volunteer and at Attico International commented
Status: Needs review » Reviewed & tested by the community

Thanks, new permission works.

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
CreditAttribution: flocondetoile at Flocon de toile commented

Making this change will break existing installations. Can you please include a migration that assigns this new permission to all existing users that have the "administer users" permission?

Not sure patch #2 will break anything. Anyway, site administrators still get access to PRLP settings.

And in my case, this patch is useful because I don't want users with the permission "administer users" to be able to manage PRLP Settings. And in my case, when i give the permission "adminsiter users" I didn't want to give them the permision to manage PRLP settings. So In my mind patch #2 should be committed, not #5 which ensure that an unwanted situation is still present.

Otherwise RTBC++ (#2 or #5)