Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Wondering if it would be possible to add media video support to work similarly with a full-size photoswipe display setting, and then a thumbnail capture to click on to trigger the photoswipe?
Comments
Comment #2
dinazaur CreditAttribution: dinazaur as a volunteer and at DevBranch, Drupal Ukraine Community commentedThere is photoswipe-video-plugin which can be used for this. But I'm not sure if that's a good idea to include this module in this project, it may be better to implement separate module for this. Depending on ppl demand I can try to implement such a thing.
Comment #3
AnybodyThanks @dinazaur for pointing this out! I didn't know it yet.
Feel free to provide a submodule as MR or a separate module. We as maintainers won't invest much time here, instead the focus should be Photoshop 5: #3232070: [5.x] PhotoSwipe 5 Branch
Comment #4
AnybodyLet's tackle this in 5.x! :) I think video support would be really useful!
Comment #5
Anybody@thomas.frobieter: What do you think about the relevance of this feature for us? Would it help us a lot or possilby not very likely?
Comment #6
AnybodyComment #7
thomas.frobieterI don't think its really worth it (for us). The only thing where this might be better then using a simple modal, is the possibility to create combined galleries, with images and videos. But I cant remember that we ever really had the need for this.
Furthermore relying on such a plugin is probably bug prone, if PSWP will ever have this feature baked in.. fine.
But thats just my 2 cent.. if you want to invest time, I wont hold you back ;)
Comment #8
AnybodyComment #9
Grevil CreditAttribution: Grevil at DROWL.de commentedI doubt, that will be the case. Any extra features outside the basic photoswipe implementation is now a plugin (similiar to the photoswipe-dynamic-caption-plugin, which we already use as a submodule). And since the photoswipe-video-plugin is also by @dimsemenov (the creator of photoswipe), I'd say this is a feature we could definitely integrate if we ever need it!
Comment #10
AnybodySo our team is not interested in implementing this, until we need it, but happy to review MR's! :)
This should be implemented as submodule to be optional.
Comment #11
AnybodyEspecially with media, where "Video" is a valid media type, this would be nice. Still a feature request and nice to have, waiting for community MR's, if someone needs or sponsors it.
Comment #12
dinazaur CreditAttribution: dinazaur as a volunteer and at DevBranch, Drupal Ukraine Community commentedI'll take a look later when will have time.
Comment #13
AnybodyCool @dinazaur! :) #3375457: [5.x] Add support for the 'PhotoSwipe Tiled Deep Zoom Plugin' as submodule might be quite similar, I think.
Both should be provided as separate submodules, please.