Problem/Motivation

As of 8.8.x, modules can declare their Drupal 8 (or 9) upgrade status (changelog, issue #2936365: Migrate UI - allow modules to declare the state of their migrations).

Since #2953000: Migrate configuration from Drupal7 landed, this module appears to have a complete (finished) upgrade path from D7.

Proposed resolution

Declare the status of the migration in a migrations/state/pathauto.migrate_drupal.yml file.

Remaining tasks

  1. Write a patch
  2. Review and feedback
  3. RTBC and feedback
  4. Commit
  5. Release

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 3189713-2--declare-upgrade-status.patch631 bytesmparker17

Comments

mparker17 created an issue. See original summary.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3189713-2--declare-upgrade-status.patch631 bytes

Here's a patch. Reviews welcome.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented

To illustrate what the unpatched behavior looks like, here's a screenshot which includes Pathauto (courtesy of @PROMES in this issue for Redirect):

A screenshot of the Migrate Drupal UI showing that it detects an upgrade but the upgrade is not marked as finshed

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Declare upgrade status from D7 » [PP-2] Declare upgrade status from D7
Status: Needs review » Postponed
Related issues: +#3179835: Migrate forum pattern to taxonomy term forums if forum is enabled on the source site, +#3179865: [PP-1] Derive pathauto pattern migrations to solve inaccurate pattern migration dependencies

But the pathauto migration is not yet finished unfortunately.

See #3179835: Migrate forum pattern to taxonomy term forums if forum is enabled on the source site and #3179865: [PP-1] Derive pathauto pattern migrations to solve inaccurate pattern migration dependencies.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented

@Wim Leers, understood.

In that case, I daresay it would still be useful to site builders if we could (in the short term) explicitly mark that the migration is not finished yet in 8.x-1.x...

diff --git a/migrations/state/pathauto.migrate_drupal.yml b/migrations/state/pathauto.migrate_drupal.yml
new file mode 100644
index 0000000..70149e4
--- /dev/null
+++ b/migrations/state/pathauto.migrate_drupal.yml
@@ -0,0 +1,5 @@
+# https://www.drupal.org/project/pathauto/issues/3179865
+# https://www.drupal.org/project/pathauto/issues/3179835
+not_finished:
+  7:
+    pathauto: pathauto

... instead of leaving it ambiguous (i.e.: so someone doesn't mistake it for being finished, like I did).

And in the long term, modify the migration state to "finished" once 3179865 and 3179835 have landed. (I could either re-roll this issue, or close it and include the -not_finished: +finished: change in #3179865: [PP-1] Derive pathauto pattern migrations to solve inaccurate pattern migration dependencies (which looks like it will be the last of those two issues to be committed))

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

#5++

ressa’s picture

ressa
he/him
commented

I was a little surprised to see Pathauto listed under "Modules that will not be upgraded" on Migrate Drupal's "What will be upgraded?" page ... it would be fantastic if it got an upgrade path, considering that the majority of Drupal 7 sites are probably using Pathauto.

ressa’s picture

ressa
he/him
commented

Actually, the patterns do get migrated under /admin/config/search/path/patterns, so it works even, though it says it doesn't :-)

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented

I am happy to report that I was able to upgrade my drupal-7.99 site running pathauto-7.x-1.3 to a drupal-10.2.1 site running pathauto-8.x-1.12; and that the migration code already in the D10 version of the module was able to migrate my Pathauto patterns. Hopefully, my success will help other people migrating D7 to D10.

However, now that my D7 to D10 site migration is complete, my ability to contribute further to this issue is severely limited, because the D7 site that I had been using to test has been retired. But, I'll keep an eye on this issue and try to answer questions to the best of my ability.