Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Just adding this as a placeholder to decide if we want to provide an upgrade path. And if we do, perhaps use this issue to start the work on it. Linking to #2906878: [Meta] Support for D7 -> D9 contrib migrate
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#12 | pathauto-migrate-2953000-12.patch | 9.42 KB | slv_ |
| |||
#12 | interdiff.txt | 632 bytes | slv_ |
#9 | Selection_034.png | 109.91 KB | juampynr |
#9 | pathauto-migrate-2953000-9.patch | 9.42 KB | juampynr |
| |||
#9 | interdiff.txt | 742 bytes | juampynr |
Comments
Comment #2
juampynr CreditAttribution: juampynr at Lullabot for NBCUniversal commentedHere it is. This patch migrates module settings and patterns. I have seen some custom patterns that cannot be migrated automatically but this covers all of what comes with core such as content, users, and taxonomy patterns.
Comment #3
heddnI would really like to see this move into a source plugin. Could we extend the variable source plugin and do it all in a single class? Instead of spread across two places?
Comment #4
jcnventura CreditAttribution: jcnventura at Wunder commented@heddn I don't think this can be in a single class, since all the settings are config, but the patterns are entities.
In any case, regarding #3, it doesn't need to be in a source plugin, as it is simply a long list of variables going into a single config array. The new patch makes that without requiring a prepareRow() function.
Comment #5
heddnThanks for cleaning up the prepare row. This looks much more clean implementation.
This could at least use a unit test. See core/modules/color/tests/src/Kernel/Plugin/migrate/source/d7/ColorTest.php as an example to model.
Comment #6
jcnventura CreditAttribution: jcnventura at Wunder commentedAlso, the migration yml files should be prefixed with d7_.
Even if the Drupal 6 migration is the same, the yml files should be cloned, as the current ones are tagged 'Drupal 7'.
Comment #7
jcnventura CreditAttribution: jcnventura at Wunder commentedAlso, make this depend optionally on d7_node_type. If the pathauto migration is run before the d?_node_type, those paths depending on node type don't get imported.
Comment #8
jcnventura CreditAttribution: jcnventura at Wunder commentedNew patch, addressing my comments on #6 and #7.
Comment #9
juampynr CreditAttribution: juampynr at Lullabot for NBCUniversal commentedHere is a bug that I found while reviewing patterns. It was causing non-content patterns to contain invalid configuration.
Comment #10
DamienMcKennaTested this out on the Contrib Half Hour meeting this week and it worked as expected - the patterns were copied over from the D7 site and they worked as expected on new entities.
Comment #11
heddnWe could always use tests. But the basic code on here seems fine. No nits found. Actually just found 2. Bumping back to NW and tagging novice.
Label spelling.
Label spelling.
Comment #12
slv_ CreditAttribution: slv_ at Lullabot for NBCUniversal commentedRe-rolled patch to fix the label spelling.
Comment #14
BerdirThanks, looks like this has been sufficiently tested and reviewed, Tests would be nice, but I don't really see anyone going to do that.
I think this is just D7, so adjusting the title accordingly.
Comment #15
DamienMcKennaI created follow-up issues for related items: #3045639: Migrate Pathauto configuration from Drupal 6 and #3045638: Add test coverage for Pathauto - Drupal 7 migration