Problem/Motivation

In Claro admin theme, the preview button looks like:

Paragraphs previewer preview button screenshot current

Button classes should be adjusted according to the context.

Steps to reproduce

Just enable the module in a site using Claro as the admin theme.

Proposed resolution

In Paragraphs, button classes are set according to the "item mode" that is determined after a complex logic. Copy classes from existing button could be a way of avoid calculation of the appropriate button classes.

Remaining tasks

Review.

User interface changes

None.

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#3 2020-09-23_07-19-18.png47.36 KBDanny Englander
#2 paragraphs_previewer-preview_button_style_as_context-3164518-2.patch1.7 KBmanuel.adan
paragraphs_previewer-preview_button_screenshot_after_patch.png13.31 KBmanuel.adan
paragraphs_previewer-preview_button_screenshot_current.png13.88 KBmanuel.adan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

manuel.adan created an issue. See original summary.

manuel.adan’s picture

manuel.adan
Location 🌌
CreditAttribution: manuel.adan as a volunteer and at Arcovía Digital commented
Assigned: manuel.adan » Unassigned
Status: Active » Needs review
FileSize
paragraphs_previewer-preview_button_style_as_context-3164518-2.patch1.7 KB

After the patch:

paragraphs previewer button screenshot after patch

Danny Englander’s picture

Danny Englander
(he/him)
CreditAttribution: Danny Englander at Kanopi Studios commented
FileSize
2020-09-23_07-19-18.png47.36 KB

I've reviewed this patch and it looks good. I now see a nicely styled preview button when using the Claro admin theme.

Styled preview button in Claro

Danny Englander’s picture

Danny Englander
(he/him)
CreditAttribution: Danny Englander at Kanopi Studios commented
Status: Needs review » Reviewed & tested by the community

  • recrit committed 0a37860c on 8.x-1.x authored by manuel.adan 
    Issue #3164518 by manuel.adan: Preview button style according to the...
recrit’s picture

recrit CreditAttribution: recrit at Phase2 commented
Status: Reviewed & tested by the community » Fixed

looks good, committed to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.