Closed (fixed)
Project:
Nodequeue
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Jan 2010 at 00:01 UTC
Updated:
22 Oct 2010 at 13:50 UTC
Jump to comment: Most recent file
Hey Ezra and all,
Just wanted to check in and see if a Drupal 7 port had begun yet....
Thanks,
Ben
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 693032-d7.patch | 137.04 KB | agentrickard |
| #11 | 693032-nq-array.patch | 487 bytes | agentrickard |
| #9 | 693032-nq-node-access.patch | 1.27 KB | agentrickard |
| #5 | 693032_nodequeue_d7_port.patch | 115.92 KB | gdd |
Comments
Comment #1
ezra-g commentedThanks for asking.
Litwol contacted me privately to say he was working on it but I haven't heard from him since then. I would work on this closer to the D7 release time and will keep any updates in this issue.
Comment #2
Scott Reynolds commentedThis will be required: #698150: Update relationship handler to no longer use depreciated api once this lands: #503452: Retool exports to drill down properly
Comment #3
jstollerAny update on this task?
Comment #4
gddI have a mostly working port of nodequeue.module done, with some of the easier to automate tasks done for the submodules. Needs lots of work and testing but its getting there. I will try and get a patch together this weekend.
Comment #5
gddAttached is a patch for the start of the D7 port of nodequeue! It was rolled against HEAD as of about half an hour ago. It's a big patch as you might imagine. Most of the work has gone into the main nodequeue module, I did some very basic cleanup elsewhere, but it is completely untested and probably broken. However the main module has all the basic functionality in place - you can create/edit/delete nodequeues, add/remove/shuffle/reverse/etc. The draggable node management table works. The views integration is not updated. I ran coder upgrade so anything it changed i included. So... its a start. Some major changes
- admin/content is verboten now, so I put everything under admin/structure.
- I was having trouble in the beginning figuring out pager queries so they are all currently non-pager. In practice this probably isn't even a problem, I imagine it is pretty rare these screens actually get paged.
I have no idea how much more time I will have to devote to this coming up, so this is really for someone to pick up and continue on with. I may try and do some stuff here and there, but our client hours towards this are done and my personal Drupal work has to focus elsewhere for the time being.
Enjoy!
Comment #6
ezra-g commentedAwesome. Thanks!
I plan to have a personal D7CX sprint this week/end and will review this and hope to commit to a D7 branch :D.
Comment #7
justafishAny update on this?
Comment #8
ezra-g commentedI created a DRUPAL-6--2 branch and HEAD is now for D7. If someone re-rolls this so that it applies to HEAD (this no longer does), I'll commit it so we can file further issues against the D7 version. Thanks :)!
Comment #9
agentrickardQuick follow-up patch that needs to be rolled in. In D7, we have hook_node_access(), so nodequeue_node_access() is no longer a valid function.
Comment #10
ezra-g commentedThanks @agentrickard -- Could you roll this change into a single patch that HEAD which is currently identical to the DRUPAL-6--2 branch? Thanks!
Comment #11
agentrickardIf I get a chance, I will. Likely, since we need NQ on D7. In the meantime, another patch.
Comment #12
agentrickardTo heck with procrastination. Here's all three patches rolled against HEAD.
Comment #13
Manosk commentedHi, I've just downloaded Nodequeue 7.x-2.x-dev and installed in Drupal 7 alpha 7. Nodequeue doesn't work: "This version is not compatible with Drupal 7.x and should be replaced".
Comment #14
ezra-g commentedMarking as NR.
@Manosk, the D7 branch is not yet compatible with D7 -- that is the purpose of this patch.
Comment #15
boris mann commented@agentrickard -- seems to be some issues with smartqueue, but nodequeue as a first pass is working on D7.
Comment #16
gddThat should be right, I was mostly focused on nodequeue when I did the first patch but didn't get much beyond that other than what i could do global search-and-replace on.
Comment #17
ezra-g commentedI've committed this patch to HEAD, so it'll be in the next dev snapshot. Let's continue by filing new issues for the rest of the port.
Thanks, heyrocker and agentrickard! http://drupal.org/cvs?commit=432664
Comment #18
ezra-g commentedComment #19
Manosk commentedHi, I have installed Drupal 7 Beta 1 with 7.x-2.x-dev (2010 Oct 7). When I try to activate the Nodequeue *and* the Smartqueue taxonomy modules, I get the following message:
Notice: Object of class stdClass could not be converted to int in _menu_router_build() (line 3370 of C:\xampp\htdocs\d7b1\includes\menu.inc).
Notice: Object of class stdClass could not be converted to int in _menu_router_build() (line 3370 of C:\xampp\htdocs\d7b1\includes\menu.inc).
If I activate only the Nodequeue module, I get no warnings; but when I activate the Smartqueue taxonomy, I get the message again...
Comment #20
agentrickard@Manosk
Please open a separate issue.