See attached report.

Main issue is in the MS SQL server source plugin which uses unsupported mssql extension.
According to PHP.net PDO_ODBC is a multi-platform alternative - so is probably a good candidate to replace mssql extension.
For *nix OSs PDO_DBLIB is know to be working alternative.

To test this upgrade its possible to use Developer edition of SQL server.

CommentFileSizeAuthor
#11 mssql-functions-2928784-11.patch4.56 KBsidharthap
#5 mssql-functions-2928784-5.patch8.53 KBsidharthap
migrate-php7-compatibility-report.txt1.53 KBRoSk0
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RoSk0 created an issue. See original summary.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented
Issue summary: View changes

Adding additional notes and links.

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
CreditAttribution: bkosborne at Princeton University commented
Title: Make Migrate on D7 fully compatible with PHP 7 » Remove usage of mssql functions, they were removed in PHP 7.0

Updated title to target this issue specifically at fixing the mssql issue. The other issue you reported here about indirect variable access has been resolved already: #2654222: PHP7 Uniform Variable Syntax

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
CreditAttribution: bkosborne at Princeton University commented

I *think* that sites can still use the migrate module on PHP7 with this code in it, as long as they don't use the source plugin.

sidharthap’s picture

sidharthap
Primary language English
CreditAttribution: sidharthap at TATA Consultancy Services for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
mssql-functions-2928784-5.patch8.53 KB

Here is my first attempt to provide a patch. This patch includes
1 - SQLSRV an alternate driver for MSSQL and can be downloaded from here
2 - Openssl encrypt method instead of mcrypt. more information can be found here

Another patch is available for mcrypt which removes the functionality from module. http://php.net/manual/en/function.openssl-encrypt.php

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for Drupal Ukraine Community, GOLEMS GABB commented
Status: Needs review » Fixed

fixed here - https://cgit.drupalcode.org/migrate/commit/?id=cf0c989

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer and at Catalyst IT commented
Status: Fixed » Needs review

Hi @pifagor,

I think you missed something - commit that you referenced is related to mcrypt extension. This issue is talking about mssql functions.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
Status: Needs review » Needs work

@sidharthap we need recreate patch. And I will add authorship and credits.

sidharthap’s picture

sidharthap
Primary language English
CreditAttribution: sidharthap at TATA Consultancy Services for Pfizer, Inc. commented

@pifagor Thank you.
is this to create the patch only for mssql functions ?

sidharthap’s picture

sidharthap
Primary language English
CreditAttribution: sidharthap at TATA Consultancy Services for Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
mssql-functions-2928784-11.patch4.56 KB

Here is the patch only for this mssql issue.

  • pifagor committed 2112803 on 7.x-2.x authored by sidharthap 
    Issue #2928784 by sidharthap, RoSk0, pifagor, bkosborne: Remove usage of...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at GOLEMS GABB for GOLEMS GABB commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

https://www.drupal.org/project/migrate/releases/7.x-2.12