Parse image fields for image URLs [#2613654]

Currently, when an imagefield based token is used for the OG:Image metatag, the resulting metatag is output something like this (sanitized value from client site):

<meta property="og:image" content=" <img src="http://www.example.com/sites/default/files/sys/en/page/image/xxxx-contact-us-teaser-en_0.jpg" width="2048" height="750" alt="Contact Us" title="Contact Us" typeof="foaf:Image" />

I spoke about it with Damien and he said the D7 version has logic to pull out the URL that needs to be ported to D8. I'd be willing to give it a whirl but not sure how soon I'll be able to so I'm leaving this unassigned for now.

Comment	File	Size	Author
#7	metatag-n2613654-7.patch	18.48 KB	DamienMcKenna
#7	8.x-1.x: PHP 5.5 & MySQL 5.5 5 pass PHP 5.5 & PostgreSQL 9.1 5 pass PHP 5.5 & SQLite 3.8 5 pass PHP 5.6 & MySQL 5.5 5 pass PHP 7 & MySQL 5.5 5 pass
#4	metatag_parse-image-url_2613654-4.patch	17.86 KB	Michelle
#4	8.x-1.x: PHP 5.5 & MySQL 5.5 5 pass PHP 5.5 & PostgreSQL 9.1 5 pass PHP 5.5 & SQLite 3.8 5 pass PHP 5.6 & MySQL 5.5 5 pass PHP 7 & MySQL 5.5 5 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

11 November 2015 at 21:29

Michelle created an issue. See original summary.

Comment #2

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 17 November 2015 at 02:21

Parent issue:

» #2563607: Plan for Metatag 8.x-1.0-beta4 release

Lets add this to beta2.

Comment #3

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 23 November 2015 at 20:35

There are two parts to how this is handled in D7 - a) any meta tag that has the 'image' attribute set to TRUE tells the output generation to b) grep the output for any image tags.

Comment #4

Michelle

she/her

English

Wisconsin, USA

CreditAttribution: Michelle at Mediacurrent commented 25 November 2015 at 03:17

Status:

Active

» Needs review

File	Size
metatag_parse-image-url_2613654-4.patch	17.86 KB
8.x-1.x: PHP 5.5 & MySQL 5.5 5 pass PHP 5.5 & PostgreSQL 9.1 5 pass PHP 5.5 & SQLite 3.8 5 pass PHP 5.6 & MySQL 5.5 5 pass PHP 7 & MySQL 5.5 5 pass

Here is a patch that fixes the issue similar to D7 but I have a couple concerns:

Is output the best place to do this? Should it maybe be done right away when the value is set so that value() returns just the URL?
I can't figure out how field tokens are working at all for the client. I initially started working on this on a vanilla 8.0 site and it the field tokens weren't available. I did a little searching through the core issues and all I found was some old issues that indicate field tokens aren't in core, yet. It isn't due to the contrib Token module as Metatag doesn't make use of that, yet, and the client doesn't have it installed. So I'm baffled on how it works for them but not on a vanilla install.

Comment #5

Michelle

she/her

English

Wisconsin, USA

CreditAttribution: Michelle at Mediacurrent commented 25 November 2015 at 15:47

As for the field token mystery, it turns out that Token _is_ installed on the client's site and it just didn't come up in the filter for some reason. So the trick to getting field tokens to work is to have contrib Token installed plus this patch: #2543756: Use renderPlain() in field_tokens() . This works despite the fact that Metatag is using the core token rendering and _not_ the contrib Token version, which I wasn't expecting.

So, to test this patch:

Install Metatag _and_ Token.
Apply this patch to Token.
Add an image field to a node type.
Add a metatag field to that same node type.
Set OG:Image to use [node:field_yourimagefield] (replace field_yourimagefield with the actual field name)
View the source and the OG:Image metatag should just be a link to the image, not the whole HTML provided by the image field.

Comment #6

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 25 November 2015 at 19:45

Title:	OG:Image - Port ability to parse out URL from imagefield token	» Parse image fields for image URLs
Component:	Open Graph	» Code

Comment #7

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 25 November 2015 at 19:55

File	Size
metatag-n2613654-7.patch	18.48 KB
8.x-1.x: PHP 5.5 & MySQL 5.5 5 pass PHP 5.5 & PostgreSQL 9.1 5 pass PHP 5.5 & SQLite 3.8 5 pass PHP 5.6 & MySQL 5.5 5 pass PHP 7 & MySQL 5.5 5 pass

1 file was hidden/shown/deleted

File	Size
metatag_parse-image-url_2613654-4.patch	17.86 KB
8.x-1.x: PHP 5.5 & MySQL 5.5 5 pass PHP 5.5 & PostgreSQL 9.1 5 pass PHP 5.5 & SQLite 3.8 5 pass PHP 5.6 & MySQL 5.5 5 pass PHP 7 & MySQL 5.5 5 pass

This adds the two optional strings to the description of meta tags if they have the 'multiple' or 'image' items defined.

Comment #8

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 3 December 2015 at 20:13

Status:

Needs review

» Fixed

Committed.

Comment #9

3 December 2015 at 20:13

DamienMcKenna committed 357e7d7 on 8.x-1.x authored by Michelle

Issue #2613654 by Michelle, DamienMcKenna: Automatically parse fields...

Comment #10

juampynr CreditAttribution: juampynr at Lullabot commented 4 December 2015 at 10:10

I don't understand the need of the "multiple" property. @Michelle, can you explain it, please?

Comment #11

Michelle

she/her

English

Wisconsin, USA

CreditAttribution: Michelle at Mediacurrent commented 4 December 2015 at 14:03

It was in D7 and used in the code I ported so I ported it as well. I assume it's needed to provide multiple images to choose from like when you share a gallery on Facebook and you can scroll thru and decide which image to represent.